From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A06B445482; Mon, 17 Jun 2024 17:13:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 920024028B; Mon, 17 Jun 2024 17:13:51 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 2282E4028A for <dev@dpdk.org>; Mon, 17 Jun 2024 17:13:50 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f8507aac31so37997045ad.3 for <dev@dpdk.org>; Mon, 17 Jun 2024 08:13:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1718637229; x=1719242029; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DvaN0jQ+0zlLnKOqdCL2vo4rT+28Z/OEO1N8S/AIBMg=; b=Zg5DgALN8Vw+Knh/fhzDzUvTJZKMJEo91to+cw7KwjKOaH49OZ6zhZSqxhpnbUwX4+ QKtmPWrHsGDOtqAQrX4slwLXnKuUPKrCFz8IzwrWTI7r504M2VDIjfm867i8wmzMZClD 6mvSshRw0acn0V6oqUpU0m7jmfhcSlvB5Fhz4JmeE7BLFbf2Z6lk4IpDKtAYP4w1ip5z 7ofW6lGxc2lvM5UJeqii40oGGKTC4IBV0pOgd/yuEYvpQGQNeirF0Zbt1nDuS+Pqr3c4 ZmZXsGwT0/uptjA7fjNUnZc2njcVFuDS8A86Us2fHES2prVQ9Qms/Jldr4l859tdzHXV Jx8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718637229; x=1719242029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DvaN0jQ+0zlLnKOqdCL2vo4rT+28Z/OEO1N8S/AIBMg=; b=dBloQp6uh16+yZ0fDi6eIMTPNL8uo2KO2i8hgdsxvNJtTSN9B+V7bgxV/RN6naroHP rX14BGdLMfVygMZYXtusk7X4iXhMR6haErxNRXG8UTWm+pkedhEFSowQ/u6ZUkvp1Q9p ptmq8nwv4uKrypxwdhWOFykBP3iXnobX+89Hc9V7WZaB4Yj3sgIUkgJxcCukFfSFDxXp 7sXFjceqyd5nFCiCGjyMAA/uemdFEprB1AjVPfyc39jy7QMPSKgLnOXGqNkAITTHxOKT LqgldlVm2R8ICPLTajTUCp7NuFuRgZqQyMBDLnonevOd7uFnrFi09gwRUrjlRL394g+2 3mnA== X-Forwarded-Encrypted: i=1; AJvYcCWZs12IBs/0iZpCdaQHuIBGy+ktoTPgFKvSak0WYCkEIx8ST8z9cFqtX2abTs/28gQqrEla8BRjnTW3l+c= X-Gm-Message-State: AOJu0Yz/unVkIls/7rdcu4J9feIaplt/iqSeP7aeg0EHnnCuIkYWpvUm LYJIfrlXLpZEzgSn2uoGv1pKUZj+AXlA0cX8VruJlzlzltWRDTEaoUjVUGnnzRM= X-Google-Smtp-Source: AGHT+IELr0GJ2QYw8mWM4Z0fJiJ9ruzjTpGRG4+UfDwslkrf8xHVJGwfq4Abkxa8mOXl2ozQQGehhg== X-Received: by 2002:a17:902:a5c8:b0:1f8:5185:1cd4 with SMTP id d9443c01a7336-1f8627e4305mr108452555ad.33.1718637229130; Mon, 17 Jun 2024 08:13:49 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855e7f593sm79934045ad.107.2024.06.17.08.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 08:13:48 -0700 (PDT) Date: Mon, 17 Jun 2024 08:13:45 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Bruce Richardson <bruce.richardson@intel.com> Cc: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>, <stable@dpdk.org>, Chengwen Feng <fengchengwen@huawei.com>, Shaowei Sun <1819846787@qq.com> Subject: Re: [PATCH] telemetry: lower log level on socket error Message-ID: <20240617081345.7e5abe4f@hermes.local> In-Reply-To: <ZnBNmSFzhIva9hdC@bricha3-mobl1.ger.corp.intel.com> References: <20240606122654.2889214-1-david.marchand@redhat.com> <ZnBIAdAunG9XP3g8@bricha3-mobl1.ger.corp.intel.com> <20240617073943.16cc7f66@hermes.local> <ZnBNmSFzhIva9hdC@bricha3-mobl1.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Mon, 17 Jun 2024 15:52:09 +0100 Bruce Richardson <bruce.richardson@intel.com> wrote: > > > > > > Would it be also worthwhile having the probing process wait a small amount > > > of time or check for an input string before closing the socket? That should > > > avoid the error message being necessary at all for the case described. > > > > If telemetry used abstract socket path instead this would not be a problem. > > Using regular paths leads to races and problems with restart. > > And all the stat and runtime check logic could go away. > > Are abstract paths not linux-specific? Also, would using abstract paths not > mean that we need to implement some form of authentication on the > connections? Right now, using real paths in the DPDK runtime directory, a > regular user cannot connect to the telemetry of a process running as > another user or as root. Yes. But existing restart logic is brittle.