From: Chaoyong He <chaoyong.he@corigine.com>
To: dev@dpdk.org
Cc: oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,
Peng Zhang <peng.zhang@corigine.com>,
Chaoyong He <chaoyong.he@corigine.com>
Subject: [PATCH 6/6] net/nfp: add CPP service abnormal exit logic
Date: Wed, 19 Jun 2024 11:06:55 +0800 [thread overview]
Message-ID: <20240619030655.3216268-7-chaoyong.he@corigine.com> (raw)
In-Reply-To: <20240619030655.3216268-1-chaoyong.he@corigine.com>
From: Long Wu <long.wu@corigine.com>
As we already use the device argument to control the switch of
CPP service, it is time we can add the abnormal exit logic now.
Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
drivers/net/nfp/nfp_ethdev.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 696a301650..181798e8e3 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -2002,8 +2002,10 @@ nfp_pf_init(struct rte_pci_device *pci_dev)
/* Register the CPP bridge service here for primary use */
if (pf_dev->devargs.cpp_service_enable) {
ret = nfp_enable_cpp_service(pf_dev);
- if (ret != 0)
- PMD_INIT_LOG(INFO, "Enable cpp service failed.");
+ if (ret != 0) {
+ PMD_INIT_LOG(ERR, "Enable CPP service failed.");
+ goto hwqueues_cleanup;
+ }
}
return 0;
--
2.39.1
next prev parent reply other threads:[~2024-06-19 3:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 3:06 [PATCH 0/6] refactor the service module Chaoyong He
2024-06-19 3:06 ` [PATCH 1/6] net/nfp: fix check logic for device arguments Chaoyong He
2024-06-19 3:06 ` [PATCH 2/6] net/nfp: remove redundant NFP service code Chaoyong He
2024-06-19 3:06 ` [PATCH 3/6] net/nfp: remove the flower service dead loop Chaoyong He
2024-06-19 3:06 ` [PATCH 4/6] net/nfp: fix disable CPP service Chaoyong He
2024-06-19 3:06 ` [PATCH 5/6] net/nfp: add CPP service enable option Chaoyong He
2024-06-19 3:06 ` Chaoyong He [this message]
2024-07-06 18:51 ` [PATCH 0/6] refactor the service module Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619030655.3216268-7-chaoyong.he@corigine.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).