From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5609D454AA; Wed, 19 Jun 2024 16:55:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47FF540291; Wed, 19 Jun 2024 16:55:12 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id B839F40289 for ; Wed, 19 Jun 2024 16:55:10 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7061d37dc9bso1804253b3a.2 for ; Wed, 19 Jun 2024 07:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1718808910; x=1719413710; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GPrtmptgPcmZCB6wwAlmuQPAou4PNKq4hk3BASrfBgQ=; b=YnU3jutWc9IPzba7lNFpr+KL9nc0BmRcVa8uq/j2GNCZLXdt6idllW/q4MPyG6j51E 5YrpttlBoUlHSh6Tdg54Ty5Zrm7H6Y32H5ip3t9/n7/p8wTw7MJQlNfm3SgZoT4EKRQB QtJWFpP4Hkeab7qFutLBUaIDDQhvXI628mcbH3JhddiplMi311RUwmTZNledINZfvDvq Kvwm+WBh7Lfxw9Gvs3TCBmz3Np6VtZe5acJpZcV1yTLunaZtYRdDY48rMDWPwr3zC3YG 62TI1KuVZxk8obZnrGWpal2XmtinGmyBaADdBJ7X7HSizi29EmkM+JhdAbUU4F2RgKH5 r6zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718808910; x=1719413710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GPrtmptgPcmZCB6wwAlmuQPAou4PNKq4hk3BASrfBgQ=; b=mAA55Q/L5IXlH5hyVrlyM5mQgOEa8w0Yfnm24H62v4E4nS68hXe/wKEV8udKPE7Mg2 sSZj1tVjHo9Gk5XYt1gV0m0gfzsDJ1HI80vD7b5oL2tWVM9zR7ayH251jV5wRYy9/Bpi ZZ7W1EGbcP7y5vKqPhPBf+sBPfrxYGmnErAWGkAaPneeULwlMwuquOJ1J5v05TBmCTJu P5sqYZgSnmgEwz+9OUmCllSdyZXM3V1hAPlUW2Zpwm+DtWIgu7j4lDgEok3RJpamO35p uQoi8Ce/nnicgCXUneGMR7UxRCGxa3Rxbe7QJeya1A7mW3jSzVLUQlwOCnvNjH9J9b+O kOnQ== X-Gm-Message-State: AOJu0Yw4P49XIbft3jq3dK7i7olfeU+2TUySet6IyVwb48l34LPkPkiD 9YnzOvmfL+UqQKnm/x7G0N3E1+3bC/oWPZLuMbT6V5iad6pTmivZao4+vuT4sBo= X-Google-Smtp-Source: AGHT+IGmGDTPq/9gbgc/KxuQHH3R5h4b7qnKqnCveCRIVc7PaNSJwCza15FtKR2XXEmfxsJxlDQiGQ== X-Received: by 2002:a05:6a20:a723:b0:1b7:f59d:fd12 with SMTP id adf61e73a8af0-1bcbb646b16mr2658824637.55.1718808909823; Wed, 19 Jun 2024 07:55:09 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb3e4c5sm10758457b3a.130.2024.06.19.07.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jun 2024 07:55:09 -0700 (PDT) Date: Wed, 19 Jun 2024 07:54:23 -0700 From: Stephen Hemminger To: Huisong Li Cc: , , , , , , , , Subject: Re: [PATCH v3 2/2] examples/l3fwd-power: add PM QoS configuration Message-ID: <20240619075423.7b9cb76d@hermes.local> In-Reply-To: <20240619063144.20733-3-lihuisong@huawei.com> References: <20240320105529.5626-1-lihuisong@huawei.com> <20240619063144.20733-1-lihuisong@huawei.com> <20240619063144.20733-3-lihuisong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 19 Jun 2024 14:31:44 +0800 Huisong Li wrote: > + /* > + * Set the work CPU with strict latency limit to allow the > + * process running on the CPU can only enter the shallowest > + * idle state. > + */ Wording of that comment is awkward to read. Suggest: Set the worker lcore's to have strict latency limit to allow the CPU to enter the shallowest idle state.