From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02F5A454AA; Wed, 19 Jun 2024 17:01:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E28740291; Wed, 19 Jun 2024 17:01:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BCD5A40289 for ; Wed, 19 Jun 2024 17:01:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718809295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t4d/zgStRX1bkE4K/iMxi/BgodgL2M7zJMA0X0OMp5k=; b=fNzChb5u44ogURtz/kZEkLb9DZprRk1jqUwO1qmou/gXs6E+f3c6hfA1bBsc11EwuNNiTm NJ75OlmaMSYWTeAt1YmQk8lRt5d1gCwEJ8D2cKmU+HVtX0A7akauOv4JVNgiHw5xjl066Q D3LIkF7Xwqmru1+KY+sYjjQXDcWDDb4= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-6WBebHQlOXqMd2a1XVJw_g-1; Wed, 19 Jun 2024 11:01:33 -0400 X-MC-Unique: 6WBebHQlOXqMd2a1XVJw_g-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9BD14195608F; Wed, 19 Jun 2024 15:01:31 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.89]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 807141955E80; Wed, 19 Jun 2024 15:01:30 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: roretzla@linux.microsoft.com Subject: [PATCH v12 0/4] remove use of RTE_MARKER fields in libraries Date: Wed, 19 Jun 2024 17:01:22 +0200 Message-ID: <20240619150126.1037902-1-david.marchand@redhat.com> In-Reply-To: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting descriptor fields and removing cachline fields. RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields. For cacheline{0,1} fields remove fields entirely and use inline functions to prefetch. Provide new rearm_data and rx_descriptor_fields1 fields in anonymous unions as single element arrays of with types matching the original markers to maintain API compatibility. Note: diff is easier viewed with -b due to additional nesting from unions / structs that have been introduced. v12: * rebased, * did some cosmetic changes, * and resending to double check CI (v11 had an issue in UNH Debian containers), v11: * correct doxygen comment style for field documentation. v10: * move removal notices in in release notes from 24.03 to 24.07. v9: * provide narrowest possible libabigail.abignore to suppress removal of fields that were agreed are not actual abi changes. v8: * rx_descriptor_fields1 array is now constexpr sized to 24 / sizeof(void *) so that the array encompasses fields accessed via the array. * add a comment to rx_descriptor_fields1 array site noting that void * type of elements is retained for compatibility with existing drivers. * clean up comments of fields in rte_mbuf to be before the field they apply to instead of after. * duplicate alignas(RTE_CACHE_LINE_MIN_SIZE) into both legs of conditional compile for first field of cacheline 1 instead of once before conditional compile block. v7: * complete re-write of series, previous versions not noted. all reviewed-by and acked-by tags (if any) were removed. -- David Marchand Tyler Retzlaff (4): net/i40e: use mbuf prefetch helper mbuf: remove marker fields security: remove marker fields cryptodev: remove marker fields devtools/libabigail.abignore | 6 + doc/guides/rel_notes/release_24_07.rst | 3 + drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +- lib/cryptodev/cryptodev_pmd.h | 3 +- lib/mbuf/rte_mbuf.h | 4 +- lib/mbuf/rte_mbuf_core.h | 188 ++++++++++++------------ lib/security/rte_security_driver.h | 3 +- 7 files changed, 112 insertions(+), 97 deletions(-) -- 2.45.1