From: Stephen Hemminger <stephen@networkplumber.org>
To: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
Cc: Sunil Kumar Kori <skori@marvell.com>,
Rakesh Kudurumalla <rkudurumalla@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
dev@dpdk.org
Subject: Re: [PATCH] app/graph: fix destination buffer too small
Date: Sun, 23 Jun 2024 13:26:07 -0700 [thread overview]
Message-ID: <20240623132607.707a82e2@hermes.local> (raw)
In-Reply-To: <20240623200921.1715890-1-mahmoudmatook.mm@gmail.com>
On Mon, 24 Jun 2024 00:09:21 +0400
Mahmoud Maatuq <mahmoudmatook.mm@gmail.com> wrote:
> as sizeof(config.rx.mempool_name) is < sizeof(res->mempool), it's safer
> to copy min size of them to avoide out of bound memory write.
>
> Coverity issue: 415430
> Fixes: 3850cb06ab9c ("app/graph: add ethdev commands")
> Cc: skori@marvell.com
>
> Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@gmail.com>
NAK, this could create an invalid not null terminated string.
Since mempool name is a null terminated string this should have always
used strlcpy instead of memcpy.
next prev parent reply other threads:[~2024-06-23 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 20:09 Mahmoud Maatuq
2024-06-23 20:26 ` Stephen Hemminger [this message]
2024-06-26 20:22 ` Mahmoud Matook
2024-06-24 20:01 ` [PATCH v2] " Mahmoud Maatuq
2024-06-25 4:41 ` [EXTERNAL] " Kiran Kumar Kokkilagadda
2024-06-26 20:18 ` Mahmoud Matook
2024-06-27 0:43 ` Kiran Kumar Kokkilagadda
2024-07-04 15:17 ` David Marchand
2024-07-06 14:08 ` Mahmoud Matook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240623132607.707a82e2@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mahmoudmatook.mm@gmail.com \
--cc=ndabilpuram@marvell.com \
--cc=rkudurumalla@marvell.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).