From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1534454DE; Sun, 23 Jun 2024 22:26:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25842402AB; Sun, 23 Jun 2024 22:26:12 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id C186C402A8 for ; Sun, 23 Jun 2024 22:26:10 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1fa244db0b2so4749425ad.3 for ; Sun, 23 Jun 2024 13:26:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1719174370; x=1719779170; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lbP0zHFizAjmsA//gM+s+CTS+20rxdgxP9OPcrgY6pY=; b=ebAixcpTQpqEkyt4q4W6xQrWQZj2uEAtUpk4yD0nXZRJ/rkTzNjT83qC/wAcrJSAnU M4O2FktgUo/zjWkaJXEMzTNFl+erzkbKtG8TEqnJFsH2fwVwCQWPVHmvEXUS3s469cZv QkiVIzGfBgC0KURG1CRpEWM+AMpWb+YLqbByYA8bydIWCs+9zlCBMYcAEQgd9r16sp5C QjV9kHvJZY/99o6t5JfK2p7HzxuO94t/FOEdaHlwQZgdYWIHrV51m0qAWo5SHZRMw/vZ kbuNw/MgzCMB9x4ZTorSv06kdnZHiqkaQpMVqs/oTTxr3AAHBxH8qjCEXohBPfzXt2It Stjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719174370; x=1719779170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lbP0zHFizAjmsA//gM+s+CTS+20rxdgxP9OPcrgY6pY=; b=UvledTTriK50sA9ViccNJfCqZwRib9OzeSijdwe2gqU91ydP9lSzb4IkQtDkIjJWNR USnG2B8zVogUZnLL2JlaFh/SIpVxdAwYuMkSSH4XRs5viJieMyhHwewnbFucBGtB1Ube 61I+vRik5JiZLBm+e1p731dKrZHIMpByB1glR/fZeO4rOp6L6ifqPDf04tLTIjrrD2Lf peGOLkDGwtUi8rptbt5muVpkvy234av863z9YnwTfmLo8ecXN3s7sM8vUskHct4NpdnR sbLGyatS5M7EyhDVOodGtkMlehD+NmE/jljmUm+JezzoHjTyWg1hJB5LHprvZpBen13R bjYA== X-Forwarded-Encrypted: i=1; AJvYcCUkzLgqbYkeBbu4xh8IbNmJW0aphtpJsIDAEYnypRU4v9j2nqXXDXjBZBu2kkerNIurfXkInZhiVgQvtGM= X-Gm-Message-State: AOJu0Yy0SznUAFLREDftcU9jtTcyJI2muFzRM3lp/RXwlMu0wkzngPFl kil5fEOYghLu20U6y70ohDVGvowJu6U7hBDog+28GC06dEtFwEYnONSogujjqjE= X-Google-Smtp-Source: AGHT+IGYGjFezDsXvwrylrEUSasM5QKZ9K5gXcq+25LocuAVvCYosx6KyQ11fcGEqj1rF0douAFxHw== X-Received: by 2002:a17:902:d4c7:b0:1fa:128c:4315 with SMTP id d9443c01a7336-1fa15937ac6mr37123685ad.44.1719174369880; Sun, 23 Jun 2024 13:26:09 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fa061772d9sm33380395ad.208.2024.06.23.13.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jun 2024 13:26:09 -0700 (PDT) Date: Sun, 23 Jun 2024 13:26:07 -0700 From: Stephen Hemminger To: Mahmoud Maatuq Cc: Sunil Kumar Kori , Rakesh Kudurumalla , Jerin Jacob , Nithin Dabilpuram , dev@dpdk.org Subject: Re: [PATCH] app/graph: fix destination buffer too small Message-ID: <20240623132607.707a82e2@hermes.local> In-Reply-To: <20240623200921.1715890-1-mahmoudmatook.mm@gmail.com> References: <20240623200921.1715890-1-mahmoudmatook.mm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 24 Jun 2024 00:09:21 +0400 Mahmoud Maatuq wrote: > as sizeof(config.rx.mempool_name) is < sizeof(res->mempool), it's safer > to copy min size of them to avoide out of bound memory write. > > Coverity issue: 415430 > Fixes: 3850cb06ab9c ("app/graph: add ethdev commands") > Cc: skori@marvell.com > > Signed-off-by: Mahmoud Maatuq NAK, this could create an invalid not null terminated string. Since mempool name is a null terminated string this should have always used strlcpy instead of memcpy.