From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2312B454E5; Mon, 24 Jun 2024 21:42:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEE7E40A82; Mon, 24 Jun 2024 21:42:29 +0200 (CEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id C76EA40A76 for ; Mon, 24 Jun 2024 21:42:28 +0200 (CEST) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-6bce380eb9bso2858085a12.0 for ; Mon, 24 Jun 2024 12:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719258148; x=1719862948; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k6ET/MR/FsgjNrbIRVdikSHYCmz1bLbPDAd+mTMCyY8=; b=jWB9rr0fslklgE/SmCn05AdI/ldGLEpffxLD4RAviyVS8xgAIC8k2GFTFuQagDSDYf ME5bom8NqPpbibL7D3bApPV0OIGE91/AyN6QZRDJLrmOa/BfcNxhuo/HrqqjEQ+1dtn4 0NE4FgXDtAnEA00Uvb6OXlyT3NapIZrgtELkToX8DrqsSFGOActQkksK3VeuYZMRXc85 79BzLPM9d/rN59EIvJBO20x9/5gujfLp8W8fwcrCdMmOfmIk+hwodYUkJNzGk+KdT+i+ Gvhu9NJ/Ardr206zY5Y9utV3CxrS5+bif5hv8rB0eZOMEDCEDg751ohM79nwTg22zUI1 BHsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719258148; x=1719862948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k6ET/MR/FsgjNrbIRVdikSHYCmz1bLbPDAd+mTMCyY8=; b=ENnfFRTasYY+Ac6pXivQ4dwi3FbaYg76irDiptWdmhgJZg/9PvN94QO1PWKYs7cADM 1ijHWi081BZg5ucrUsui+X6C62QhGqp0OR3zVOirLtwFz86m0CD4tvF6NL5RPiiZFIeY 6C2Z0mz9ba2wAo6J7coH3KQ1Zff9NxSSYpRJyoiTkj0fsUO6l3il7pw2Al7ojzteT09u d7oY2sm7pliupW0e4R9SBL9b9sTVH5W8QIsMT3a7dSvLDDaOT4t+hw7FP9z0O+1RaEjU qH3q8pFHwmzNY5DiiwLm4tqair4cZ4Xhb7dge3MvP488/J25I49HJT6F0145yzJMr/Ds f+LQ== X-Gm-Message-State: AOJu0YxyVuSlAlrwWnBnzFa1hZ8qdar/UlsTm+GhTkrWnge5HtQuAzxY 08SbUwFdHgPyE7HY1hSzfyTchzdjRZhSuyOP/Itm9cW42oF9nWtN X-Google-Smtp-Source: AGHT+IFlZJOi08WbViX0YFWcmLer6k3ZlBJDRKyhu2mp78zv6hxlxbPGmbUQaM3YksYeIQBJ32xapA== X-Received: by 2002:a17:90b:3907:b0:2c7:ab33:e01 with SMTP id 98e67ed59e1d1-2c8582090e6mr4575870a91.27.1719258147591; Mon, 24 Jun 2024 12:42:27 -0700 (PDT) Received: from localhost.localdomain.xyz (bba-2-50-153-93.alshamil.net.ae. [2.50.153.93]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c819dbb7c6sm7086248a91.40.2024.06.24.12.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 12:42:27 -0700 (PDT) From: Mahmoud Maatuq To: Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Maayan Kashani Cc: dev@dpdk.org, Mahmoud Maatuq Subject: [PATCH v2] net/mlx5: fix memleak for resource object Date: Mon, 24 Jun 2024 23:41:51 +0400 Message-ID: <20240624194151.1788790-1-mahmoudmatook.mm@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> References: <20240623103539.1690600-1-mahmoudmatook.mm@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org this makes sure that the allocated resource object is freed for all branches that return NULL Coverity issue: 426424 Fixes: 27d171b88031 ("net/mlx5: abstract flow action and enable reconfigure") Cc: mkashani@nvidia.com Signed-off-by: Mahmoud Maatuq --- drivers/net/mlx5/mlx5_flow_dv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index d46beffd4c..8a0d58cb05 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -12010,9 +12010,12 @@ flow_matcher_create_cb(void *tool_ctx, void *cb_ctx) items = *((const struct rte_flow_item **)(ctx->data2)); resource->matcher_object = mlx5dr_bwc_matcher_create (resource->group->tbl, resource->priority, items); - if (!(resource->matcher_object)) + if (!resource->matcher_object) { + mlx5_free(resource); return NULL; + } #else + mlx5_free(resource); return NULL; #endif } -- 2.43.0