From: Mingjin Ye <mingjinx.ye@intel.com>
To: dev@dpdk.org
Cc: Mingjin Ye <mingjinx.ye@intel.com>,
stable@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: [PATCH v2] buildtools: fix invalid symbols
Date: Mon, 1 Jul 2024 10:33:15 +0000 [thread overview]
Message-ID: <20240701103315.835249-1-mingjinx.ye@intel.com> (raw)
In-Reply-To: <20240627101144.665413-1-mingjinx.ye@intel.com>
Elf files generated by higher version compilers wrap multiple
symbols prefixed with "this_pmd_name".
The patch uses the regex "^this_pmd_name[0-9]+$" to match the
symbol name.
Bugzilla ID: 1466
Fixes: 6c4bf8f42432 ("buildtools: add Python pmdinfogen")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
v2: Use regex ^this_pmd_name[0-9]+$ to filter symbols *names*
---
buildtools/pmdinfogen.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py
index 2a44f17bda..0fbcc697ed 100755
--- a/buildtools/pmdinfogen.py
+++ b/buildtools/pmdinfogen.py
@@ -6,6 +6,7 @@
import argparse
import ctypes
import json
+import re
import sys
import tempfile
@@ -70,7 +71,7 @@ def find_by_prefix(self, prefix):
prefix = prefix.encode("utf-8") if self._legacy_elftools else prefix
for i in range(self._symtab.num_symbols()):
symbol = self._symtab.get_symbol(i)
- if symbol.name.startswith(prefix):
+ if re.match(prefix, symbol.name):
yield ELFSymbol(self._image, symbol)
@@ -199,7 +200,7 @@ def dump(self, file):
def load_drivers(image):
drivers = []
- for symbol in image.find_by_prefix("this_pmd_name"):
+ for symbol in image.find_by_prefix("^this_pmd_name[0-9]+$"):
drivers.append(Driver.load(image, symbol))
return drivers
--
2.25.1
next prev parent reply other threads:[~2024-07-01 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 10:11 [PATCH] " Mingjin Ye
2024-06-27 10:50 ` Bruce Richardson
2024-06-27 12:39 ` David Marchand
2024-06-27 11:30 ` David Marchand
2024-07-01 10:33 ` Mingjin Ye [this message]
2024-07-03 1:30 ` [PATCH v2] " Jiale, SongX
2024-07-03 16:13 ` David Marchand
2024-07-05 8:25 ` [PATCH v3] " Mingjin Ye
2024-07-05 18:08 ` Ali Alnubani
2024-07-11 9:20 ` Jiale, SongX
2024-07-11 11:39 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701103315.835249-1-mingjinx.ye@intel.com \
--to=mingjinx.ye@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).