DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Fidaullah Noonari <fidaullah.noonari@emumba.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4] usertools: add check for IOMMU support in dpdk-devbind
Date: Mon, 1 Jul 2024 10:51:12 -0700	[thread overview]
Message-ID: <20240701105112.6b2cde71@hermes.local> (raw)
In-Reply-To: <20221012123817.112225-1-fidaullah.noonari@emumba.com>

On Wed, 12 Oct 2022 17:38:17 +0500
Fidaullah Noonari <fidaullah.noonari@emumba.com> wrote:

> binding with vfio driver, when IOMMU is disabled, causes program to crash.
> this patch adds a flag for noiommmu-mode. when this is set, if IOMMU is
> disabled, it changes vfio into unsafe noiommu mode and prints warning
> message.
> 
> Signed-off-by: Fidaullah Noonari <fidaullah.noonari@emumba.com>

Not sure why this patch got stuck.
The flake8 tool reports:


usertools/dpdk-devbind.py:489:27: E231 missing whitespace after ','
Fix by:

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index e7a5665fa2..a089313db1 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -486,7 +486,7 @@ def check_noiommu_mode():
     filename = "/sys/module/vfio/parameters/enable_unsafe_noiommu_mode"
 
     try:
-        with open(filename,"r") as f:
+        with open(filename, "r") as f:
             if f.read(1) == "1":
                 return
     except OSError as err:

  reply	other threads:[~2024-07-01 17:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15  6:26 [PATCH v2] " Fidaullah Noonari
2022-03-15  9:17 ` Bruce Richardson
2022-03-21 12:27 ` [PATCH v3] " Fidaullah Noonari
2022-03-31 14:37   ` Burakov, Anatoly
2022-03-31 14:44     ` Bruce Richardson
2022-10-10 23:02       ` Thomas Monjalon
2022-10-12 12:38   ` [PATCH v4] " Fidaullah Noonari
2024-07-01 17:51     ` Stephen Hemminger [this message]
2024-10-02 18:13     ` [PATCH] usertools/devbind: add support for non-IOMMU mode Stephen Hemminger
2024-10-03  9:27       ` Bruce Richardson
2024-10-17 15:34         ` Thomas Monjalon
2023-07-06 18:22   ` [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind Stephen Hemminger
2023-10-31 18:34   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240701105112.6b2cde71@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=fidaullah.noonari@emumba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).