From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id BD37045546;
Tue, 2 Jul 2024 04:48:02 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 99C4E402D8;
Tue, 2 Jul 2024 04:48:02 +0200 (CEST)
Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com
[209.85.214.175])
by mails.dpdk.org (Postfix) with ESMTP id C4EE2402B9
for <dev@dpdk.org>; Tue, 2 Jul 2024 04:48:01 +0200 (CEST)
Received: by mail-pl1-f175.google.com with SMTP id
d9443c01a7336-1f8395a530dso16183745ad.0
for <dev@dpdk.org>; Mon, 01 Jul 2024 19:48:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1719888481;
x=1720493281; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=t7hRIrpVQiBUN33GH1KO9XTX9HE61NX3ScEebzwYTSQ=;
b=bhWEhnOFfwB42qsbUPwd7cJC+EVEf1bDc/RxHXLlJLH1Ue9w+xpwqm0TZsxcddZTyA
z3HaYOs5BKks4SoCZHZwZReGFZi4a7/s4lKtJ0s5yI1U5AoXraCpNXf+NyKfODTcoHqq
+t3VaY5Yil55SIJbC3ZKjcguaiq4zvVRMFQW9TIQDfAtPWvERX0bgftWsdequ9TBD3VY
K4BUdgSpKTGUaK5foCp5Fv0fFlWZoKtKEullxI2t8wfQ0d1OUP48LGCqUIS8FOAxYMIN
1yDDxf+rQYLjn0HEM+HHZuabUvtBKCZgh4GYlcAYW0ORnaPiwd8vTKgIy4UPX5i8ZZft
bMTw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719888481; x=1720493281;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=t7hRIrpVQiBUN33GH1KO9XTX9HE61NX3ScEebzwYTSQ=;
b=qdn0iyWGKtk/DCezC6yXD4WULStoKCIyKs57L0K8et1OJIAeBrHk8IoYHQ19BTUT1Q
ztpZzYgKfdM9Anw6gvN/o/rsthdbwPLqcBpbMA51FHw8X0DrpH+WoLWaiDiks18/dqV6
NEFVjND4fy4DP1vK4UNbp6QbFLp4zI9Y74w0YTVf9SDR5xu7kTQBEXod58IQ4B3ThpBm
xrPUcUNNN0Ld1sW+pQ0Lt0WIvhzb16iEYwXBk/74wKkwWb51NxiZZ5MtEfEvlXOU6XBp
joxu7eoLf3Mxz2/yGGkI+W6MQeuXzr/ljSq6oojhPDAALrqwrWVkePfrP+N1qwkdZJHF
fE7g==
X-Gm-Message-State: AOJu0Yxx7nqvhJMlp8hiAxDkYIzbuMZ1IB4kdxnrV20pcxPBpQRgrPaI
GABGABxYL1/u7kDT6BOAEgkHZzTZmuHC31bAgj0F5S6i/8+zqYRtA7Eu+hiqquOph0hLzbLW3sX
WnsQ=
X-Google-Smtp-Source: AGHT+IGUvwg3ksxQPGef1AHWfUffMTIbtch7IC98VxUcbP4jsHKH8r/hm8oXGvPJ+yVDj4wRWbA9sQ==
X-Received: by 2002:a17:902:f688:b0:1fa:9c04:9450 with SMTP id
d9443c01a7336-1fadbca4adcmr45850125ad.30.1719888480883;
Mon, 01 Jul 2024 19:48:00 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-1fac1535d1fsm72264595ad.144.2024.07.01.19.48.00
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 01 Jul 2024 19:48:00 -0700 (PDT)
Date: Mon, 1 Jul 2024 19:47:58 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com, Zerun Fu
<zerun.fu@corigine.com>, Long Wu <long.wu@corigine.com>, Peng Zhang
<peng.zhang@corigine.com>
Subject: Re: [PATCH v5 1/3] bus/pci: rename the variable in UIO secondary
map logic
Message-ID: <20240701194758.5f99fceb@hermes.local>
In-Reply-To: <20240702021946.4194102-2-chaoyong.he@corigine.com>
References: <20240628073624.4122899-1-chaoyong.he@corigine.com>
<20240702021946.4194102-1-chaoyong.he@corigine.com>
<20240702021946.4194102-2-chaoyong.he@corigine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Tue, 2 Jul 2024 10:19:44 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:
> - int fd, i, j;
> + int fd, i, map_idx;
> struct mapped_pci_resource *uio_res;
> struct mapped_pci_res_list *uio_res_list =
> RTE_TAILQ_CAST(rte_uio_tailq.head, mapped_pci_res_list);
> @@ -37,41 +37,41 @@ pci_uio_map_secondary(struct rte_pci_device *dev)
> if (rte_pci_addr_cmp(&uio_res->pci_addr, &dev->addr))
> continue;
>
> - for (i = 0; i != uio_res->nb_maps; i++) {
> + for (map_idx = 0; map_idx != uio_res->nb_maps; map_idx++) {
> /*
> * open devname, to mmap it
Renaming i to map_idx and j to i does not change anything and makes the change
harder to read.