From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97B934554D; Tue, 2 Jul 2024 19:23:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 85719402AD; Tue, 2 Jul 2024 19:23:12 +0200 (CEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id 6835540260 for ; Tue, 2 Jul 2024 19:23:10 +0200 (CEST) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-7163489149eso2915120a12.1 for ; Tue, 02 Jul 2024 10:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1719940989; x=1720545789; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:subject:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=SucPlKTXLiv0PKG4NzdvAKZIBs6k7Ru8j0FTZ2NhOPk=; b=lWBq6nW6/0DhKGOXAM+fh5T8qLBit6AFM6QLddMOZbkAPntKiTHGBJ2Dy9D7vPU0gB 61omTbmqQgjpPHzbNPLuY+nZePISYSHtReSLjMC4mOesmo8zThIP79q+dUV8cKogpooE 9wrGWzvAbWhUvlBTa90DmxTGGmlqgOEPUCNHEXVaunUHEJQ7KqCO9FYamkoPFm9TYqa8 DWoPPbDAW0mvOfP4o6FnfQ0SJb/g56Syv1cCQroykCtjEf8iFFr2GmP0vyRZELOkc+vq VtWJFWyt8GVWNxXjkxiVVTxn7PRbr6Xl3YChEM1Rx+10y++uhHkpIQKgOV0B6VmOrf1r 9VQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719940989; x=1720545789; h=content-transfer-encoding:mime-version:message-id:subject:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SucPlKTXLiv0PKG4NzdvAKZIBs6k7Ru8j0FTZ2NhOPk=; b=i+M40gah4WGc5anEiG9hZu0uHm3IfGn2bRLLOo0MeFmgwbvhRzgPogQuzSp6ypnlna z7qqyWFkpAarOCKhWt1e3+lZz5DI4Yb11FSLMfHmYyLmSOzH3BcJu8ojCY9mH3E34qBg 27ltLZUYwPJ5r23TVUHh2YiA4fePhxYp+N2J9knDmuKBngRGrKdBue81lGBJ9crzO26C oMGIfh4WajYuBKdozdQV7CNBYhjP6pADxDp2h9WN6SkkD8Kp5igK/RU4z+BziW1xWDzP h0ysYYLBvkCqcoB87/n3GIJ+pgyxfTJHoiQjznGV0l0PjelmZfy6B6U6WG1+0VS9KMk6 VNMw== X-Gm-Message-State: AOJu0YxdGLDqwT76LZYIMH3EZx8nJNyeexpakocuzm+IRFZ0iFTrj2Fe W4U1tkZvsHXcAOfby3OPcLsFgIbG8lLjfz6q8MABBVBBsScQuRyM41dFbTlgpZFxGGbkDdNJgpQ Tvis= X-Google-Smtp-Source: AGHT+IFioUVW0Ft7wl+lm+iorgzUxDSD6vA52UyhFv+ZOOErZzKk9Il/hdOyCs1BAvia6vCQJnoPgw== X-Received: by 2002:a05:6a20:9191:b0:1be:d260:93c1 with SMTP id adf61e73a8af0-1bef60fce2bmr14557670637.9.1719940986777; Tue, 02 Jul 2024 10:23:06 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1face441ae0sm79936215ad.261.2024.07.02.10.23.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 10:23:06 -0700 (PDT) Date: Tue, 2 Jul 2024 10:23:04 -0700 From: Stephen Hemminger To: dev@dpdk.org Subject: DPDK and signal safety Message-ID: <20240702102304.76bd504a@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The recent CVE in OpenSSH related signal safety piqued my interest in any possible issues in DPDK. While reviewing: - The use of SIGBUS in linux/eal_dev is problematic. It is using not signal safe routines such as rte_spinlock and logging. This was done as part of hotplug support. - The use of SIGBUS in eal_memmalloc is ok, since it is limited in scope and only while alloc_seg() - Tap uses rt sig and is sigsafe since only updating flag. - FPGA driver is catching SIGINT in update_flash. it calls dev_info which is not sig safe. SIGINT is not enough here, what about SIGTERM or SIGHUP? And overriding application signals does not appear to be documented.