From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C07F04554D; Tue, 2 Jul 2024 15:09:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 761D54067C; Tue, 2 Jul 2024 15:09:18 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2087.outbound.protection.outlook.com [40.107.20.87]) by mails.dpdk.org (Postfix) with ESMTP id 0FBAC402EC for ; Tue, 2 Jul 2024 15:09:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKLB9ZvX8k+fEqIsZO6ljI+re2w/jKy/Y/Gv5AchuWyYzT/A8NO7f1BpjLHCcL6W0Sx3khCh+CFSlq73koKJfhmAal/0HRjaqpym2ZY0TXzzArUL6uRVVEMiVf2RzxjGp/nd+0NgPVF/2yxExQj2Zptgx8q6K0p1sls00A8j3MpIufIPgmLX3AWj7Tcol24WY+5oRa4OqDtM//YvZCsYoMd/RI/fkBGdGxgNn8sudTxH6SduTDJV7aR+q0fKa1ujl2fxVCnPeBEbRc85/V8cchkSgUmJA+W0soqJkgRjA9UlGD3mMzfqZP1y5/4REIwmhoxLEAAsUrBsEmDNhbgXxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=raZTg3uoG+8TZVxV+DzJGNi8o49uEd9aJMq3yVuxGYE=; b=lnJOAoooTgj3S96/64kMLSKbuzN//hgJu9/SneMw714E885E8PTdPUwMLqtdj/v68rcMXVYsRd9BxKmg3hyc2sqCJ6m1oRY3v7rGNj/b1O9CXPIJDcTkEJNgpqym+jD//oxt0odJ+Nd4JT/6BGc+F6YNVCuYcp8u0RtmFRV6bPxf1rVGWP46MKOSMtFUaXhKBbing0tlfQt64cz7RH8hykAiRUnS99OpLBGxrMLvW660OKTuLF4Tz9DkSWZhdc1LJipFTryDl7NgsmcWuC454O4rzfRuL4YRgxPc8bzhSrPBIrbD1TqpXLkzjvaDd4Wlpjp1bR2VYRZNkLXf/yUrLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=raZTg3uoG+8TZVxV+DzJGNi8o49uEd9aJMq3yVuxGYE=; b=Wds5HRWjFFxYFPTmbqr4mX5vR2CuQOtCOrQgs+8sVKHyw5+L9BQ2M0mo8djYVMWks+b6PqpmjjOYGrUxbYmj2/p2sugjXor3BhQbvdVUgdgTbjjJR92V2pnZ/ph61cSRQs0fO2d2TclviedJ8ZZZ4bd1vLTU1C3u6P2iHCzWFyk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by AM8PR04MB7906.eurprd04.prod.outlook.com (2603:10a6:20b:24e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.34; Tue, 2 Jul 2024 13:09:14 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%4]) with mapi id 15.20.7719.028; Tue, 2 Jul 2024 13:09:14 +0000 From: Hemant Agrawal To: dev@dpdk.org, thomas@monjalon.net, stephen@networkplumber.org, david.marchand@redhat.com Subject: [PATCH v3 2/3] bus/dpaa: remove double newline Date: Tue, 2 Jul 2024 18:38:55 +0530 Message-Id: <20240702130856.3927348-2-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240702130856.3927348-1-hemant.agrawal@nxp.com> References: <20240702104013.3813272-1-hemant.agrawal@nxp.com> <20240702130856.3927348-1-hemant.agrawal@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SG2PR02CA0120.apcprd02.prod.outlook.com (2603:1096:4:92::36) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|AM8PR04MB7906:EE_ X-MS-Office365-Filtering-Correlation-Id: 28fb63fa-0915-43c4-aefe-08dc9a982bc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fwUUh4TEA+BMqp9kOIoUi1Y/FmCCKndThKqz/4WjZLiCZVrukiIpfym0AuDy?= =?us-ascii?Q?hHJnCPt4T3gIf0kgmt5sg31X1tMqFv57NYZ72UJecnbkOIAzlkgqTS3uZctf?= =?us-ascii?Q?BQ41ij5x9f9oZHSe0HtgnTS8uqNE0b2+r6W7Ygw+fs2Njtl7upGAfcyUEnTy?= =?us-ascii?Q?t1ursU01vG1CzmtWttgu8phiDeM36ZOI4H8msX07iT6BaAYgja+A2Q75jloX?= =?us-ascii?Q?utCddbKKKxNG5aXXUrnYI6UroIhZwGExltbM2Cav1GjDrF+qLPlUPHteOY6C?= =?us-ascii?Q?h0ynAwKeU9Na6lGn/VcVNIC9S6Oy9agwz2eV23RmkwvQDuznY2HK5/gtSnpl?= =?us-ascii?Q?iMGGxrRO0GoYi2d+KtqY94NYy0PDzsTMPEiETcGrdwl4DKIMI9Jt1Y1ORX7E?= =?us-ascii?Q?0kHfKMwxvXxyGEVVnHkOp55eBCIgegbn4aSKLI1pGsP1eFBPi2yDJHSRu42+?= =?us-ascii?Q?0/hORXg2k39vhZc8VbHjm/9INAlisimBrrA7LUQh6TJAZHIV4+EoeL/Bu1RB?= =?us-ascii?Q?0V0byTTn10uRh/ZUoJdatKAv/XCHyyAdvUlkoJ8VhTPhBSY0OlI4bOLpgJu5?= =?us-ascii?Q?RfOI3j0/SVSMM55Tv8BB/m//zM5hEGDRzvS6+z6QAN4euugUzow0XqEbeELC?= =?us-ascii?Q?E0U3JHn+zdBi7bLvBEdDVWGGzBWwx9nFTz057xsXUm+rq4RIPvEzeB64KoqS?= =?us-ascii?Q?g86GeHOlBB2z2wWu7K5+fd2TUD2Uqu2EbmMrEqquWP0vvMHgu4OoCM78AECP?= =?us-ascii?Q?fen2a9Z2/kOTDEmb9WrCIgI+JTdIaG3eiIQJAg6PHAGCdHP0FJ6DgSIa1a80?= =?us-ascii?Q?osxGIXSSv3mWvWYBNgCDZO59LxqeSRWouu02ACVRYvfh43DWkBJ0pTVdpVvm?= =?us-ascii?Q?dpGz5pEKcj+FAJE1TOhaJsxSa5NqucvLaYuxbeXOTuJHwuqgeTT7coD0yg7N?= =?us-ascii?Q?bOzP38Pk3AiTxIPcHUkIL967UcNMA5AwNAV5HOK5ZC0+fKWJ6Eo9C+qkCYCa?= =?us-ascii?Q?XdlZx9vrFGRgDag3kvy03IQ3ggv6L4isrldwu0N0HydUMycvG/vLoNaaPrH/?= =?us-ascii?Q?fFiwXgSc12hG5ZvtTd3q+LcO3K97nxdXsEVtmkzrxyYHkxymieCJvyFy8cD1?= =?us-ascii?Q?J8CGLNoPHTycRNnNec1R8XpMuAykC7QBiMyKnNI+DHvCZX80X/A5LtyJVjZQ?= =?us-ascii?Q?Lyyr0i02OtuCPh+2YmKtWQ0CVOR8Aghva+RNzsBuOEHWGYOQC+w28c2Kpvox?= =?us-ascii?Q?rkx6OTXKdpFC7EP+3NzBM0tfhkDNJQZvmqt6ukmBJWvCITLfrDceVSmc/iWR?= =?us-ascii?Q?72kjTZh4I9DNhtQ+UDskDHrSs6GpJ1Re7K7ABXoH8V1cuOoZQhU2uxIHJv+x?= =?us-ascii?Q?pNLGiIOGS37DeWvblcb8CA6kHqTPL1Zx63c/8BGA64ayNmfVoA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Npr4U74lUfL7XrzBkofkx2FlSl84YaTqs8s9tsn9HOEb+KBxbIGJgTxlRP1p?= =?us-ascii?Q?gasPP17jyYf+eI6b2fmKaOZcVRKgu8foSUw5QvTTSOeeR9veySgqB5dDcOtU?= =?us-ascii?Q?1+KnAmgQ3LAmTYV6G09qfkiAq/k3qWGgU9ymVKuC4q21ZKv78WSlmOSSDrNi?= =?us-ascii?Q?AD4hJqKgfC8YwWgyxMkORJ5nQ9BEXo/3zSw3CaDXlDE0HuuNysLpTf7J8lg4?= =?us-ascii?Q?ARRHAZsuSgPUREodWjZ5bQIWl0D6bMBofiSraI0n9FAyBMUN1RABhLnd7dcF?= =?us-ascii?Q?dFI4fyZMLTlXp9DGpyldSL19j+ojFk2H7zTk7JM5eOPDeJR0xiYLh1S4J4z+?= =?us-ascii?Q?4PP7mpfLn0y998efrwbMxqvNwIKGhCe/supGdkzSYz4jaet9L5YDA+k8nrTZ?= =?us-ascii?Q?mPT++8rNr1FhGjlnll3jPo2jkPsSzF5jauV+lH7cQmyKtlvoYUjkCBH/LrAB?= =?us-ascii?Q?dGiU5afXw4XciS6Zk8QUiUoFsBhKsLn0b77JFcEhU5XMIbTeqLhFA8ycqAnj?= =?us-ascii?Q?GQq03EE/D7Q23wXTjZlruYEvUv2wik7SYF2k2aDmIx0Y5RMVz97AYZUi4GdT?= =?us-ascii?Q?tKOK94NmHIVPzbsCW9wia5Fb/0PEzanSS/zO0b2AH5rshpNPRi0+XLjr5PKR?= =?us-ascii?Q?dTworitlmGbVVqMnAyGv2ZzhdQ++LtEKZqNPksyxuvSZTcvVFVZgIwXDvOYB?= =?us-ascii?Q?c3lhEVJTGOKLW5T8FqUG/XBis08PLqsCu05U8IQYp5eLzF1wQxugYdvH0vGW?= =?us-ascii?Q?AH4s6qFKUl+toSJlSXSrlzXXLVFg8mQDSBYQiLSnDYQDZrkfudlPkpuV6dHB?= =?us-ascii?Q?KXmLNB4n1jo0Y/FvNQ70/T7u9PeSgi16OBaPXBPRN3Jiu5AVEBwH4xOPJSnm?= =?us-ascii?Q?cQbRsMobsCRhOobUfrGLL5HT3ovo3cn5hLtOvjbLwZhTUqYI8FK9MyPl4+Uu?= =?us-ascii?Q?h0fseaKj8Tx3YJK+z0Ing8aKaM/qgZRw+bZU7qTr1V870FWxrTd6rUyal8k0?= =?us-ascii?Q?VQXrS6pXqn3K9bQhSAilvZU/zJqDFXGqUvwcvs/G13ksJpI14iSzqjYFNTWn?= =?us-ascii?Q?60lNk4r5Vj4Atb1kGBImRsdE9SnaRNN6/otvEQyxDloYLk8hL+g+YNl7zqOE?= =?us-ascii?Q?IK/wy/49amo6maw9PQev4wD978YjzaGP1Dew1RbqISOSfpLEzsSDuO/AkKm8?= =?us-ascii?Q?Sf72ONy3Q3FSzud4iWYyZIQTLFtieNIAarbYuXMfHfT3HKZIKY7YkgXBX9Ve?= =?us-ascii?Q?GNdOy6LoNdc1hfZC1vlxLkYY7c1nWBd2lQtme6RsW4bIOKGb/kh5d+y3gfj7?= =?us-ascii?Q?3OHMfQuVjdAyMreYHzf2yObegPtzIUqYN58DUgyqlyNfDutXMwAt1V7Jq6Tp?= =?us-ascii?Q?D4Ihl+IEX1bas3YHDZiH1u+3f4CIaO3K6Gc0Y7cCn+wjfOrGxS695fICF507?= =?us-ascii?Q?6+5RkgqeeldNN9zojni9gnge3BAOFL4hDHlGl9uCgLb6rHVeaQuNQ7OIIH8g?= =?us-ascii?Q?TFxtJcBU7PfAUKmcw82aDG33XJC6Iwu7utf0sOx2RQ7KKPj5vecDQVghL0xQ?= =?us-ascii?Q?ZOqaYz3ddd06R0bm83KDYHvwnCTp+mMifVzlcz7eEXF+Z86NalPGK+XtrOHl?= =?us-ascii?Q?HA=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28fb63fa-0915-43c4-aefe-08dc9a982bc1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jul 2024 13:09:14.0894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b0sbLH1U5kiAIRZj8fueO+UwAtG8Fe4z7H9/fOquWuih0mNRBJCM/FnKzk/kH/LUwcBFXeNeFZuT5TsHFE/FSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7906 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove duplicate newline `\n` from the debugging macros to avoid double `\n\n`. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/fman/fman.c | 58 +++++++++++++++---------------- drivers/bus/dpaa/dpaa_bus.c | 12 +++---- 2 files changed, 34 insertions(+), 36 deletions(-) diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman/fman.c index 953f7d7061..41195eb0a7 100644 --- a/drivers/bus/dpaa/base/fman/fman.c +++ b/drivers/bus/dpaa/base/fman/fman.c @@ -244,13 +244,13 @@ fman_if_init(const struct device_node *dpa_node) /* Obtain the MAC node used by this interface except macless */ mac_phandle = of_get_property(dpa_node, mprop, &lenp); if (!mac_phandle) { - FMAN_ERR(-EINVAL, "%s: no %s\n", dname, mprop); + FMAN_ERR(-EINVAL, "%s: no %s", dname, mprop); return -EINVAL; } assert(lenp == sizeof(phandle)); mac_node = of_find_node_by_phandle(*mac_phandle); if (!mac_node) { - FMAN_ERR(-ENXIO, "%s: bad 'fsl,fman-mac\n", dname); + FMAN_ERR(-ENXIO, "%s: bad 'fsl,fman-mac", dname); return -ENXIO; } mname = mac_node->full_name; @@ -262,19 +262,19 @@ fman_if_init(const struct device_node *dpa_node) ports_phandle = of_get_property(mac_node, "fsl,fman-ports", &lenp); if (!ports_phandle) { - FMAN_ERR(-EINVAL, "%s: no fsl,port-handles\n", + FMAN_ERR(-EINVAL, "%s: no fsl,port-handles", mname); return -EINVAL; } assert(lenp == (2 * sizeof(phandle))); rx_node = of_find_node_by_phandle(ports_phandle[0]); if (!rx_node) { - FMAN_ERR(-ENXIO, "%s: bad fsl,port-handle[0]\n", mname); + FMAN_ERR(-ENXIO, "%s: bad fsl,port-handle[0]", mname); return -ENXIO; } tx_node = of_find_node_by_phandle(ports_phandle[1]); if (!tx_node) { - FMAN_ERR(-ENXIO, "%s: bad fsl,port-handle[1]\n", mname); + FMAN_ERR(-ENXIO, "%s: bad fsl,port-handle[1]", mname); return -ENXIO; } @@ -282,8 +282,7 @@ fman_if_init(const struct device_node *dpa_node) if (of_device_is_compatible(dpa_node, "fsl,dpa-ethernet")) { port_cell_idx = of_get_property(rx_node, "cell-index", &lenp); if (!port_cell_idx) { - FMAN_ERR(-ENXIO, - "%s: no cell-index for port\n", mname); + FMAN_ERR(-ENXIO, "%s: no cell-index for port", mname); return -ENXIO; } assert(lenp == sizeof(*port_cell_idx)); @@ -305,8 +304,7 @@ fman_if_init(const struct device_node *dpa_node) ext_args_cell_idx = of_get_property(ext_args_node, "cell-index", &lenp); if (!ext_args_cell_idx) { - FMAN_ERR(-ENXIO, - "%s: no cell-index for ext args\n", + FMAN_ERR(-ENXIO, "%s: no cell-index for ext args", mname); return -ENXIO; } @@ -343,7 +341,7 @@ fman_if_init(const struct device_node *dpa_node) /* Allocate an object for this network interface */ __if = rte_malloc(NULL, sizeof(*__if), RTE_CACHE_LINE_SIZE); if (!__if) { - FMAN_ERR(-ENOMEM, "malloc(%zu)\n", sizeof(*__if)); + FMAN_ERR(-ENOMEM, "malloc(%zu)", sizeof(*__if)); goto err; } memset(__if, 0, sizeof(*__if)); @@ -356,12 +354,12 @@ fman_if_init(const struct device_node *dpa_node) /* Map the CCSR regs for the MAC node */ regs_addr = of_get_address(mac_node, 0, &__if->regs_size, NULL); if (!regs_addr) { - FMAN_ERR(-EINVAL, "of_get_address(%s)\n", mname); + FMAN_ERR(-EINVAL, "of_get_address(%s)", mname); goto err; } phys_addr = of_translate_address(mac_node, regs_addr); if (!phys_addr) { - FMAN_ERR(-EINVAL, "of_translate_address(%s, %p)\n", + FMAN_ERR(-EINVAL, "of_translate_address(%s, %p)", mname, regs_addr); goto err; } @@ -369,7 +367,7 @@ fman_if_init(const struct device_node *dpa_node) PROT_READ | PROT_WRITE, MAP_SHARED, fman_ccsr_map_fd, phys_addr); if (__if->ccsr_map == MAP_FAILED) { - FMAN_ERR(-errno, "mmap(0x%"PRIx64")\n", phys_addr); + FMAN_ERR(-errno, "mmap(0x%"PRIx64")", phys_addr); goto err; } na = of_n_addr_cells(mac_node); @@ -380,13 +378,13 @@ fman_if_init(const struct device_node *dpa_node) fman_node = of_get_parent(mac_node); na = of_n_addr_cells(mac_node); if (!fman_node) { - FMAN_ERR(-ENXIO, "of_get_parent(%s)\n", mname); + FMAN_ERR(-ENXIO, "of_get_parent(%s)", mname); goto err; } fname = fman_node->full_name; cell_idx = of_get_property(fman_node, "cell-index", &lenp); if (!cell_idx) { - FMAN_ERR(-ENXIO, "%s: no cell-index)\n", fname); + FMAN_ERR(-ENXIO, "%s: no cell-index)", fname); goto err; } assert(lenp == sizeof(*cell_idx)); @@ -395,7 +393,7 @@ fman_if_init(const struct device_node *dpa_node) if (!get_once) { _errno = fman_get_ip_rev(fman_node); if (_errno) { - FMAN_ERR(-ENXIO, "%s: ip_rev is not available\n", + FMAN_ERR(-ENXIO, "%s: ip_rev is not available", fname); goto err; } @@ -425,7 +423,7 @@ fman_if_init(const struct device_node *dpa_node) char_prop = of_get_property(mac_node, "phy-connection-type", NULL); if (!char_prop) { - printf("memac: unknown MII type assuming 1G\n"); + FMAN_ERR(-EINVAL, "memac: unknown MII type assuming 1G"); /* Right now forcing memac to 1g in case of error*/ __if->__if.mac_type = fman_mac_1g; } else { @@ -440,7 +438,7 @@ fman_if_init(const struct device_node *dpa_node) __if->__if.mac_type = fman_mac_10g; } } else { - FMAN_ERR(-EINVAL, "%s: unknown MAC type\n", mname); + FMAN_ERR(-EINVAL, "%s: unknown MAC type", mname); goto err; } @@ -463,7 +461,7 @@ fman_if_init(const struct device_node *dpa_node) mac_addr = of_get_property(mac_node, "local-mac-address", &lenp); if (!mac_addr) { - FMAN_ERR(-EINVAL, "%s: no local-mac-address\n", + FMAN_ERR(-EINVAL, "%s: no local-mac-address", mname); goto err; } @@ -473,19 +471,19 @@ fman_if_init(const struct device_node *dpa_node) tx_channel_id = of_get_property(tx_node, "fsl,qman-channel-id", &lenp); if (!tx_channel_id) { - FMAN_ERR(-EINVAL, "%s: no fsl-qman-channel-id\n", + FMAN_ERR(-EINVAL, "%s: no fsl-qman-channel-id", tx_node->full_name); goto err; } regs_addr = of_get_address(rx_node, 0, &__if->regs_size, NULL); if (!regs_addr) { - FMAN_ERR(-EINVAL, "of_get_address(%s)\n", mname); + FMAN_ERR(-EINVAL, "of_get_address(%s)", mname); goto err; } phys_addr = of_translate_address(rx_node, regs_addr); if (!phys_addr) { - FMAN_ERR(-EINVAL, "of_translate_address(%s, %p)\n", + FMAN_ERR(-EINVAL, "of_translate_address(%s, %p)", mname, regs_addr); goto err; } @@ -493,7 +491,7 @@ fman_if_init(const struct device_node *dpa_node) PROT_READ | PROT_WRITE, MAP_SHARED, fman_ccsr_map_fd, phys_addr); if (__if->bmi_map == MAP_FAILED) { - FMAN_ERR(-errno, "mmap(0x%"PRIx64")\n", phys_addr); + FMAN_ERR(-errno, "mmap(0x%"PRIx64")", phys_addr); goto err; } @@ -507,7 +505,7 @@ fman_if_init(const struct device_node *dpa_node) */ rx_phandle = of_get_property(dpa_node, rprop, &lenp); if (!rx_phandle) { - FMAN_ERR(-EINVAL, "%s: no fsl,qman-frame-queues-rx\n", dname); + FMAN_ERR(-EINVAL, "%s: no fsl,qman-frame-queues-rx", dname); goto err; } @@ -542,7 +540,7 @@ fman_if_init(const struct device_node *dpa_node) tx_phandle = of_get_property(dpa_node, "fsl,qman-frame-queues-tx", &lenp); if (!tx_phandle) { - FMAN_ERR(-EINVAL, "%s: no fsl,qman-frame-queues-tx\n", dname); + FMAN_ERR(-EINVAL, "%s: no fsl,qman-frame-queues-tx", dname); goto err; } @@ -562,7 +560,7 @@ fman_if_init(const struct device_node *dpa_node) pools_phandle = of_get_property(dpa_node, "fsl,bman-buffer-pools", &lenp); if (!pools_phandle) { - FMAN_ERR(-EINVAL, "%s: no fsl,bman-buffer-pools\n", dname); + FMAN_ERR(-EINVAL, "%s: no fsl,bman-buffer-pools", dname); goto err; } /* For each pool, parse the corresponding node and add a pool object @@ -578,13 +576,13 @@ fman_if_init(const struct device_node *dpa_node) /* Allocate an object for the pool */ bpool = rte_malloc(NULL, sizeof(*bpool), RTE_CACHE_LINE_SIZE); if (!bpool) { - FMAN_ERR(-ENOMEM, "malloc(%zu)\n", sizeof(*bpool)); + FMAN_ERR(-ENOMEM, "malloc(%zu)", sizeof(*bpool)); goto err; } /* Find the pool node */ pool_node = of_find_node_by_phandle(*pools_phandle); if (!pool_node) { - FMAN_ERR(-ENXIO, "%s: bad fsl,bman-buffer-pools\n", + FMAN_ERR(-ENXIO, "%s: bad fsl,bman-buffer-pools", dname); rte_free(bpool); goto err; @@ -593,7 +591,7 @@ fman_if_init(const struct device_node *dpa_node) /* Extract the BPID property */ prop = of_get_property(pool_node, "fsl,bpid", &proplen); if (!prop) { - FMAN_ERR(-EINVAL, "%s: no fsl,bpid\n", pname); + FMAN_ERR(-EINVAL, "%s: no fsl,bpid", pname); rte_free(bpool); goto err; } @@ -691,7 +689,7 @@ fman_init(void) for_each_child_node(parent_node, dpa_node) { _errno = fman_if_init(dpa_node); if (_errno) { - FMAN_ERR(_errno, "if_init(%s)\n", dpa_node->full_name); + FMAN_ERR(_errno, "if_init(%s)", dpa_node->full_name); goto err; } } diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 5d4352bb3c..e483428ddc 100644 --- a/drivers/bus/dpaa/dpaa_bus.c +++ b/drivers/bus/dpaa/dpaa_bus.c @@ -326,7 +326,7 @@ int rte_dpaa_portal_init(void *arg) dpaa_seqn_dynfield_offset = rte_mbuf_dynfield_register(&dpaa_seqn_dynfield_desc); if (dpaa_seqn_dynfield_offset < 0) { - DPAA_BUS_LOG(ERR, "Failed to register mbuf field for dpaa sequence number\n"); + DPAA_BUS_LOG(ERR, "Failed to register mbuf field for dpaa sequence number"); return -rte_errno; } @@ -673,7 +673,7 @@ rte_dpaa_bus_probe(void) if (dev->device_type == FSL_DPAA_ETH) { ret = rte_dpaa_setup_intr(dev->intr_handle); if (ret) - DPAA_BUS_ERR("Error setting up interrupt.\n"); + DPAA_BUS_ERR("Error setting up interrupt."); } } @@ -734,13 +734,13 @@ rte_dpaa_find_device(const struct rte_device *start, rte_dev_cmp_t cmp, while (dev != NULL) { if (cmp(&dev->device, data) == 0) { - DPAA_BUS_DEBUG("Found dev=(%s)\n", dev->device.name); + DPAA_BUS_DEBUG("Found dev=(%s)", dev->device.name); return &dev->device; } dev = TAILQ_NEXT(dev, next); } - DPAA_BUS_DEBUG("Unable to find any device\n"); + DPAA_BUS_DEBUG("Unable to find any device"); return NULL; } @@ -786,14 +786,14 @@ dpaa_bus_dev_iterate(const void *start, const char *str, /* Expectation is that device would be name=device_name */ if (strncmp(str, "name=", 5) != 0) { - DPAA_BUS_DEBUG("Invalid device string (%s)\n", str); + DPAA_BUS_DEBUG("Invalid device string (%s)", str); return NULL; } /* Now that name=device_name format is available, split */ dup = strdup(str); if (dup == NULL) { - DPAA_BUS_DEBUG("Dup string (%s) failed!\n", str); + DPAA_BUS_DEBUG("Dup string (%s) failed!", str); return NULL; } dev_name = dup + strlen("name="); -- 2.25.1