* [PATCH 1/2] app/proc-info: add memory heap dump @ 2024-07-02 13:14 Gagandeep Singh 2024-07-02 13:14 ` [PATCH 2/2] eal: add total memory size in memory dump APIs Gagandeep Singh 2024-07-03 8:33 ` [PATCH 1/2] app/proc-info: add memory heap dump Hemant Agrawal 0 siblings, 2 replies; 3+ messages in thread From: Gagandeep Singh @ 2024-07-02 13:14 UTC (permalink / raw) To: dev, Reshma Pattan; +Cc: hemant.agrawal This patch add the heap dump support in proc-info memory dump option. Signed-off-by: Gagandeep Singh <g.singh@nxp.com> --- app/proc-info/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index b672aaefbe..7137891c14 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -20,6 +20,7 @@ #include <rte_debug.h> #include <rte_ethdev.h> #include <rte_memory.h> +#include <rte_malloc.h> #include <rte_memzone.h> #include <rte_launch.h> #include <rte_tailq.h> @@ -637,6 +638,10 @@ meminfo_display(void) rte_memzone_dump(stdout); printf("---------- END_MEMORY_ZONES -----------\n"); + printf("------------ HEAP DUMP -------------\n"); + rte_malloc_dump_heaps(stdout); + printf("---------- END_HEAP_DUMP -----------\n"); + printf("------------- TAIL_QUEUES -------------\n"); rte_dump_tailq(stdout); printf("---------- END_TAIL_QUEUES ------------\n"); -- 2.25.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] eal: add total memory size in memory dump APIs 2024-07-02 13:14 [PATCH 1/2] app/proc-info: add memory heap dump Gagandeep Singh @ 2024-07-02 13:14 ` Gagandeep Singh 2024-07-03 8:33 ` [PATCH 1/2] app/proc-info: add memory heap dump Hemant Agrawal 1 sibling, 0 replies; 3+ messages in thread From: Gagandeep Singh @ 2024-07-02 13:14 UTC (permalink / raw) To: dev, Anatoly Burakov, Tyler Retzlaff; +Cc: hemant.agrawal This patch add total memory size dump in memzone and memsegments dump APIs. Signed-off-by: Gagandeep Singh <g.singh@nxp.com> --- lib/eal/common/eal_common_memory.c | 2 ++ lib/eal/common/eal_common_memzone.c | 18 ++++++++++++++++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c index 60ddc30580..c6b9c16617 100644 --- a/lib/eal/common/eal_common_memory.c +++ b/lib/eal/common/eal_common_memory.c @@ -531,6 +531,8 @@ void rte_dump_physmem_layout(FILE *f) { rte_memseg_walk(dump_memseg, f); + fprintf(f, "Total Memory Segments size = %uM\n", + (unsigned int) rte_eal_get_physmem_size() / (1024 * 1024)); } static int diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c index 32e6b78f87..1d12ccc443 100644 --- a/lib/eal/common/eal_common_memzone.c +++ b/lib/eal/common/eal_common_memzone.c @@ -58,6 +58,11 @@ rte_memzone_max_get(void) return mcfg->max_memzone; } +struct memzone_info { + FILE *f; + uint64_t t_size; +}; + static inline const struct rte_memzone * memzone_lookup_thread_unsafe(const char *name) { @@ -369,7 +374,8 @@ dump_memzone(const struct rte_memzone *mz, void *arg) struct rte_memseg *ms; int mz_idx, ms_idx; size_t page_sz; - FILE *f = arg; + struct memzone_info *info = arg; + FILE *f = info->f; mz_idx = rte_fbarray_find_idx(&mcfg->memzones, mz); @@ -382,6 +388,7 @@ dump_memzone(const struct rte_memzone *mz, void *arg) mz->socket_id, mz->flags); + info->t_size += mz->len; /* go through each page occupied by this memzone */ msl = rte_mem_virt2memseg_list(mz->addr); if (!msl) { @@ -414,7 +421,14 @@ dump_memzone(const struct rte_memzone *mz, void *arg) void rte_memzone_dump(FILE *f) { - rte_memzone_walk(dump_memzone, f); + struct memzone_info info; + + memset(&info, 0, sizeof(info)); + info.f = f; + + rte_memzone_walk(dump_memzone, &info); + fprintf(f, "Total Memory Zones size = %uM\n", (unsigned int)info.t_size + / (1024 * 1024)); } /* -- 2.25.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] app/proc-info: add memory heap dump 2024-07-02 13:14 [PATCH 1/2] app/proc-info: add memory heap dump Gagandeep Singh 2024-07-02 13:14 ` [PATCH 2/2] eal: add total memory size in memory dump APIs Gagandeep Singh @ 2024-07-03 8:33 ` Hemant Agrawal 1 sibling, 0 replies; 3+ messages in thread From: Hemant Agrawal @ 2024-07-03 8:33 UTC (permalink / raw) To: dev On 02-07-2024 18:44, Gagandeep Singh wrote: > This patch add the heap dump support in proc-info > memory dump option. > > Signed-off-by: Gagandeep Singh <g.singh@nxp.com> > --- > app/proc-info/main.c | 5 +++++ > 1 file changed, 5 insertions(+) Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-03 8:34 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-07-02 13:14 [PATCH 1/2] app/proc-info: add memory heap dump Gagandeep Singh 2024-07-02 13:14 ` [PATCH 2/2] eal: add total memory size in memory dump APIs Gagandeep Singh 2024-07-03 8:33 ` [PATCH 1/2] app/proc-info: add memory heap dump Hemant Agrawal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).