From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 360314554D; Tue, 2 Jul 2024 16:47:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CB7B40E54; Tue, 2 Jul 2024 16:47:00 +0200 (CEST) Received: from smtp-fw-52005.amazon.com (smtp-fw-52005.amazon.com [52.119.213.156]) by mails.dpdk.org (Postfix) with ESMTP id 0B35E40E20; Tue, 2 Jul 2024 16:46:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1719931618; x=1751467618; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=kiXOAV5VeUKDGVTTmUu7SPpIF7ZKKKIRfkF1l8XE0sM=; b=LOUlNdYT/lZWkleVEI0Rp3aT1AXQzS1VpCBU6Tdw0aqrkqyHu+44nqpw CgPR1rFxQ404+CIxFe1Z9acryUKggOhrxlTwKikcmPwxHfO9VRJMpQjpo HEFfQLBNj0xWA544JWkFqVkWOa0wXeCV4K+W+lpMMpg4BPD+CRcfdjmGv U=; X-IronPort-AV: E=Sophos;i="6.09,178,1716249600"; d="scan'208";a="664412435" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO smtpout.prod.us-east-1.prod.farcaster.email.amazon.dev) ([10.43.8.6]) by smtp-border-fw-52005.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2024 14:46:56 +0000 Received: from EX19MTAEUC002.ant.amazon.com [10.0.10.100:3703] by smtpin.naws.eu-west-1.prod.farcaster.email.amazon.dev [10.0.31.218:2525] with esmtp (Farcaster) id efc9188c-30a3-405a-931a-5c2b7d0ba151; Tue, 2 Jul 2024 14:46:54 +0000 (UTC) X-Farcaster-Flow-ID: efc9188c-30a3-405a-931a-5c2b7d0ba151 Received: from EX19D007EUB004.ant.amazon.com (10.252.51.85) by EX19MTAEUC002.ant.amazon.com (10.252.51.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Tue, 2 Jul 2024 14:46:54 +0000 Received: from EX19MTAUWB001.ant.amazon.com (10.250.64.248) by EX19D007EUB004.ant.amazon.com (10.252.51.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Tue, 2 Jul 2024 14:46:54 +0000 Received: from HFA15-CG15235BS.amazon.com (10.85.143.173) by mail-relay.amazon.com (10.250.64.254) with Microsoft SMTP Server id 15.2.1258.34 via Frontend Transport; Tue, 2 Jul 2024 14:46:52 +0000 From: To: CC: , Shai Brandes , Subject: [PATCH 11/15] net/ena: fix bad checksum handling Date: Tue, 2 Jul 2024 17:46:22 +0300 Message-ID: <20240702144626.14545-12-shaibran@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240702144626.14545-1-shaibran@amazon.com> References: <20240702144626.14545-1-shaibran@amazon.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shai Brandes Removed a workaround for a false L4 bad Rx csum indication from the device. The workaround was to set it as unknown so the application would check it instead. The issue was fixed in the device, thus the driver bad csum handling should be fixed in the PMD. Fixes: b2d2f1cf89a6 ("net/ena: fix checksum flag for L4") Cc: stable@dpdk.org Signed-off-by: Shai Brandes --- doc/guides/rel_notes/release_24_07.rst | 1 + drivers/net/ena/ena_ethdev.c | 8 +------- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/doc/guides/rel_notes/release_24_07.rst b/doc/guides/rel_notes/release_24_07.rst index a59fb2a21f..f000dec54b 100644 --- a/doc/guides/rel_notes/release_24_07.rst +++ b/doc/guides/rel_notes/release_24_07.rst @@ -78,6 +78,7 @@ New Features * Reworked the driver logger usage in order to improve Tx performance. * Reworked the device uninitialization flow to ensure complete resource cleanup and lay the groundwork for hot-unplug support. + * Removed an obsolete workaround for a false L4 bad Rx checksum indication. * **Update Tap PMD driver.** diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 4e7171e629..b43b913903 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -674,13 +674,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, } else { if (unlikely(ena_rx_ctx->l4_csum_err)) { ++rx_stats->l4_csum_bad; - /* - * For the L4 Rx checksum offload the HW may indicate - * bad checksum although it's valid. Because of that, - * we're setting the UNKNOWN flag to let the app - * re-verify the checksum. - */ - ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; } else { ++rx_stats->l4_csum_good; ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; -- 2.17.1