* [PATCH] eal: make dev_sigbus static
@ 2024-07-03 15:17 Stephen Hemminger
2024-07-05 14:08 ` David Marchand
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2024-07-03 15:17 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Tyler Retzlaff
Only used in one file, and not an exported symbol should be static.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/eal/common/eal_private.h | 22 ----------------------
lib/eal/linux/eal_dev.c | 4 ++--
2 files changed, 2 insertions(+), 24 deletions(-)
diff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h
index 71523cfdb8..e63ecd74f8 100644
--- a/lib/eal/common/eal_private.h
+++ b/lib/eal/common/eal_private.h
@@ -529,28 +529,6 @@ int local_dev_remove(struct rte_device *dev);
*/
int rte_bus_sigbus_handler(const void *failure_addr);
-/**
- * @internal
- * Register the sigbus handler.
- *
- * @return
- * - On success, zero.
- * - On failure, a negative value.
- */
-int
-dev_sigbus_handler_register(void);
-
-/**
- * @internal
- * Unregister the sigbus handler.
- *
- * @return
- * - On success, zero.
- * - On failure, a negative value.
- */
-int
-dev_sigbus_handler_unregister(void);
-
/**
* Get OS-specific EAL mapping base address.
*/
diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c
index fff4e8fa83..e63f24d108 100644
--- a/lib/eal/linux/eal_dev.c
+++ b/lib/eal/linux/eal_dev.c
@@ -393,7 +393,7 @@ rte_dev_event_monitor_stop(void)
return ret;
}
-int
+static int
dev_sigbus_handler_register(void)
{
sigset_t mask;
@@ -414,7 +414,7 @@ dev_sigbus_handler_register(void)
return rte_errno;
}
-int
+static int
dev_sigbus_handler_unregister(void)
{
rte_errno = 0;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] eal: make dev_sigbus static
2024-07-03 15:17 [PATCH] eal: make dev_sigbus static Stephen Hemminger
@ 2024-07-05 14:08 ` David Marchand
0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2024-07-05 14:08 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Tyler Retzlaff
On Wed, Jul 3, 2024 at 5:17 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Only used in one file, and not an exported symbol should be static.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-05 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-03 15:17 [PATCH] eal: make dev_sigbus static Stephen Hemminger
2024-07-05 14:08 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).