From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E8E345582; Thu, 4 Jul 2024 08:05:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41AD040E72; Thu, 4 Jul 2024 08:05:43 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id AE3AA40280 for ; Thu, 4 Jul 2024 08:05:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720073141; x=1751609141; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=bpve3SbH5liNnD4z9l7Z5U70osL//afWyq+bWqZ/JWo=; b=UC1a22utjMC/awpcPtjOUzQDOLOtQrSNv1Zm+aEOwzfGU2yN+xAFOO8I 3j+4+4D5ukEPdE1trtslR3uh5rFBI7GZiFn8SD8yjESN56hE3g/8tySgi cL9vxCMW1Nz4qr4OirXxGBE0EqwuTqFsBosk17rum4Uup5s5RVeydMhDu e8L3pQVgJe2uE41plSnav8P7BzCeN35S/gWtJzo5xVHpXbhwQeGyNVQk1 y1pGwKCFU0kWEawpjpxckN3nDUsD6cZm+c2e+zZMh2Oh8s9566upWEQjj dipiZ2zYzQwAmeNOv9q6Lsh9hLZiLQwhCCONX69R1o71VcSz5KXDbiGrK A==; X-CSE-ConnectionGUID: KKpb38TTQU6RIwG5+DyKhw== X-CSE-MsgGUID: VcQhboV2S1eElMnxT3HsgA== X-IronPort-AV: E=McAfee;i="6700,10204,11122"; a="17054841" X-IronPort-AV: E=Sophos;i="6.09,183,1716274800"; d="scan'208";a="17054841" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2024 23:05:40 -0700 X-CSE-ConnectionGUID: rKsHIaNvSd6oRz631SQRDQ== X-CSE-MsgGUID: WBM/GGRqQ12068/UWuWNeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,183,1716274800"; d="scan'208";a="46428500" Received: from unknown (HELO npf-hyd-clx-03..) ([10.145.170.182]) by orviesa010.jf.intel.com with ESMTP; 03 Jul 2024 23:05:38 -0700 From: Soumyadeep Hore To: bruce.richardson@intel.com, aman.deep.singh@intel.com Cc: dev@dpdk.org Subject: [PATCH v1] net/cpfl: add checks for received ctlq messages Date: Thu, 4 Jul 2024 05:18:35 +0000 Message-ID: <20240704051835.2630052-1-soumyadeep.hore@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org cpfl_process_rx_ctlq_msg() is used to check error status returned for specific opcodes. Previously error codes were only -ve for cpfl_receive_ctlq_msg() but now there are +ve error codes. Hence code changes are made accordingly. Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_flow_engine_fxp.c | 2 +- drivers/net/cpfl/cpfl_fxp_rule.c | 52 +++++++++++++++++++++++++ 2 files changed, 53 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c b/drivers/net/cpfl/cpfl_flow_engine_fxp.c index 39a281fa61..983b4188e4 100644 --- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c +++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c @@ -95,7 +95,7 @@ cpfl_fxp_create(struct rte_eth_dev *dev, ret = cpfl_rule_process(itf, ad->ctlqp[cpq_id], ad->ctlqp[cpq_id + 1], rim->rules, rim->rule_num, true); - if (ret < 0) { + if (ret) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "cpfl filter create flow fail"); rte_free(rim); diff --git a/drivers/net/cpfl/cpfl_fxp_rule.c b/drivers/net/cpfl/cpfl_fxp_rule.c index 0e710a007b..fc807e59a0 100644 --- a/drivers/net/cpfl/cpfl_fxp_rule.c +++ b/drivers/net/cpfl/cpfl_fxp_rule.c @@ -60,6 +60,52 @@ cpfl_send_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 num_q_msg, return ret; } +static int +cpfl_process_rx_ctlq_msg(u16 msg_opcode, u16 msg_status) +{ + int ret = CPFL_CFG_PKT_ERR_OK; + + if (msg_status && + msg_opcode == cpfl_ctlq_sem_query_rule_hash_addr) + return ret; + + switch (msg_status) { + case CPFL_CFG_PKT_ERR_EEXIST: + PMD_INIT_LOG(ERR, "The rule has confliction with already existed one"); + ret = CPFL_CFG_PKT_ERR_EEXIST; + break; + case CPFL_CFG_PKT_ERR_ENOSPC: + PMD_INIT_LOG(ERR, "No space left in the table"); + ret = CPFL_CFG_PKT_ERR_ENOSPC; + break; + case CPFL_CFG_PKT_ERR_ESRCH: + PMD_INIT_LOG(ERR, "Bad opcode"); + ret = CPFL_CFG_PKT_ERR_ESRCH; + break; + case CPFL_CFG_PKT_ERR_ERANGE: + PMD_INIT_LOG(ERR, "Parameter are out of"); + ret = CPFL_CFG_PKT_ERR_ERANGE; + break; + case CPFL_CFG_PKT_ERR_ESBCOMP: + PMD_INIT_LOG(ERR, "Completion error"); + ret = CPFL_CFG_PKT_ERR_ESBCOMP; + break; + case CPFL_CFG_PKT_ERR_ENOPIN: + PMD_INIT_LOG(ERR, "Entry cannot be pinned in the cache"); + ret = CPFL_CFG_PKT_ERR_ENOPIN; + break; + case CPFL_CFG_PKT_ERR_ENOTFND: + PMD_INIT_LOG(ERR, "Entry does not exists"); + ret = CPFL_CFG_PKT_ERR_ENOTFND; + break; + case CPFL_CFG_PKT_ERR_EMAXCOL: + PMD_INIT_LOG(ERR, "Maximum number of hash collisons reached"); + ret = CPFL_CFG_PKT_ERR_EMAXCOL; + break; + } + return ret; +} + int cpfl_receive_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 num_q_msg, struct idpf_ctlq_msg q_msg[]) @@ -92,6 +138,12 @@ cpfl_receive_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 num_q_m /* TODO - process rx controlq message */ for (i = 0; i < num_q_msg; i++) { + ret = cpfl_process_rx_ctlq_msg(q_msg[i].opcode, q_msg[i].status); + if (ret) { + PMD_INIT_LOG(ERR, "failed to process rx_ctrlq msg"); + return ret; + } + if (q_msg[i].data_len > 0) dma = q_msg[i].ctx.indirect.payload; else -- 2.43.0