From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A578A45584; Thu, 4 Jul 2024 23:41:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A520742F99; Thu, 4 Jul 2024 23:41:14 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id E972442F79 for ; Thu, 4 Jul 2024 23:41:12 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1fb1c918860so13593315ad.1 for ; Thu, 04 Jul 2024 14:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1720129272; x=1720734072; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dVXo7F5hNP0PjLLn/gGNNx5F6fyJJdrG3N1vDBodNxg=; b=A5PiIqLTUsk4T1+et6k7lMJXfPMeha38QzIsV4G73A+/xIsyFAuMk05j7UXdglGxCZ VWPbZ5bZOu4QZMGJB4R/nZnia5eUWc80kFcAJS+NgAm96UwxLSFSKwi4dXIMsrdZJDjw /9l9NxorerPANCas7rbBXVsNY1AYNGxKWX7+50XsCfXefRX3mc2cBZqYI+Cm1GIs/pIN mKUgWRyP8830yqbTunBmbWykQiGe17ol1HzTL2ZeIjseMPD6M8Ysb4uTLlCAjXPXzxmL 6jwjOO82aTZr2tS4syMEF1axSQivUosj3mev/pRY66VOW/676AbjzJHRlWMowlekf9o8 a3Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720129272; x=1720734072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dVXo7F5hNP0PjLLn/gGNNx5F6fyJJdrG3N1vDBodNxg=; b=ZAbydiXkagS00KVjIXAOiWeLXLdKZhrGL6gd72aOIkbaQqMwsB1tUDAZ/kc+UzIHlG t8U685v+7BryrfD+pgA6IWsE+33lzasJB6MoDCBIq8GYd6WhoedTQBzlB3fJE1qFKbEn +uCflp91Lb23lgwkS60Dj0fAzBClkwiPrbDC19oUbzaDPQFthZv5x6g/1qzgNgyi/bHu 57NRfGnprGom0GIdrQeFR6mmHx6Ex6mWuEQI70R1tshe8IsFpO17YLvFoS+dBgZk8lIr rgjlE1XM3NyizT5gUsnboi95fq2K9qXVd2tPe82R60zYwRhIml7fpXaa16fkgq8fYRMp AY0w== X-Forwarded-Encrypted: i=1; AJvYcCWat6fTZ7MXR0ONhtTB7D+rX2Qrs9zB8CqLD0ppd3OFuHzZl8xfX/1bKhF17xMrHrKchTBTiuV+DUeny00= X-Gm-Message-State: AOJu0YwyPZvML8NA7CODVtC5bJ7/lcZX+FVdEiHyiSQMtt/qLjlDfNmU dGdk6l44Njl0WQGExXumJNgqQDztUnF0rcdVnpSFD10zTjHmAFMxo/oKdzagD8s5449xHhK5D0q YSzg= X-Google-Smtp-Source: AGHT+IG975rCznyOB+28qvzC/dcijQb07CRDoekYzY36yvYoarXCC3xFsFanqA33SBd3Ce4m56g6qQ== X-Received: by 2002:a17:902:ec90:b0:1f7:1d71:25aa with SMTP id d9443c01a7336-1fb3701641cmr38514955ad.6.1720129272006; Thu, 04 Jul 2024 14:41:12 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fb357d5f08sm17598605ad.246.2024.07.04.14.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 14:41:11 -0700 (PDT) Date: Thu, 4 Jul 2024 14:28:28 -0700 From: Stephen Hemminger To: Chengwen Feng Cc: , , Subject: Re: [PATCH 1/4] cfgfile: remove dead code Message-ID: <20240704142828.7261f1db@hermes.local> In-Reply-To: <20240220035840.32978-2-fengchengwen@huawei.com> References: <20240220035840.32978-1-fengchengwen@huawei.com> <20240220035840.32978-2-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 20 Feb 2024 03:58:37 +0000 Chengwen Feng wrote: > This memchr() will never return NULL because rte_cfgfile_load() function > will skip lines without useful content. > > Fixes: 74e0d3a17461 ("cfgfile: fix null pointer dereference in parsing") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng LGTM Acked-by: Stephen Hemminger