From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A77F74558D; Fri, 5 Jul 2024 02:14:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 958954027E; Fri, 5 Jul 2024 02:14:38 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 3443F40275 for ; Fri, 5 Jul 2024 02:14:37 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f70c457823so5313235ad.3 for ; Thu, 04 Jul 2024 17:14:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1720138476; x=1720743276; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/stRrRmM5yqQ2fm+jNzWax0N0iSxRgrxsyV7mISe71k=; b=xOu+QGFemuTumiNe/6yhB+kWoX5eXkCxk8NLr1cQ4b7HOyOx5MdELZeHj90IauaN7X rPcNLLtImL5npxDRNEhmJ8hrTGxBb0v/mYbDF46uzBvz5pnkKKd8wvDEvA+RSOea5He4 WfTLFSzEqyVf+NGc6mIS2QQbOJPitws+gdgeugez117q+ja8pS6bJXu1e3xSpnygT+K5 eKckW5uen65EXHYPJf+zhFIphx7L+jsQyoMeqWXTru5qkO5udGqbew7f770WIFwwfEIM e82HyCBwgzBE/ukeEe2wYLQi912YboKDJu99vi5umwTXanjdCd0240z2CIa9E3u7sdVq YTTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720138476; x=1720743276; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/stRrRmM5yqQ2fm+jNzWax0N0iSxRgrxsyV7mISe71k=; b=ox+rJ2awi0YpRD0jnOhpHO/mFr13oJcJqr/Wc7qmegiIc9RDgPKOKzWpqcy7fikabg P/8LcRVSBdBFykvotLm+UAhkOHeHipWy/kqCt5D7aqobxV+PNYOsHQm88eVYYTX4eTNk q8MxYdt1HmklIIq0HBSRhi1PiGUzwrNOs4f1LRWPZIna1/y7OlYjofY+cBL5/8dmXBBf 64yTdnWSKbV7ZWv7r0HTtmI80BiZArhW+WVi49IXb8pVMAFUT6KdDNtL2miS1yJej08o nrRRS+OY5leExTrWaLXY9Kad6OUz0u+mw826gr3U5qq3AN2sAY3xxiF9v0SYEfPK19wR hVeA== X-Forwarded-Encrypted: i=1; AJvYcCVyNghLQnbF1I0iLhWB0agIH6aVFXrRIXVSmVfx7YjYEdC81D9SgYIHIYF5aT6xAwmM4SffuE5a+k1KL/c= X-Gm-Message-State: AOJu0YygSumBCzyhoMox5zY/ZqAEpkynwJsPq3/PWzD6HOxRPv1iAOWr irUwWaY9QvPp7Krel0fSiQypufWZlWHr1Yku6EgjzJNyt+HlqTaI2Buo+UDySLw= X-Google-Smtp-Source: AGHT+IF9cLUWwarYhXC6YS8ZoHQQmXFGauLXx42xyYnWaRJEAZX11ElXtm4imAopjLFyaWVkVQXyGg== X-Received: by 2002:a17:902:db0e:b0:1fa:b7f0:73e3 with SMTP id d9443c01a7336-1fb33e8672amr26963265ad.38.1720138476152; Thu, 04 Jul 2024 17:14:36 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fb01aa9df8sm56195505ad.20.2024.07.04.17.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 17:14:35 -0700 (PDT) Date: Thu, 4 Jul 2024 17:14:33 -0700 From: Stephen Hemminger To: David Marchand Cc: cristian.dumitrescu@intel.com, thomas@monjalon.net, dev@dpdk.org, Chengwen Feng Subject: Re: [PATCH 0/4] cfgfile: enhance error detecting Message-ID: <20240704171433.4c96f9f6@hermes.local> In-Reply-To: References: <20240220035840.32978-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 4 Jul 2024 17:12:56 +0200 David Marchand wrote: > On Tue, Feb 20, 2024 at 5:00=E2=80=AFAM Chengwen Feng wrote: > > > > When I was trying to debug a problem introduced by config.ini in > > test-dma-perf, I found the cfgfile library should enhance error > > detecting, so got this patchset. > > > > Chengwen Feng (4): > > cfgfile: remove dead code > > cfgfile: support verify name and value > > cfgfile: verify add section and entry result > > cfgfile: add unique name flag > > > > lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++---------- > > lib/cfgfile/rte_cfgfile.h | 7 ++++ > > 2 files changed, 59 insertions(+), 18 deletions(-) =20 >=20 > Please review. >=20 >=20 Somewhat related, why is the cfgfile test disabled? The line for test_cfgfile is commented out in app/test/meson.build