From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A50184558D; Fri, 5 Jul 2024 02:29:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 95E244027E; Fri, 5 Jul 2024 02:29:55 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id CFCBB40275 for ; Fri, 5 Jul 2024 02:29:54 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-70b0ebd1ef9so59835b3a.2 for ; Thu, 04 Jul 2024 17:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1720139394; x=1720744194; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KxOvFdOMCCw4+VIZcSvcsb3JYkLDCV+X+cJiPluT83s=; b=fDWu8zInwV3+nnqrKgod6y5bA5hMHYaXUbONLhHgP9a0NQGxVPQadBJ/phQMqMOl4E vu9tmVDR4rc0hkMyQTC67aOzoyF9g9rEZRCG9qBEdJpnFYUdRWZzVLQDA/GhfP6Tb5qZ zmGDaaUqb0RfmBSAcMqqanzt3cDYWODT6OR9STDoz8AjW3KuyiXnr2TTveNgpch54Ja5 xGnGplXs3SEqn6hHqwQHHFSlrCzEzc4ehGFYMI8dEdPt6Jg6kx9SrmWS9PcCDn8ciSnr h/xseQvim8pkBtZ4ux6WDjA5+qYQU/ejjbi11USxLgt04M90Fe2lWA8gK60DRTL1kzE4 FLPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720139394; x=1720744194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KxOvFdOMCCw4+VIZcSvcsb3JYkLDCV+X+cJiPluT83s=; b=g93mDk0QI47kM+xhTsJ7nMg0/LA1yr6gjYyF2HizzW266rr/tkiMIaS+KjnbUMGEsY Bro0p6TOQiTRNL+Kytn7n2cxW7j0UAHjxQ1KOC8KybGvz0vxpgCJ16W30HoCWVV5uuS7 w2RyUWSHD1NKseEzL49jbiyPGSPM8WI00Gw8BdR/j7Duhe24sFvFSEx0HcShO7DYaGx+ +3FCsWn83aznv6rJVYx+mJxNwxNjf2OBl2WS6/qsshsUnamJwhS+KH1VxCVIiLbRm+K9 yZaewMmWcDqyl8jZaml6aPqUiKmgeZuMJPWQSfeY+HYtbGHHkcRPA47VL5rPb86VmQjn Jqhw== X-Forwarded-Encrypted: i=1; AJvYcCVZ2qEeW+MdWsEGeIx3EszNg9KanDgniAqPaU1SNkhjAxKNerphedT28WrpezGIMjvYGenknQuC+EhGUqI= X-Gm-Message-State: AOJu0YyS/hiAlqj8CJMuym2yG6vMiqQ+tK14Ah/hWOj8Dp124argaIFM x6S25n6vHdacHe+r/7wtZchA0DN/n4NeqIDN+/eOjK8S5qsfJD48KjDyOKKNj+U= X-Google-Smtp-Source: AGHT+IEKR61+Wz6EE+Gw/AFs+lDjRLZkfdPHoQYgh9yRxB4zCSCh9iwCei31vRoyytaK+yU+CU3/Lw== X-Received: by 2002:a05:6a00:1408:b0:705:cade:1f40 with SMTP id d2e1a72fcca58-70b00947f4fmr2989817b3a.11.1720139393790; Thu, 04 Jul 2024 17:29:53 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b079dd221sm971613b3a.202.2024.07.04.17.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jul 2024 17:29:53 -0700 (PDT) Date: Thu, 4 Jul 2024 17:29:51 -0700 From: Stephen Hemminger To: David Marchand , Cristian Dumitrescu Cc: cristian.dumitrescu@intel.com, thomas@monjalon.net, dev@dpdk.org, Chengwen Feng Subject: Re: [PATCH 0/4] cfgfile: enhance error detecting Message-ID: <20240704172951.1cb43fd5@hermes.local> In-Reply-To: <20240704171433.4c96f9f6@hermes.local> References: <20240220035840.32978-1-fengchengwen@huawei.com> <20240704171433.4c96f9f6@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 4 Jul 2024 17:14:33 -0700 Stephen Hemminger wrote: > On Thu, 4 Jul 2024 17:12:56 +0200 > David Marchand wrote: >=20 > > On Tue, Feb 20, 2024 at 5:00=E2=80=AFAM Chengwen Feng wrote: =20 > > > > > > When I was trying to debug a problem introduced by config.ini in > > > test-dma-perf, I found the cfgfile library should enhance error > > > detecting, so got this patchset. > > > > > > Chengwen Feng (4): > > > cfgfile: remove dead code > > > cfgfile: support verify name and value > > > cfgfile: verify add section and entry result > > > cfgfile: add unique name flag > > > > > > lib/cfgfile/rte_cfgfile.c | 70 +++++++++++++++++++++++++++++--------= -- > > > lib/cfgfile/rte_cfgfile.h | 7 ++++ > > > 2 files changed, 59 insertions(+), 18 deletions(-) =20 > >=20 > > Please review. > >=20 > > =20 >=20 >=20 > Somewhat related, why is the cfgfile test disabled? > The line for test_cfgfile is commented out in app/test/meson.build The existing test won't build because of broken resource stuff which is also not built. Probably best to yank the whole test and resource stuff out until Christian fixes it.