From: Mingjin Ye <mingjinx.ye@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, alialnu@nvidia.com,
Mingjin Ye <mingjinx.ye@intel.com>,
stable@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Subject: [PATCH v3] buildtools: fix invalid symbols
Date: Fri, 5 Jul 2024 08:25:50 +0000 [thread overview]
Message-ID: <20240705082550.1670765-1-mingjinx.ye@intel.com> (raw)
In-Reply-To: <20240701103315.835249-1-mingjinx.ye@intel.com>
In scenarios where a higher clang compiler is used and ASAN is enabled,
the generated ELF file will additionally insert undefined debug symbols
with the same prefix. This causes duplicate C code to be generated.
This patch fixes this issue by skipping the unspecified symbol type.
Fixes: 6c4bf8f42432 ("buildtools: add Python pmdinfogen")
Cc: stable@dpdk.org
Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
buildtools/pmdinfogen.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py
index 2a44f17bda..9896f107dc 100755
--- a/buildtools/pmdinfogen.py
+++ b/buildtools/pmdinfogen.py
@@ -70,6 +70,9 @@ def find_by_prefix(self, prefix):
prefix = prefix.encode("utf-8") if self._legacy_elftools else prefix
for i in range(self._symtab.num_symbols()):
symbol = self._symtab.get_symbol(i)
+ # Skip unspecified symbol type
+ if symbol.entry.st_info['type'] == "STT_NOTYPE":
+ continue
if symbol.name.startswith(prefix):
yield ELFSymbol(self._image, symbol)
--
2.25.1
next prev parent reply other threads:[~2024-07-05 8:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 10:11 [PATCH] " Mingjin Ye
2024-06-27 10:50 ` Bruce Richardson
2024-06-27 12:39 ` David Marchand
2024-06-27 11:30 ` David Marchand
2024-07-01 10:33 ` [PATCH v2] " Mingjin Ye
2024-07-03 1:30 ` Jiale, SongX
2024-07-03 16:13 ` David Marchand
2024-07-05 8:25 ` Mingjin Ye [this message]
2024-07-05 18:08 ` [PATCH v3] " Ali Alnubani
2024-07-11 9:20 ` Jiale, SongX
2024-07-11 11:39 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705082550.1670765-1-mingjinx.ye@intel.com \
--to=mingjinx.ye@intel.com \
--cc=alialnu@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).