From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id F219845594;
Fri, 5 Jul 2024 11:17:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D4C8743389;
Fri, 5 Jul 2024 11:17:41 +0200 (CEST)
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19])
by mails.dpdk.org (Postfix) with ESMTP id 963E143381;
Fri, 5 Jul 2024 11:17:39 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1720171060; x=1751707060;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=PpHYkSj3bLTBZz0b9BmG85n5SfJXQ3neMWV2rJqtPH0=;
b=R7bjOYUcz6spcKBA0kazVT3ifHMGVGlpJXhwQCG2WSvUJVMu8zFjeZhO
tpLmaOyfPPZ+BiVtk88FIefFsAL0qSlJRgkYT0i73U8KiTLnGf/I+AkdC
f3KsJtY8WYTaJa5hXnvJpm+civAXewunqyMTE8Sh13LafHfOK+qlR0rVT
V/+Js1A1Uc4Gw85eZymXl05Sy76kaqjvIbQezNV5ZAHXkK4AbB2RIS2Xv
iHqKr08ygcomhXzV/csiXW218aFdh/rmr0zzaieYKj7yWBKFt/VA4YR4C
ZJ8TY9vZBMDuzzcmF7BuFOOu9eBknOyP9FaovszZng1gQWK5mj1ZpC69N g==;
X-CSE-ConnectionGUID: TMF2x7iwSJmOcRTlvaLuIQ==
X-CSE-MsgGUID: vVILCYABTr++GhUdY9THLw==
X-IronPort-AV: E=McAfee;i="6700,10204,11123"; a="17179055"
X-IronPort-AV: E=Sophos;i="6.09,184,1716274800"; d="scan'208";a="17179055"
Received: from fmviesa007.fm.intel.com ([10.60.135.147])
by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
05 Jul 2024 02:17:39 -0700
X-CSE-ConnectionGUID: fbDHpRRCQRi51YXBBl/Hqg==
X-CSE-MsgGUID: xlLr7etHQPuNgBjf924oZA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.09,184,1716274800"; d="scan'208";a="46719847"
Received: from unknown (HELO npf-hyd-clx-03..) ([10.145.170.182])
by fmviesa007.fm.intel.com with ESMTP; 05 Jul 2024 02:17:37 -0700
From: Soumyadeep Hore <soumyadeep.hore@intel.com>
To: bruce.richardson@intel.com,
aman.deep.singh@intel.com
Cc: dev@dpdk.org,
stable@dpdk.org
Subject: [PATCH v3 1/2] net/cpfl: fix check for opcodes of received ctlq
messages
Date: Fri, 5 Jul 2024 08:30:31 +0000
Message-ID: <20240705083032.2756071-2-soumyadeep.hore@intel.com>
X-Mailer: git-send-email 2.43.0
In-Reply-To: <20240705083032.2756071-1-soumyadeep.hore@intel.com>
References: <20240705050831.2639342-3-soumyadeep.hore@intel.com>
<20240705083032.2756071-1-soumyadeep.hore@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
cpfl_process_rx_ctlq_msg() is used to check error status
returned for specific opcodes and return error messages
accordingly.
Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying")
Cc: stable@dpdk.org
Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
---
drivers/net/cpfl/cpfl_fxp_rule.c | 52 ++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/drivers/net/cpfl/cpfl_fxp_rule.c b/drivers/net/cpfl/cpfl_fxp_rule.c
index 0e710a007b..4232b192ed 100644
--- a/drivers/net/cpfl/cpfl_fxp_rule.c
+++ b/drivers/net/cpfl/cpfl_fxp_rule.c
@@ -60,6 +60,52 @@ cpfl_send_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 num_q_msg,
return ret;
}
+static int
+cpfl_process_rx_ctlq_msg(u16 msg_opcode, u16 msg_status)
+{
+ int ret = CPFL_CFG_PKT_ERR_OK;
+
+ if (msg_status &&
+ msg_opcode == cpfl_ctlq_sem_query_rule_hash_addr)
+ return ret;
+
+ switch (msg_status) {
+ case CPFL_CFG_PKT_ERR_EEXIST:
+ PMD_INIT_LOG(ERR, "The rule has confliction with already existed one");
+ ret = CPFL_CFG_PKT_ERR_EEXIST;
+ break;
+ case CPFL_CFG_PKT_ERR_ENOSPC:
+ PMD_INIT_LOG(ERR, "No space left in the table");
+ ret = CPFL_CFG_PKT_ERR_ENOSPC;
+ break;
+ case CPFL_CFG_PKT_ERR_ESRCH:
+ PMD_INIT_LOG(ERR, "Bad opcode");
+ ret = CPFL_CFG_PKT_ERR_ESRCH;
+ break;
+ case CPFL_CFG_PKT_ERR_ERANGE:
+ PMD_INIT_LOG(ERR, "Parameter are out of");
+ ret = CPFL_CFG_PKT_ERR_ERANGE;
+ break;
+ case CPFL_CFG_PKT_ERR_ESBCOMP:
+ PMD_INIT_LOG(ERR, "Completion error");
+ ret = CPFL_CFG_PKT_ERR_ESBCOMP;
+ break;
+ case CPFL_CFG_PKT_ERR_ENOPIN:
+ PMD_INIT_LOG(ERR, "Entry cannot be pinned in the cache");
+ ret = CPFL_CFG_PKT_ERR_ENOPIN;
+ break;
+ case CPFL_CFG_PKT_ERR_ENOTFND:
+ PMD_INIT_LOG(ERR, "Entry does not exists");
+ ret = CPFL_CFG_PKT_ERR_ENOTFND;
+ break;
+ case CPFL_CFG_PKT_ERR_EMAXCOL:
+ PMD_INIT_LOG(ERR, "Maximum number of hash collisions reached");
+ ret = CPFL_CFG_PKT_ERR_EMAXCOL;
+ break;
+ }
+ return ret;
+}
+
int
cpfl_receive_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 num_q_msg,
struct idpf_ctlq_msg q_msg[])
@@ -92,6 +138,12 @@ cpfl_receive_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 num_q_m
/* TODO - process rx controlq message */
for (i = 0; i < num_q_msg; i++) {
+ ret = cpfl_process_rx_ctlq_msg(q_msg[i].opcode, q_msg[i].status);
+ if (ret) {
+ PMD_INIT_LOG(ERR, "failed to process rx_ctrlq msg");
+ return ret;
+ }
+
if (q_msg[i].data_len > 0)
dma = q_msg[i].ctx.indirect.payload;
else
--
2.43.0