[PATCH] telemetry: lower log level when legacy is not configured

[PATCH] telemetry: lower log level when legacy is not configured

[Robin Jarry]

When starting any DPDK application, this warning log is displayed:

 TELEMETRY: No legacy callbacks, legacy socket not created

This brings unnecessary attention, lower the log level to DEBUG.

Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
 doc/guides/contributing/unit_test.rst | 1 -
 doc/guides/nics/cnxk.rst              | 1 -
 lib/telemetry/telemetry.c             | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/doc/guides/contributing/unit_test.rst b/doc/guides/contributing/unit_test.rst
index 063cefa192ae..c0f0d2988f00 100644
--- a/doc/guides/contributing/unit_test.rst
+++ b/doc/guides/contributing/unit_test.rst
@@ -98,7 +98,6 @@ The unit test app can accept test suite names via command line arguments::
    EAL: Detected static linkage of DPDK
    EAL: Multi-process socket /run/user/26934/dpdk/rte/mp_socket
    EAL: Selected IOVA mode 'VA'
-   TELEMETRY: No legacy callbacks, legacy socket not created
    APP: HPET is not enabled, using TSC as default timer
    RTE>>version_autotest
    Version string: 'DPDK 21.08.0-rc0'
diff --git a/doc/guides/nics/cnxk.rst b/doc/guides/nics/cnxk.rst
index dcb158385a29..ff380c10e905 100644
--- a/doc/guides/nics/cnxk.rst
+++ b/doc/guides/nics/cnxk.rst
@@ -76,7 +76,6 @@ for details.
       [ 2003.202721] vfio-pci 0002:02:00.0: vfio_cap_init: hiding cap 0x14@0x98
       EAL: Probe PCI driver: net_cn10k (177d:a063) device: 0002:02:00.0 (socket 0)
       PMD: RoC Model: cn10k
-      EAL: No legacy callbacks, legacy socket not created
       testpmd: create a new mbuf pool <mb_pool_0>: n=155456, size=2176, socket=0
       testpmd: preferred mempool ops selected: cn10k_mempool_ops
       Configuring Port 0 (socket 0)
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 509fae76ec6d..c4c5a61a5cf8 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -541,7 +541,7 @@ telemetry_legacy_init(void)
 	int rc;
 
 	if (num_legacy_callbacks == 1) {
-		TMTY_LOG_LINE(WARNING, "No legacy callbacks, legacy socket not created");
+		TMTY_LOG_LINE(DEBUG, "No legacy callbacks, legacy socket not created");
 		return -1;
 	}
 
-- 
2.45.2

Re: [PATCH] telemetry: lower log level when legacy is not configured

[Bruce Richardson]

On Fri, Jul 05, 2024 at 11:00:20AM +0200, Robin Jarry wrote:
> When starting any DPDK application, this warning log is displayed:
> 
>  TELEMETRY: No legacy callbacks, legacy socket not created
> 
> This brings unnecessary attention, lower the log level to DEBUG.
> 
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH] telemetry: lower log level when legacy is not configured

[David Marchand]

On Fri, Jul 5, 2024 at 11:05 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Fri, Jul 05, 2024 at 11:00:20AM +0200, Robin Jarry wrote:
> > When starting any DPDK application, this warning log is displayed:
> >
> >  TELEMETRY: No legacy callbacks, legacy socket not created
> >
> > This brings unnecessary attention, lower the log level to DEBUG.
> >
> > Signed-off-by: Robin Jarry <rjarry@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.


-- 
David Marchand