From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD26E45594; Fri, 5 Jul 2024 11:35:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 974F042F8F; Fri, 5 Jul 2024 11:34:50 +0200 (CEST) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id 652EA42E9F for ; Fri, 5 Jul 2024 11:34:43 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WFpC16jTyz1T4hf; Fri, 5 Jul 2024 17:30:05 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id CE21814011A; Fri, 5 Jul 2024 17:34:41 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 5 Jul 2024 17:34:41 +0800 From: Chengwen Feng To: CC: , , , Subject: [PATCH v2 1/4] cfgfile: remove dead code Date: Fri, 5 Jul 2024 09:31:12 +0000 Message-ID: <20240705093115.4437-2-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240705093115.4437-1-fengchengwen@huawei.com> References: <20240220035840.32978-1-fengchengwen@huawei.com> <20240705093115.4437-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This memchr() will never return NULL because rte_cfgfile_load() function will skip lines without useful content. Fixes: 74e0d3a17461 ("cfgfile: fix null pointer dereference in parsing") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/cfgfile/rte_cfgfile.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/cfgfile/rte_cfgfile.c b/lib/cfgfile/rte_cfgfile.c index 13ba3957bc..6a98e8fb11 100644 --- a/lib/cfgfile/rte_cfgfile.c +++ b/lib/cfgfile/rte_cfgfile.c @@ -223,12 +223,6 @@ rte_cfgfile_load_with_params(const char *filename, int flags, split[0] = buffer; split[1] = memchr(buffer, '=', len); - if (split[1] == NULL) { - CFG_LOG(ERR, - "line %d - no '=' character found", - lineno); - goto error1; - } *split[1] = '\0'; split[1]++; -- 2.17.1