From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1DE945594; Fri, 5 Jul 2024 11:34:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C098342ED0; Fri, 5 Jul 2024 11:34:45 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id E560C42E9F for ; Fri, 5 Jul 2024 11:34:43 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4WFpC16ZxVzdZsj; Fri, 5 Jul 2024 17:30:05 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 0197B180085; Fri, 5 Jul 2024 17:34:42 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 5 Jul 2024 17:34:41 +0800 From: Chengwen Feng To: CC: , , , Subject: [PATCH v2 2/4] cfgfile: support verify name and value Date: Fri, 5 Jul 2024 09:31:13 +0000 Message-ID: <20240705093115.4437-3-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240705093115.4437-1-fengchengwen@huawei.com> References: <20240220035840.32978-1-fengchengwen@huawei.com> <20240705093115.4437-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch supports verify section's name, entry's name and entry's value validity. Cc: stable@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/cfgfile/rte_cfgfile.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/lib/cfgfile/rte_cfgfile.c b/lib/cfgfile/rte_cfgfile.c index 6a98e8fb11..97a399635e 100644 --- a/lib/cfgfile/rte_cfgfile.c +++ b/lib/cfgfile/rte_cfgfile.c @@ -105,6 +105,16 @@ static int _add_entry(struct rte_cfgfile_section *section, const char *entryname, const char *entryvalue) { + int name_len, value_len; + + name_len = strlen(entryname); + value_len = strlen(entryvalue); + if (name_len == 0 || name_len >= CFG_NAME_LEN || value_len >= CFG_VALUE_LEN) { + CFG_LOG(ERR, "invalid entry name %s or value %s in section %s", + entryname, entryvalue, section->name); + return -EINVAL; + } + /* resize entry structure if we don't have room for more entries */ if (section->num_entries == section->allocated_entries) { struct rte_cfgfile_entry *n_entries = realloc( @@ -322,6 +332,7 @@ rte_cfgfile_create(int flags) int rte_cfgfile_add_section(struct rte_cfgfile *cfg, const char *sectionname) { + int len; int i; if (cfg == NULL) @@ -330,6 +341,12 @@ rte_cfgfile_add_section(struct rte_cfgfile *cfg, const char *sectionname) if (sectionname == NULL) return -EINVAL; + len = strlen(sectionname); + if (len == 0 || len >= CFG_NAME_LEN) { + CFG_LOG(ERR, "invalid section name %s", sectionname); + return -EINVAL; + } + /* resize overall struct if we don't have room for more sections */ if (cfg->num_sections == cfg->allocated_sections) { -- 2.17.1