From: Soumyadeep Hore <soumyadeep.hore@intel.com>
To: bruce.richardson@intel.com, aman.deep.singh@intel.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: [PATCH v4 1/2] net/cpfl: fix check for opcodes of received ctlq messages
Date: Fri, 5 Jul 2024 13:05:14 +0000 [thread overview]
Message-ID: <20240705130515.3090598-2-soumyadeep.hore@intel.com> (raw)
In-Reply-To: <20240705130515.3090598-1-soumyadeep.hore@intel.com>
Include checks for error status returned for specific
opcodes and display error messages accordingly.
Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying")
Cc: stable@dpdk.org
Signed-off-by: Soumyadeep Hore <soumyadeep.hore@intel.com>
---
drivers/net/cpfl/cpfl_fxp_rule.c | 8 ++++++++
drivers/net/cpfl/cpfl_rules.h | 11 +++++++++++
2 files changed, 19 insertions(+)
diff --git a/drivers/net/cpfl/cpfl_fxp_rule.c b/drivers/net/cpfl/cpfl_fxp_rule.c
index 0e710a007b..f48ecd5656 100644
--- a/drivers/net/cpfl/cpfl_fxp_rule.c
+++ b/drivers/net/cpfl/cpfl_fxp_rule.c
@@ -92,6 +92,14 @@ cpfl_receive_ctlq_msg(struct idpf_hw *hw, struct idpf_ctlq_info *cq, u16 num_q_m
/* TODO - process rx controlq message */
for (i = 0; i < num_q_msg; i++) {
+ ret = q_msg[i].status;
+ if (ret &&
+ q_msg[i].opcode != cpfl_ctlq_sem_query_del_rule_hash_addr) {
+ PMD_INIT_LOG(ERR, "Failed to process rx_ctrlq msg: %s",
+ cpfl_cfg_pkt_errormsg[ret]);
+ return ret;
+ }
+
if (q_msg[i].data_len > 0)
dma = q_msg[i].ctx.indirect.payload;
else
diff --git a/drivers/net/cpfl/cpfl_rules.h b/drivers/net/cpfl/cpfl_rules.h
index d23eae8e91..10569b1fdc 100644
--- a/drivers/net/cpfl/cpfl_rules.h
+++ b/drivers/net/cpfl/cpfl_rules.h
@@ -62,6 +62,17 @@ enum cpfl_cfg_pkt_error_code {
CPFL_CFG_PKT_ERR_EMAXCOL = 9 /* Max Hash Collision */
};
+static const char * const cpfl_cfg_pkt_errormsg[] = {
+ [CPFL_CFG_PKT_ERR_ESRCH] = "Bad opcode",
+ [CPFL_CFG_PKT_ERR_EEXIST] = "The rule conflicts with already existed one",
+ [CPFL_CFG_PKT_ERR_ENOSPC] = "No space left in the table",
+ [CPFL_CFG_PKT_ERR_ERANGE] = "Parameter out of range",
+ [CPFL_CFG_PKT_ERR_ESBCOMP] = "Completion error",
+ [CPFL_CFG_PKT_ERR_ENOPIN] = "Entry cannot be pinned in cache",
+ [CPFL_CFG_PKT_ERR_ENOTFND] = "Entry does not exist",
+ [CPFL_CFG_PKT_ERR_EMAXCOL] = "Maximum Hash Collisions reached",
+};
+
/* macros for creating context for rule descriptor */
#define MEV_RULE_VSI_ID_S 0
#define MEV_RULE_VSI_ID_M \
--
2.43.0
next prev parent reply other threads:[~2024-07-05 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 5:18 [PATCH v1] net/cpfl: add checks for " Soumyadeep Hore
2024-07-04 12:49 ` Bruce Richardson
2024-07-05 5:08 ` [PATCH v2 0/2] Avoid rule duplication in CPFL PMD Soumyadeep Hore
2024-07-05 5:08 ` [PATCH v2 1/2] net/cpfl: fix check for opcodes of received ctlq messages Soumyadeep Hore
2024-07-05 5:08 ` [PATCH v2 2/2] net/cpfl: fix +ve error codes for " Soumyadeep Hore
2024-07-05 8:30 ` [PATCH v3 0/2] Avoid rule duplication in CPFL PMD Soumyadeep Hore
2024-07-05 8:30 ` [PATCH v3 1/2] net/cpfl: fix check for opcodes of received ctlq messages Soumyadeep Hore
2024-07-05 9:49 ` Bruce Richardson
2024-07-05 8:30 ` [PATCH v3 2/2] net/cpfl: fix +ve error codes for " Soumyadeep Hore
2024-07-05 13:05 ` [PATCH v4 0/2] Avoid rule duplication in CPFL PMD Soumyadeep Hore
2024-07-05 13:05 ` Soumyadeep Hore [this message]
2024-07-05 14:21 ` [PATCH v4 1/2] net/cpfl: fix check for opcodes of received ctlq messages Bruce Richardson
2024-07-05 13:05 ` [PATCH v4 2/2] net/cpfl: fix +ve error codes for " Soumyadeep Hore
2024-07-05 14:47 ` [PATCH v4 0/2] Avoid rule duplication in CPFL PMD Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240705130515.3090598-2-soumyadeep.hore@intel.com \
--to=soumyadeep.hore@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).