From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5126B45599; Fri, 5 Jul 2024 15:52:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87F2E42EFE; Fri, 5 Jul 2024 15:52:47 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mails.dpdk.org (Postfix) with ESMTP id 3FBEE410D5; Fri, 5 Jul 2024 15:52:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720187565; x=1751723565; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=negwjGooRRkmYY1a80QJa3x004narmcunbOojwrejZE=; b=E/bA1LBUucBxzrHVZopFG3EiIAX0wUwudc0uF0klZwPAfa0XlX8fPSe4 K+BQNeBX2pJHfM6FmUO2kjAarRPU/iFhVOv6Qz41Tkv8RRwxDAKuuXsKm i12PuvuvQ+12/PAUmWZ09e6r9KF7rYoIF6i3gRnnO4rlgjiYPjOa39doU Jy6/XZ7+xf2OB7KPmz+vboCwpyS4TPDYnqPfh+SCIyOk7xjMRmfxXVQ+y +y2Y9wiglJSYK0v2jsrGyWNRACHZAco+PlA29/g6Ehmhoe11bubLkX1FG 4tzb+8Q5++Yf/f9+9acBhVxEws/r2tC4p1QCpy3QgP0BDmcFgYkrf83KY g==; X-CSE-ConnectionGUID: dO4vDEXqRKy786CsVRdftA== X-CSE-MsgGUID: Y69jcnNYRkWCNLzck/1xXw== X-IronPort-AV: E=McAfee;i="6700,10204,11123"; a="28636692" X-IronPort-AV: E=Sophos;i="6.09,184,1716274800"; d="scan'208";a="28636692" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2024 06:52:42 -0700 X-CSE-ConnectionGUID: yZxLdFMpR5KZnkaMZQlsLw== X-CSE-MsgGUID: AvsvO1ueQmyFZ/AhH/0l7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,184,1716274800"; d="scan'208";a="46884320" Received: from unknown (HELO npf-hyd-clx-03..) ([10.145.170.182]) by fmviesa009.fm.intel.com with ESMTP; 05 Jul 2024 06:52:40 -0700 From: Soumyadeep Hore To: bruce.richardson@intel.com, aman.deep.singh@intel.com Cc: dev@dpdk.org, stable@dpdk.org Subject: [PATCH v4 2/2] net/cpfl: fix +ve error codes for received ctlq messages Date: Fri, 5 Jul 2024 13:05:15 +0000 Message-ID: <20240705130515.3090598-3-soumyadeep.hore@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240705130515.3090598-1-soumyadeep.hore@intel.com> References: <20240705083032.2756071-3-soumyadeep.hore@intel.com> <20240705130515.3090598-1-soumyadeep.hore@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Previously error codes were only -ve for cpfl_receive_ctlq_msg() but now there are +ve error codes. Hence code changes are made accordingly. Fixes: db042ef09d26 ("net/cpfl: implement FXP rule creation and destroying") Cc: stable@dpdk.org Signed-off-by: Soumyadeep Hore --- drivers/net/cpfl/cpfl_flow_engine_fxp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c b/drivers/net/cpfl/cpfl_flow_engine_fxp.c index 39a281fa61..b9e825ef57 100644 --- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c +++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c @@ -95,7 +95,7 @@ cpfl_fxp_create(struct rte_eth_dev *dev, ret = cpfl_rule_process(itf, ad->ctlqp[cpq_id], ad->ctlqp[cpq_id + 1], rim->rules, rim->rule_num, true); - if (ret < 0) { + if (ret != 0) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "cpfl filter create flow fail"); rte_free(rim); -- 2.43.0