From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0702455B6; Sun, 7 Jul 2024 12:26:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E054840B9A; Sun, 7 Jul 2024 12:26:07 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2057.outbound.protection.outlook.com [40.107.223.57]) by mails.dpdk.org (Postfix) with ESMTP id D6FA640A76; Sun, 7 Jul 2024 12:26:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ua0PtMXANvRU/5w8/fmDK6riHfMn+bpHrlz3V2mQI73iL2baBsYeBcWFs6WI8Pe3KZwKChWaGxCfX6soJ6U5+84Se4x6qr4dRVvzyZa9xj8KCHfhRfouk79gEAnKJwkkqtiFOSKuDr8XfeMWUcubTxUJDIAzcspvGYqROfVS/VSnzO7gpLxv143r0fEBHA/r8zA1qaKSyVoESqUpy6XdmPA4sDvhTFejamtUOyH1ybJBfCtAnUwG+YBktcJNtr49CRbdTjgm6CwRNOSFEM1oGgc3d/dc0RnH0wKEFgQzDUFGQqTTt8I2zs3f2wzU+OE96fWDg7YxlrMJMOQEwjfHrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DTI1rpiSfVQeT9hxOukXF+R4Sdvk3wayOd4+BDnriZI=; b=dEtzUaXYXyi0EymAxG6p1XJaTG8+tZ4MeXMafPaZMckpHna5x5THs2dw1w3ehaKyOQjBuFO0lrETk8aZdxfx0GU6um56GOh+0vlwYet5TPKw2KJGJ1zNUB5pkeQ1Yql+j6A24rC78cqanY2k5DPPy/Idbx6Zbmgu8ISeUroVUSnaWRRXX/UhJtq8S5WKbWTeHAxi6nN4PEw7MqPw4au1JeSfLt422gkUFmV94WklDvy8oIH09qkx7s+6SfG62IcUm4l9wh4hIRq2q7S8d72ZOcaW/Cmury/m4TeDQAwqYNreTl8V+OSlUsqWOtCUhTzZiTAnm8oa8lTQJEjWo9+QNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DTI1rpiSfVQeT9hxOukXF+R4Sdvk3wayOd4+BDnriZI=; b=tw2i28/rooA32Jq0Iln5m0mz1UPMa2nYgjPIgEACFwc1pSo27XwJGM5xZ9V0qp9szLgFWs6zvYq2E9VfkhMQlvXj+J30GyDIYr7Xip0K/dZrIHRzYLWM9ecnjdSwdeAgxiLOw0jLHU1lJTPSLise9Uibg8/fiKgoVRvq/0Qv1LSPuOyeOIiUPT0bZ4qhb8b7qCHJFb9HrAWmEC61k9qr3T2jct8uBOcX6/+obmjLOz1nV33zyRrrmB6CrkljBarZWtJU6XjcJDXKKfYN57S+I2Z0PEnXiCPXFXljc5GiuHGxUsNFOsBlEhm5u0p6CvkhMv0dW9ou8B9Ju2WHcLb02A== Received: from PH8PR07CA0041.namprd07.prod.outlook.com (2603:10b6:510:2cf::29) by LV2PR12MB5943.namprd12.prod.outlook.com (2603:10b6:408:170::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.34; Sun, 7 Jul 2024 10:26:02 +0000 Received: from SN1PEPF0002BA4C.namprd03.prod.outlook.com (2603:10b6:510:2cf:cafe::c2) by PH8PR07CA0041.outlook.office365.com (2603:10b6:510:2cf::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.34 via Frontend Transport; Sun, 7 Jul 2024 10:26:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SN1PEPF0002BA4C.mail.protection.outlook.com (10.167.242.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Sun, 7 Jul 2024 10:26:01 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 7 Jul 2024 03:25:59 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 7 Jul 2024 03:25:58 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Sun, 7 Jul 2024 03:25:55 -0700 From: Itamar Gozlan To: , , , , , , , , Dariusz Sosnowski , Bing Zhao , Ori Kam , Matan Azrad CC: , Subject: [PATCH 05/10] net/mlx5/hws: strictly range templates check fix Date: Sun, 7 Jul 2024 13:25:26 +0300 Message-ID: <20240707102532.2045942-5-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240707102532.2045942-1-igozlan@nvidia.com> References: <20240707102532.2045942-1-igozlan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4C:EE_|LV2PR12MB5943:EE_ X-MS-Office365-Filtering-Correlation-Id: e0f9abe8-5b62-4ade-aa6e-08dc9e6f32fd X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JD+arQ54pZeBQt/v4Q6LLWQHkdfoq4yD5VTYvOxHxZkXNfogMA6qFnuZVnCE?= =?us-ascii?Q?L1+UQhQbFeVd4YqQHL1EkkMSdGhhSKuHlVSR1/5Onge0F8uVweb1rzWq1WfW?= =?us-ascii?Q?u0ZAPdV8VSHG7ObvEAQk0Per4sdyMsLTZlrZzOvSIa/ntCM77UlzeN6OJa/x?= =?us-ascii?Q?9dOi8XwNLIDf4ywSvwC3vhyc4iQlrJIDcwSvW6bNJqY4Mb5nLx1rF+02m2+g?= =?us-ascii?Q?VZlijKc+UqclBmmLwunLoxbrN7oKAyJnT1hx0KRINdTeWYneT4rB9pQl5WFH?= =?us-ascii?Q?GU3RnvhI2s+NuNgZvgkSpo2VhPH1Ek2bkIyWOAIIt4wSNRlcV/pqbSogFjhp?= =?us-ascii?Q?f874Gv0Xfuox45o5nR1iBRb+3YE6udq4P1vzG+uUEGMCSuiM6HD8yil4NWtp?= =?us-ascii?Q?nMHNo46hwhsCchbrkbtcgKYtWEbiAvcRCLg9hB+aPX5ZCayLZyLx5WDN4oy/?= =?us-ascii?Q?Ek5kX/q4/fplw64b0+rRegZIrNRQzrMKKheEUEOdcrLFueJFe8cAv5ElU0k2?= =?us-ascii?Q?FI7l3Rp3z1jaHnFM+4B4DJSkTHm3a8W+Mui688AXsey88xVAWtEbmptDm2xh?= =?us-ascii?Q?Qfx2iF7lSdrU3AIcy4fEc+UxACzLDuLuLxQ683GAbeBFtbs2SO/m0wFPKEZM?= =?us-ascii?Q?zrLCQEvjGsUUvS2FCd+eDpmudkK8qJHB8S4zUnjrlFp4Q09DpmDvxqhFsBfk?= =?us-ascii?Q?l2UjqYjJw1T+YXVv7SGaRjwosvwvl7RFkqgZRcgVRAw43dTXnBka7MRS7yrs?= =?us-ascii?Q?NDOd6GWBOFCTvWYdzkxkBzyi+VSyDdBwZSO2d3XLht5Tc01WdJiYP0qfKlVS?= =?us-ascii?Q?5997olp2+CC6SB6k2lIZ1lQLEj25DrOKkEN/Y0o8vRLlJpUzFqznXYyqR9LJ?= =?us-ascii?Q?DzbLPkn+YgPdfMOVzTHAuz3XR7GMPTY3IHnbx7aeDHPsqDpSpkehRI/GxJ07?= =?us-ascii?Q?HAsSNu6P88YTaGIdGwenlOTkOHHNvgHnMxkamdrYzxhZFcc0QgqzHmlI42Qh?= =?us-ascii?Q?6wtJLdF6cTFF4jfEGG2C0RYD1HiPGRG4n99lBW7zJWn9OvRdMhf2OO3fnCsK?= =?us-ascii?Q?qOZhJ2vyo34klMX9RU+fZSnJ1HOp8jKgFux/QzTal4O4dO3FCWf3854TgLDq?= =?us-ascii?Q?XMm5S58yHHDh4R1Dp+qbFGvf8jUxsw9uel+UQaEo1871LOIJa4g2U0JnwNLL?= =?us-ascii?Q?EZTKV76wQx6BjMitDBSXu5x3RiM+SihbUAP4GtcdpSzwo4Wcn3QsRIAvp7+A?= =?us-ascii?Q?xq6cyZqxqQaUHKh7kv6ceN40ql1N8uC5v2fZFSsGy7x3wQlcGn+6yquEVSty?= =?us-ascii?Q?MJhVhl1JSUEV4YUyBDEmxsnJCUFFVGaBr30fl1aZEZZ9Vm5GhUbQduUGHc9/?= =?us-ascii?Q?4hH7lSF5SKgijNKmLM0O8K3p3iuMy8Rp3HZ2XSeB1N3kvFICr0Uxau7Sm+pB?= =?us-ascii?Q?EFe8Ekc+6mSbNrOs6xDj/oxWns5t6XkIjgUC+soRTtmI8TTD7AAc2Q=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2024 10:26:01.2561 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0f9abe8-5b62-4ade-aa6e-08dc9e6f32fd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4C.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5943 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Using range and non range templates is not allowed, and in HWS there is a check that enforce that limitation with constantly check that, in a loop, if the current template defined as range, the last one should also be defined as range. But, in the case where there are two templates in the following order: (1) template with range, and (2) template without range. The existing checks will not cover this case. This commit fixes that hole by maintain the invariant that if a template without a range exist, all the previous match template are also. Fixes: 9732ffe13bd6 ("net/mlx5/hws: add range definer creation") Cc: valex@nvidia.com Cc: stable@dpdk.org Signed-off-by: Itamar Gozlan Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_definer.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 9ebda9267d..51a3f7be4b 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -4041,15 +4041,18 @@ mlx5dr_definer_matcher_range_init(struct mlx5dr_context *ctx, /* Create optional range definers */ for (i = 0; i < matcher->num_of_mt; i++) { - if (!mt[i].fcr_sz) - continue; - /* All must use range if requested */ - if (i && !mt[i - 1].range_definer) { + bool is_range = !!mt[i].fcr_sz; + bool has_range = matcher->flags & MLX5DR_MATCHER_FLAGS_RANGE_DEFINER; + + if (i && ((is_range && !has_range) || (!is_range && has_range))) { DR_LOG(ERR, "Using range and non range templates is not allowed"); goto free_definers; } + if (!mt[i].fcr_sz) + continue; + matcher->flags |= MLX5DR_MATCHER_FLAGS_RANGE_DEFINER; /* Create definer without fcr binding, already binded */ mt[i].range_definer = mlx5dr_definer_alloc(ctx, -- 2.39.3