From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 594BE455B6; Sun, 7 Jul 2024 12:26:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94F9040E42; Sun, 7 Jul 2024 12:26:11 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2083.outbound.protection.outlook.com [40.107.243.83]) by mails.dpdk.org (Postfix) with ESMTP id AF15040673; Sun, 7 Jul 2024 12:26:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LrjGgUkXeBsj0nY2d6JHpmWsXreLsqr7bIDMSRU5TCKE9kGVzKuISoHoq+7BylhAr3JUm979v6l0Ma8l3VPOArdDtUs7FnD0IpATAq5VatSb1MzGayU75es/3zRk0yDQT84JxZSjOCA7QyRqZbV7yge8wFqVjsSS6OuGwYU80E++LYuRNh879bSjv81oXubozmFwt/z3uODvu6G9zcWBhov/wZFawb2cLBI7lKIac9DyhP90JhlaWuXRBOGNH3IY5OH+OZVWC9VUORFz2w44cTkurktgHXrGhNifCRXB1LlAD+esuf9QxXzjuIJYCyqHovO3dSZ0RX/tisVhvxadVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dwxrYioBUkCKgYAbwE+NRB1M1s97xu84WR6YAID/Bvw=; b=JJV33QOfrRzaCAdJsVauNcBzoNCNt/ZnFOQk+azWaKsR5wQDUOVUHci26+ORcblsIha+v0KGmeoUjgDz4IDGuqP1XYrhasFexV7Naj5sH384aPqF8iRYpwdB2xnlx4f4gHBlv8OESAc2S1OEzCqYQEj2gB/B9eMW2NlNctDoXLO3Ad3X3aF/loWg+5Cdjkgp7GKidKw/TGKEyCbe4NqlWFC+hh4gQ1w/AwdH4xdP1YWQoc+j/jtXRTAESXjswESC/xYQb88H+JxUtDY1zYfzGLuV51w8O5iMA3UxZsxoV1/2am13jSAYXDCm2EAQL5tdCF/qom0SfaXeT1ewICQAuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dwxrYioBUkCKgYAbwE+NRB1M1s97xu84WR6YAID/Bvw=; b=jC6Xw9trlN/zKqmPNcYPLroa5Dpd5fMFMsxz++0K3a9LQSokO34hBi83FnP4wiXSefnkTow7A3erGRzXjSvMMfzjgBBkj7ucgDaBP7LyttHsj0OT8h50ATa4UYCcoPkon3sWhoTu9Dbwvd86tdi0oE1meUIFjTOfAxHKdtTLaXKAsIIh6BhKD6A8W3UuLsomeaFy5xVg2fjpao42DO+k4a8D1Zfzon1mTS9Lw006v69mrztqoO1uEFiPQhLK/7XJnJpYj9CLznyXA/c3hqKaHBDX6JJx18Tpc1YJmo7P1saMB9vfXIGWsby5FuwqjlUFbAybKa5WBSwUwB14eZerIg== Received: from BL1PR13CA0184.namprd13.prod.outlook.com (2603:10b6:208:2be::9) by DS7PR12MB6358.namprd12.prod.outlook.com (2603:10b6:8:95::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.34; Sun, 7 Jul 2024 10:26:07 +0000 Received: from BL6PEPF0001AB53.namprd02.prod.outlook.com (2603:10b6:208:2be:cafe::1) by BL1PR13CA0184.outlook.office365.com (2603:10b6:208:2be::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Sun, 7 Jul 2024 10:26:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by BL6PEPF0001AB53.mail.protection.outlook.com (10.167.241.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.17 via Frontend Transport; Sun, 7 Jul 2024 10:26:06 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 7 Jul 2024 03:26:03 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 7 Jul 2024 03:26:03 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Sun, 7 Jul 2024 03:25:59 -0700 From: Itamar Gozlan To: , , , , , , , , Dariusz Sosnowski , Bing Zhao , Ori Kam , Matan Azrad CC: , Subject: [PATCH 06/10] net/mlx5/hws: fix deletion of action vport Date: Sun, 7 Jul 2024 13:25:27 +0300 Message-ID: <20240707102532.2045942-6-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240707102532.2045942-1-igozlan@nvidia.com> References: <20240707102532.2045942-1-igozlan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB53:EE_|DS7PR12MB6358:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b1b30e9-32f1-4643-eeef-08dc9e6f366d X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kv53Fw9cF5YEk7arAJ41Yss9cueTLH34tYOq2o+35o+Juqds1h8xkdm/v0UZ?= =?us-ascii?Q?3COgTuZKJhkNZoifNfUCH853ET86c42fAXKscrk0ReOMiONlT+PWJ7MyBQxy?= =?us-ascii?Q?BarOqTOjtgcq/FXu15YToP4i9fF+RE+tZ2lBB5llrvBpkn9IKlV8ospab2+f?= =?us-ascii?Q?d1dF0YBx7C9y7a+B/8Oy7g81XLGl4kzmeOmOiqdyX7CDNWqNCnQVKuzj/5MH?= =?us-ascii?Q?k727n6kq3xL7fIH150D0PC9nezuZCY+Tlpo62inrU1u6CbtOQr1UcB4smwwF?= =?us-ascii?Q?nBrE9ewpmMpkryio1zODo/cbS3/UyUJMnCS0URLYVkf7KSDfngxiFJEDMAE1?= =?us-ascii?Q?2IMfpD3iW5mOlRkRimaI2oLnHOEB6JGSlTQtgk6r71WDJSu2rSFye1qf6Lj4?= =?us-ascii?Q?dxynpMdZ4yp84NgUhXKcUwNuie8jUDP4caNWCCMAzGPiPdR+Y6LS9qO9rqkw?= =?us-ascii?Q?HLY90BcTw41rM2zirtcGZNcgX6EcfRlEju08QtSK73TsPWFFRapwyqxeFQ4N?= =?us-ascii?Q?DRfaDtp8QX0B7Axs1Vz43reiZNGIHY/YJ9SAdee//c9AvwtUx6KxYYzlDVm1?= =?us-ascii?Q?zdzpgnXrC++SX4+GL4S3iuD+LEj7S8DparfdweH2GdJrwVqmNdWhALJhUb7d?= =?us-ascii?Q?o0rmKvyHqdrAm0vbBloPX2fXLCUvD34DNKikIJlTnpmAQ+eDbxwZ2f6P6TLs?= =?us-ascii?Q?UUyIzdA7xQ/h2AZmCfOosRNgElqxjXT22KoymrztCoVU0f4+xwLdi0RCIm4y?= =?us-ascii?Q?nl9PkBQb/PJ7e6ntgFmqOywRLM6ces8SyNSCOeHny5dwVSaDRcZpUdvxVtLZ?= =?us-ascii?Q?IFVdaZ53EM2krAJQgF4SIqezlNlGb7uz8jVtZAUXvWPZoPwXJGDblmsd2s8u?= =?us-ascii?Q?JJyYhWE1f3a5AEhKjZy37RSb7yj4BQKS3rfPzeJh7gt6u526/lw8QbKUPN0L?= =?us-ascii?Q?hHxNbSQS1/4KpVKE5yPytlwCSCI0vvtVxWElUYAScq3Py4pAarO2Zlc+SsL5?= =?us-ascii?Q?CxnYGI2zPM/PFyjZygz4loi3WK1CDOkM11QQIRmxJeg5NeFtmJb7qyCRhvhG?= =?us-ascii?Q?oNsrN7Ultmw3HHUNqVF9j0Qnr5CEO4dqYSdVOwx3DXr+ob6U7TBIq99VxoLy?= =?us-ascii?Q?0tlz07yAm+T4mmYTQwwRqRcMgbW62sUxQZdLNIkgah9MQSXBFs+sTwMjxQly?= =?us-ascii?Q?Ayzomzzqgl3Qh5bRhhPEzf/BZqUplhp76viZrlDWC4ChIbMsM2LwaXWRKwq+?= =?us-ascii?Q?g5TAq1hPq/MGH5o0O9CJlMknIOdyd/pDJ+d779p8jK+yBiOiSiiXbgu4qmSS?= =?us-ascii?Q?mFfbwjhbvpGg1Tuj/2GQ4aHhie0If9c/2wsVdBFhyR+iC7yC94DIeTxXhs1W?= =?us-ascii?Q?wll03t8/+Htt9bOQCy5d9n7VtxERN8Ahw7KEg1hM3thG3xtb8d3KlKIdYyjR?= =?us-ascii?Q?WqD0JfBBkkAHU4Zp5dWb2zWHWuFrLnYrajTiAe2L2CEooIzdt6ksIA=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2024 10:26:06.9625 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1b30e9-32f1-4643-eeef-08dc9e6f366d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB53.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6358 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Erez Shitrit No more ignoring this action while destroying it. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") Cc: erezsh@nvidia.com Cc: stable@dpdk.org Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.c | 4 ++++ drivers/net/mlx5/hws/mlx5dr_cmd.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index b90f18df8a..0d90280a7d 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -2968,6 +2968,7 @@ static void mlx5dr_action_destroy_hws(struct mlx5dr_action *action) case MLX5DR_ACTION_TYP_ASO_CT: case MLX5DR_ACTION_TYP_PUSH_VLAN: case MLX5DR_ACTION_TYP_REMOVE_HEADER: + case MLX5DR_ACTION_TYP_VPORT: mlx5dr_action_destroy_stcs(action); break; case MLX5DR_ACTION_TYP_DEST_ROOT: @@ -3027,6 +3028,9 @@ static void mlx5dr_action_destroy_hws(struct mlx5dr_action *action) break; case MLX5DR_ACTION_TYP_LAST: break; + default: + DR_LOG(ERR, "Not supported action type: %d", action->type); + assert(false); } } diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index 72fc9e3d91..a4f778a8a4 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -1033,7 +1033,8 @@ int mlx5dr_cmd_generate_wqe(struct ibv_context *ctx, ret = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out)); if (ret) { - DR_LOG(ERR, "Failed to write GTA WQE using FW"); + DR_LOG(ERR, "Failed to write GTA WQE using FW (syndrome: %#x)", + mlx5dr_cmd_get_syndrome(out)); rte_errno = errno; return rte_errno; } -- 2.39.3