From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90537455C3; Mon, 8 Jul 2024 07:37:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBDCB40DD3; Mon, 8 Jul 2024 07:37:49 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2138.outbound.protection.outlook.com [40.107.93.138]) by mails.dpdk.org (Postfix) with ESMTP id 9D553402C5; Mon, 8 Jul 2024 07:37:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uav+bAm+04uERLHtGU1DikdiHlBvUsQIRSrL4AkApAPauR1SBA13/3MfUk4iqx3woXw2Zprh/S4DeWsV/fsj1M6QBQPbd6TNeUMKXjhE54ZMsuWknabL5U5Emb8+XTJx0lGJajVn0J1BKAx4xFVqk5LIFb0HrBe7Ohrww3sHumVglfT7xud7MlQRD9O3IBrytaz1Cuxp5d7A9NgDOgV/3cokqaGKY5djxDuicGMcreowzO3qvGr2A3MzjXleHDpxKywj7HuFCWt/rg8ce10npgizmxuGyfq6zEfe+82eVqZtHFUKoIXXiHZJW+ZKlGgfkgzh6cUI4lPR8/oItzYk5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VfCkVXq2toujvZn0/UPfd4JwS03JyMbfwZ+8YUg1HrI=; b=VXi8XPf1aHmbwf6KnA5y1VEUOJ9LP7WoXGS2KKiURWIfFJBmxzoJwsrO/PoiLzQ0iiqYzvsJSXgVsgkNS0R61OrUaTSSW/MhXU1CkdmF9wOyliLG0ZYRDsMCNHbrk7EuYnB3px8RgTIxgCKqXFd8au56ZZkJjfadyY6UKAIwaEt81oy4YSziflzzdmHNdtfkp7+X9xxa4PEoLJIlH7RUj04Z0rVIN5GXlQdvO5iL5H1mu1ivq9IAZY19ICTn46F9LG2ttckGTeKjdsUGN3t4B1T4B6ZKC+dyeeR3PRnnWt+65xAt5kj8Cfh4xeU8cnOPbrLfpfKtDINIVYhbvUiMAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VfCkVXq2toujvZn0/UPfd4JwS03JyMbfwZ+8YUg1HrI=; b=nvOXGv/wYAr/JWAK9TdO0r7b0bo1Z+qMKGg1b0yVkja+xOlGu3xV+43IYEbRP5WsTpq/aWYCPneT9Mo53pZZzqIF5TpkhUpGsjOm995Ha+ihZdWQq7Z9qlUioxMtqSLY54LUj+CNakh50rVk71vawJ/b4R6jokHXGJYhu5lQ97k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB4842.namprd13.prod.outlook.com (2603:10b6:510:78::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Mon, 8 Jul 2024 05:37:43 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::b900:5f05:766f:833%4]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 05:37:43 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , chaoyong.he@corigine.com, stable@dpdk.org, Peng Zhang Subject: [PATCH] net/nfp: fix offload drop flow rule failed Date: Mon, 8 Jul 2024 13:37:24 +0800 Message-Id: <20240708053724.82369-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SJ0PR03CA0032.namprd03.prod.outlook.com (2603:10b6:a03:33e::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB4842:EE_ X-MS-Office365-Filtering-Correlation-Id: cfa0bd97-793e-44e5-db49-08dc9f1016d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|52116014|1800799024|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LyrXOIhwIjzrA6kyNDLwHkEThUjz9BP0Av4a/qmC0QeNULsDufW+ilac0fYC?= =?us-ascii?Q?d+CWVBkBp4DpvyZmuHPyjMDxB9pP4o1itA+Us35oBhD0tsdysm9Oydt2nG8s?= =?us-ascii?Q?iSyWs4mr47YG9FfpEx2V4+EZIHdLVx++NraOnEvtl/8TighF/kSsPsy6KZ+o?= =?us-ascii?Q?SwWtKpACdkrAUtHcNGPVwnTQS496YDmMKOG9v0HXgzbvNuSuigeu0kxkegZi?= =?us-ascii?Q?4ZMoRfSeSdAX6RCVAuEh/oiygekfw84NZAsc2r8BnrNMic+2/TH9eP0ncbHd?= =?us-ascii?Q?tQthwwmzKHlqnU5pZwq87MLUSGhPjE7lQ4qil4JkpK2fhPFFSuvLhIndtTtn?= =?us-ascii?Q?vKk91m//8m1XkYnhJRBnC5rVFOWTO6HTo8/ijgrFwE0IjLO7hYjJ2rnAjVV4?= =?us-ascii?Q?btr7oWn07kPyvf9U++AHv26uOKFNkp25Up8Lteuw3CMdCjUnAr5DW0CmXFFH?= =?us-ascii?Q?8dltGndVrjJj2aW5htReUkMiCmRZxdPgnpC4U5tZZlTuaqwtV4jdHyYpJM4k?= =?us-ascii?Q?DUwv0XAWk3b1Hg49It6DWv/n6wo+vEC1/mHqhPVzGDRzVbkFz6KxUTL0FqN8?= =?us-ascii?Q?QQJFEzCAUYuRF8GQLBXOK7niPt6bTE0L+zWTaNj+bmgfPlxHvx9vYqRnc09b?= =?us-ascii?Q?KNj9q+C43KduUw3Sc/QrXYOw/b9hKmbpeLUX6iNErNR0I3bjDzv9n9MmaHeY?= =?us-ascii?Q?h+nUI2CCKc+1zM+9nE0lW+cHMQs3Pd1fdkVxZ4ETArkTawtC6ilcbQNp/sWc?= =?us-ascii?Q?o2aCP3uI28qymXyP3qhhJRyWmUBw/fit3dqH7jRfAI1HXvVXg2Br6Ae4XQht?= =?us-ascii?Q?bPbwF6ikD3qYFfuD67FBmy/IGvF43dgx0ZTX2v+e5Yh/j5sxrQwMpaw15mW3?= =?us-ascii?Q?sE8Gy8eld021umdnwye1Z+LcRmm8zspX7WUpWjt/chKTPHsh00PrBCnQqCcX?= =?us-ascii?Q?uzRJ5dLsyXLB6y/g5u+eg/I5eU7psF0ZRaDtSEEYMoIqTr61xWmMLprh+pR7?= =?us-ascii?Q?h1/CHWoapOWO9FFj71eHFL8tXvJWES6JD38n0Cn4pC+KUwTUuIWtdaJQJgiw?= =?us-ascii?Q?cDQHakotM4pXClDIMJuu6kpU3ErFBy3BglGOQCi6rRltADAYDErkfoGmNWsl?= =?us-ascii?Q?8OUmpYgGADhUPVvHlTmvtQYZQyoI90dYxxURGfz36w9adtuA0faNcZUiDeVp?= =?us-ascii?Q?YZoD9GzMNcxfbpPqXSEsE2kGNFje+T41o4KPjBO5pK9XMcmo76l2B5ohA5k/?= =?us-ascii?Q?RJQt85mp+uzVNSmLKUSgLkYS4HvzAf9jVnaJwk98xS9nflFMWkn3dFwx+riq?= =?us-ascii?Q?ogjZ7atmBnpU/hwxVZpIasHbUgZn+jO+w+zFvV2k3Cd3StMqjqno8N6ySqwm?= =?us-ascii?Q?B8674/uAtOZVxVM11yXjINpzVyNmFokDdiSBE06Nq956vaxeZA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(52116014)(1800799024)(376014)(38350700014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V5uInuno95SDyO+wpCJq8aF4sirQTVkJPgJQ2BBXb+HnAzSRSfESAmxy65sw?= =?us-ascii?Q?UUh4rWIoi5vN+4ddWshgwOogPNoEHMVmryyQJn9PDH9BusV/Rifm7k7SKkFI?= =?us-ascii?Q?pGTUD2FFmAYDYIRnIydloOW+ialA9t2o1AGDG5LFFv7ZWb2Jax73hdyED3J5?= =?us-ascii?Q?dXpRJEH77yR4ZUln6qCiU9K19rcbWCKn6b8QpqbtRqTq9PW5CtF1nga0E84b?= =?us-ascii?Q?TVTvlJIqgcTZ+3o2MGfiocFtRhF73PpCe7Lyg6P+GCWPYUnit7PxuDAYVrgh?= =?us-ascii?Q?KXCF+5jrJOmTIghZ2ZocuWTZ4qYj1MQ7BjIbLV3XuqqtNCLs3GPKRxfywW92?= =?us-ascii?Q?FSWm5YOLTe3msYXzJkTvk9q++wyQ2X1L5Q4T4RWCXZJGF0B1oG5czzWHduG3?= =?us-ascii?Q?aG7z8bUN2lqzy8nWXcm4UOtuH2u34UV+inlvC9rQUFXzBddQVMjRNLiop5n6?= =?us-ascii?Q?zxUefT6aXJSae8sWSyleZH7LyTHd5SgOArbbt7cVsVdYne+uNKi5PktARm0i?= =?us-ascii?Q?Dd1SFPVkn16+UwQQb8uzuwUwgq71b1rYN2SdmYTAJhzFITCj6/xMoJyo28gL?= =?us-ascii?Q?etOFgaWImsBBfXrAuUtmVcDH6vZZyMtH23EPy2zsEEwcG0X2HgD1NmzvGvvF?= =?us-ascii?Q?9cDpM1l2z7ZTE4kWU9pp/HIF6UX59oOzAPNQWyw3JdR34xbBggkqiomDJQnx?= =?us-ascii?Q?a3aH1gQMzBIgNskPt8UmjTRVn+/TFk0J3D24wCt8aE52cLqn+W+xldj7Nd1t?= =?us-ascii?Q?pFr+3nFvHB7J+q/r3Bhvk+VToEnDO+pc2wC5Jbo459vLNz7K6ilybHVbl0uL?= =?us-ascii?Q?7AhBL5kFTDwFDMMdDNtfWdnYkTU2BvZqDzmKnTqidIMjZEDaKum4Dp+Opqpr?= =?us-ascii?Q?gECbVC1cGWLkE3IdWFKnjxVHSV7jV1uvkZqQTN0IhZKJ9dsaz//QO4jsNwxo?= =?us-ascii?Q?XSgdZxCV/C2VXx6488AV7xhUGZH5Z/zAe5JetWNwozbU1jejTOtLK6Zck8mg?= =?us-ascii?Q?QS04L1NFjf7ppzEFPWy3XTR8QrVWlxbdUS1gQzDDhzBu9zjjo6gytq7AXGdJ?= =?us-ascii?Q?kmI1UlkzmKekG0d75MR0NzVYRfbuZ+KlOA/d+dJMv2VQzILeyT88QwUlCHTv?= =?us-ascii?Q?4vqAVGPkdLg1ydD2L/yiYPNySB4RECyGKZuRoQt7ImU+bHBxRw2L6Z1uAlNm?= =?us-ascii?Q?BQyfrT2GgV5/i00hPi7xL99hY4B72jSpWDSwjAAfigjgQVvy4jsJs1ymvxZj?= =?us-ascii?Q?kBL6iuGHREOQTMuku980R4GJdZO+Fr5kogmxHBxbA0Ixe5qxDsGtq7X26BIG?= =?us-ascii?Q?Zbl1p4JSKmkWi2CSJ5TDSdVUSfeRDu+zP/9815DQogHdSxjrboU4oR2s3V0J?= =?us-ascii?Q?qeM7gEtR/1htGprdmdkorOpNl+abBuUL80yzpP2rQRRNrODhZZjYCxODiC2n?= =?us-ascii?Q?LS9WCeYCSQUAYsAdNMW2nrI++5IGR2NeHO6xDpS9XxptxUnXaUON6yItQYOf?= =?us-ascii?Q?bNsjIbH1Wsj5m+Ux7Vivv1zeOE9haTotJcLmidxYDtIhl8CS4X0jObY5CLxV?= =?us-ascii?Q?KCIPheiupqxUkl7TYMxie4Sw0gifC5FNbGnqCvAeoIJ2s3zyG8eWkj7/RCOq?= =?us-ascii?Q?YA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfa0bd97-793e-44e5-db49-08dc9f1016d3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 05:37:43.3922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BN8mayg6uaEpoUlzGM/Z6hvDMfHoFQQXkrUcp/wLkKi0e2hmGZxs78F5LK4z38Ti4LJgFxxH1DKa0LNAQGEfzxV5bex7S4bgQ8Itqqg1vCM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4842 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu The issue is caused by an invalid exit logic in flow compile function. Fixes: 4839d4b4e180 ("net/nfp: forbid offload flow rules with empty action list") Cc: chaoyong.he@corigine.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower_flow.c b/drivers/net/nfp/flower/nfp_flower_flow.c index 24e7047407..df84eedae4 100644 --- a/drivers/net/nfp/flower/nfp_flower_flow.c +++ b/drivers/net/nfp/flower/nfp_flower_flow.c @@ -4757,7 +4757,7 @@ nfp_flow_compile_action(struct nfp_flower_representor *representor, total_actions++; } - if (total_actions == 0 || param.position == param.action_data) { + if (nfp_flow->install_flag && total_actions == 0) { PMD_DRV_LOG(ERR, "The action list is empty"); return -ENOTSUP; } -- 2.39.1