DPDK patches and discussions
 help / color / mirror / Atom feed
From: "BillXiang" <xiangwencheng@dayudpu.com>
To: "Maxime Coquelin" <maxime.coquelin@redhat.com>,
	 "Chenbo Xia" <chenbox@nvidia.com>,
	 "Jianfeng Tan" <jianfeng.tan@intel.com>,
	 "Tomasz Kulasek" <tomaszx.kulasek@intel.com>,
	 "Pawel Wodkowski" <pawelx.wodkowski@intel.com>
Cc: <dev@dpdk.org>, "BillXiang" <xiangwencheng@dayudpu.com>
Subject: [PATCH] vhost: fix offset while mmaping log base address
Date: Mon,  8 Jul 2024 14:57:49 +0800	[thread overview]
Message-ID: <20240708065749.1131-1-xiangwencheng@dayudpu.com> (raw)

From: BillXiang <xiangwencheng@dayudpu.com>

For sanity the offset should be the last parameter of mmap.

Fixes: fbc4d24 ("vhost: fix offset while mmaping log base address")
Signed-off-by: BillXiang <xiangwencheng@dayudpu.com>
---
 lib/vhost/vhost_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 5f470da38a..0893ae80bb 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -2399,7 +2399,7 @@ vhost_user_set_log_base(struct virtio_net **pdev,
 	 * mmap from 0 to workaround a hugepage mmap bug: mmap will
 	 * fail when offset is not page size aligned.
 	 */
-	addr = mmap(0, size + off, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
+	addr = mmap(0, size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, off);
 	alignment = get_blk_size(fd);
 	close(fd);
 	if (addr == MAP_FAILED) {
-- 
2.30.0

             reply	other threads:[~2024-07-08 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08  6:57 BillXiang [this message]
2024-07-09 12:42 ` Chenbo Xia
2024-07-10  3:22 ` BillXiang
2024-09-19 12:03 ` Maxime Coquelin
2024-09-19 12:04 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708065749.1131-1-xiangwencheng@dayudpu.com \
    --to=xiangwencheng@dayudpu.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=pawelx.wodkowski@intel.com \
    --cc=tomaszx.kulasek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).