From: Stephen Hemminger <stephen@networkplumber.org>
To: Shani Peretz <shperetz@nvidia.com>
Cc: <dev@dpdk.org>, <mkashani@nvidia.com>, <jblunck@infradead.org>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Thomas Monjalon <thomas@monjalon.net>,
Chenbo Xia <chenbox@nvidia.com>,
Nipun Gupta <nipun.gupta@amd.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v2] eal/common: fix inconsistent representation of PCI numbers
Date: Mon, 8 Jul 2024 09:40:21 -0700 [thread overview]
Message-ID: <20240708094021.2b7a1736@hermes.local> (raw)
In-Reply-To: <20240708102513.1287823-1-shperetz@nvidia.com>
On Mon, 8 Jul 2024 13:25:13 +0300
Shani Peretz <shperetz@nvidia.com> wrote:
> +/**
> + * General device name comparison. Will compare by using the specific bus
> + * compare function or by comparing the names directly.
> + *
> + * @param dev
> + * Device handle.
> + * @param name
> + * Name to compare against.
> + * @return
> + * 0 if the device matches the name. Nonzero otherwise.
> + */
> +__rte_experimental
> +int
> +
Since this is only used internally now, maybe better to make it
internal rather than experimental. If it is a public API, then you would
need to also write some function tests as well.
prev parent reply other threads:[~2024-07-08 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 10:25 Shani Peretz
2024-07-08 16:40 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708094021.2b7a1736@hermes.local \
--to=stephen@networkplumber.org \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=jblunck@infradead.org \
--cc=mkashani@nvidia.com \
--cc=nipun.gupta@amd.com \
--cc=roretzla@linux.microsoft.com \
--cc=shperetz@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).