From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ED6F455C7; Mon, 8 Jul 2024 18:40:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90B8840F16; Mon, 8 Jul 2024 18:40:26 +0200 (CEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 5904C40265 for ; Mon, 8 Jul 2024 18:40:25 +0200 (CEST) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-70b04cb28acso2719953b3a.0 for ; Mon, 08 Jul 2024 09:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1720456824; x=1721061624; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TkIzPDU4e2KGicwaXycYcyn9y3tNLA6GH9fGSjwCfxQ=; b=0HSsNdVT0j2dyee4CoEPHYI+8VM+VCKC/jQdGInRcn6WG1TF7rbvcT9AEunF1gjh10 /ah7CxQTdAes1f2Jy/3w/jdI9eV0THPfjBtja6xP5DPwazMcBHIk8upX3v6DNGNIDSSp V2gmdkOdR1I4ls80vESpnf6AkFkOJUvj1YM5WCbcC2KwLW+c/c+LUE1N0btVTNGZKDdy LXzfz+rU1cqE9r2Qod7J9CIqM7FzuzTDHgJmhJZb5cORGeMSrpT5o0k3qy0FsIaoWDOw ojIHnlVMGBTDiyQUQwlfgWKIJ+Vu6wqgreDHmYO8pXJrmRRHuJ5RaAl+C76BNeO9lH0i YWKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720456824; x=1721061624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TkIzPDU4e2KGicwaXycYcyn9y3tNLA6GH9fGSjwCfxQ=; b=wzjz6vDJEcKWzDE81g0aJ7EMBk105pfDlp172vR2tfC1hT3ARhdM5ubedbqqSQ/Kzu cFM8CO7qG3EQMToZ1J/+TZ2HcbhVW9ai21Vkpw48JrStIxybYCZTUCFmfziktCQZbs1R f6/QWe/W5ZizQMADI/j3OWiFhSIdZDiyHCM6bOZSswSo+hpxElLW7K43K1eA9nhX1Fah PPCm3fcL1PECSz1fY4BXTRYRWmVSYAcy3j+yyVZRXhUbh0L+c4rMhE/2HeNIuECJodsh DEhIcJxMa7wTLAHUuGlIDGtQldbzFZcxheqLGXesQG9Pi65pH3lK8IC0liwxvIt9v1Od 1LlQ== X-Gm-Message-State: AOJu0YzGG9nWeM1zLcUhVmF3fWtyCPq9Wb/yn+F7KUl1F7CgY5WuemoD Bzb8hEU3deg+hvRHSo7nQ2Itv1sFo5bapMOHQtvEwcaJJvZtaQYVU5xnumBgpYI= X-Google-Smtp-Source: AGHT+IGHlpPTGAbd+fzeOg6PYOm+qrAps6eRlUSzEWg873qXwZ2Z7l+Wv5N9T0UFIzJ/88TJhCaiIA== X-Received: by 2002:a05:6a00:170d:b0:704:151d:dcce with SMTP id d2e1a72fcca58-70b01ae2b99mr16913360b3a.5.1720456824373; Mon, 08 Jul 2024 09:40:24 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-77d60117b61sm84541a12.22.2024.07.08.09.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 09:40:24 -0700 (PDT) Date: Mon, 8 Jul 2024 09:40:21 -0700 From: Stephen Hemminger To: Shani Peretz Cc: , , , Dariusz Sosnowski , Thomas Monjalon , Chenbo Xia , Nipun Gupta , Tyler Retzlaff Subject: Re: [PATCH v2] eal/common: fix inconsistent representation of PCI numbers Message-ID: <20240708094021.2b7a1736@hermes.local> In-Reply-To: <20240708102513.1287823-1-shperetz@nvidia.com> References: <20240708102513.1287823-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 8 Jul 2024 13:25:13 +0300 Shani Peretz wrote: > +/** > + * General device name comparison. Will compare by using the specific bus > + * compare function or by comparing the names directly. > + * > + * @param dev > + * Device handle. > + * @param name > + * Name to compare against. > + * @return > + * 0 if the device matches the name. Nonzero otherwise. > + */ > +__rte_experimental > +int > + Since this is only used internally now, maybe better to make it internal rather than experimental. If it is a public API, then you would need to also write some function tests as well.