From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9567A455CB; Tue, 9 Jul 2024 05:07:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B63F427D2; Tue, 9 Jul 2024 05:07:23 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id BC955402B8 for ; Tue, 9 Jul 2024 05:07:21 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1fb3cf78fa6so25708545ad.1 for ; Mon, 08 Jul 2024 20:07:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1720494441; x=1721099241; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hk4Ya64VnG2ntnfvlF1IdHgXPQEV97ZmX2zL87XijRs=; b=xlgLAXtzvIRtAUEz0aAoe3hAq/75p8IzTp1Ix5APE0wmYhZ7yJiAJP13fLBi452IRq MS5HcVFuxf2Hb1hFsYpoGaPcnsidZ8kG5DP9aI1OcBEpM+kolEgm4pDD7h1KZbGv36qA /Wt994MIWL0kUUl1i+vxAtABT0z0VDzV89NfWa2qxSoQ4+Ezd3hRzdfHcWPP1P8Htxmd ZOBZFhZM5CYxwePKP0/xaFACXq7OtDm0+0Or54hDxXdb5eL+3i1LaE5zFLivH32p9w7P nm5fuXds4vTsGFfGvwZVpC//AWwpgQh44F9NKrQA6szDr2d7TA45/tuzT1PVh2FlnlnB HoiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720494441; x=1721099241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hk4Ya64VnG2ntnfvlF1IdHgXPQEV97ZmX2zL87XijRs=; b=IyB39GU5FpnpZT+Y+xO/kh+KKgYzV/F3hdypotRdU5m1PxRvTMyyyM5uIpMB8tJeVS Alb5Z6R6kWh+g5M11GsvN4xnzOzSI+AGR7s2CMDSIOWOMnCxcvgGj0Z+nC1+6wXiDI9D x9f6TJmGrh3ds8NamI3fI8JrgQH2v2HjxPdiJ6+IUxBMhU4bv9a3hxHHED4yZM6hxyu2 V9APx2eyeG03CU9tOR9wQnmXglEFqv1UV1t2KuS7cDk4trAccnBSdll+PTm+7TKCBQ2+ tvYwfkUbX1xUJE6Xp7q2M2gC6S3enHoHf56+S5gHBYECn+C6Q2Z3yYDeiwDxe411yjIk XpUg== X-Gm-Message-State: AOJu0YxC20euT3ceqb/odEBfEBIhGkqTJSWeh+wvBcu2WAqhgkQ66lMf CK/H1TBBZmYh75M1rztXpWsXEs3apg4QNJ1cqhxDvztQ7nLDfCP4j1/rw6AP8vw= X-Google-Smtp-Source: AGHT+IHQOwBQez+BG2yauxdD70OHTBsffzd/EYWVVXKV6tPC/b44rtLPqw6cbDRgaGye6Nqgo0+sAQ== X-Received: by 2002:a17:903:11d1:b0:1fb:8a0e:7731 with SMTP id d9443c01a7336-1fbb6d6622fmr12232775ad.38.1720494440714; Mon, 08 Jul 2024 20:07:20 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fbb6ab7dd0sm5508065ad.155.2024.07.08.20.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 20:07:20 -0700 (PDT) Date: Mon, 8 Jul 2024 20:07:18 -0700 From: Stephen Hemminger To: Huisong Li Cc: , , , , , , , , Subject: Re: [PATCH v6 2/2] examples/l3fwd-power: add PM QoS configuration Message-ID: <20240708200718.4a85ac3f@hermes.local> In-Reply-To: <20240709022927.26625-3-lihuisong@huawei.com> References: <20240320105529.5626-1-lihuisong@huawei.com> <20240709022927.26625-1-lihuisong@huawei.com> <20240709022927.26625-3-lihuisong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 9 Jul 2024 10:29:27 +0800 Huisong Li wrote: > + RTE_LCORE_FOREACH(lcore_id) { > + if (rte_lcore_is_enabled(lcore_id) == 0) > + continue; > Why do you need this check? RTE_LCORE_FOREACH calls rte_next_lcore which already skips lcores that are not enabled.