From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5100455E3; Tue, 9 Jul 2024 14:32:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6080042D9F; Tue, 9 Jul 2024 14:32:08 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2077.outbound.protection.outlook.com [40.107.95.77]) by mails.dpdk.org (Postfix) with ESMTP id 96764427D9; Tue, 9 Jul 2024 14:32:06 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PN0frAswZoaKteZnNfso1fxakYGCWO0rwiR9XtpLlE01CyVkBGtWBM08OlyZI0oBwgE8aqp6pAQuCEn2R1JAqIB2oJqw0kv8etfcWNWi3I/VhuLtomLwWEfh84OoNQaqUBIhxDKgr+M+TDgG62g66z5vub9zwlgFJYNkQk/vBxND3m66OEFIfFK80FCBVXhq7DkcjFaoMokW6x6aFHJNl4g1fJmlnKiiIuchkstuC8K7uuew+OHFdODjSjZXyZk4TETBhClmrvhwPIIFD4vvxIQ/200voraEfmhA43zkqiooEaBH4iEvIXlxuqYp2kZeBQLJa0UCy3MTsuzWmFlMHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dwxrYioBUkCKgYAbwE+NRB1M1s97xu84WR6YAID/Bvw=; b=dhY4bNx8uHonJylPDFHT12nQV+E9Sr4NPFWjY2CMwvxAjqcrqa11Rkiu3bCs4LbXIh+CH0OF8xPZiTTC4+wC/tsjv+Ph+tdQxfskMeWFj6m2zNDNdqLGAvAVQUIgT2w8r7WXsqxVDztBIHu6Cd0pui+FKzkBAIW3dhdOE60xnh29JTfc5UNiqlWLWFg36KZfMEl3SJobcLXGUAni3EkzJU1f330SIH3DANzRMhn4q3duMhkuK0AHIZgo5XaQXRDUwSz3eOiGoDzzrxuznTwV7XjKoLD1xDR+qSiC+eauvQhmmfPhNwe+ZqLgKjrgyvr+S0QESqEiR66eoxJUPSYA1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dwxrYioBUkCKgYAbwE+NRB1M1s97xu84WR6YAID/Bvw=; b=Nld5gOKksqE/tjqihZN9bwoMmCU70zUrg4q8yzYQPgXsItUeRHLBAfwb1msSVVyXI6Qcq0sINdF7x7GCD5fZpqs21lZigwP4+H4Zdz1Jur0Y3Agu76abuFH9+u+gzjyuu5WibICgJkDfAudxY9nDvuf6XdzV695dJwn4vBrzc5pi64mGRoNNeoxzTwFTykSrna6kyDvWfo0wSC9qFwsfl0YItGssWKspQ3/90raNWssG+mYJkdUOc+i9MpnQpP3+jCs1s4IjOd4PN40Qdk1yHafJ/c4t0eg0wxEWCJAeECuKNTdgkt4xDTQ56Orc3Y4Cb7gC+TTd6oO1bV33dnkMFA== Received: from BL1P221CA0013.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:2c5::11) by IA1PR12MB6090.namprd12.prod.outlook.com (2603:10b6:208:3ee::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.36; Tue, 9 Jul 2024 12:32:03 +0000 Received: from BN2PEPF000055DE.namprd21.prod.outlook.com (2603:10b6:208:2c5:cafe::17) by BL1P221CA0013.outlook.office365.com (2603:10b6:208:2c5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.36 via Frontend Transport; Tue, 9 Jul 2024 12:32:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN2PEPF000055DE.mail.protection.outlook.com (10.167.245.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.1 via Frontend Transport; Tue, 9 Jul 2024 12:32:02 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 9 Jul 2024 05:31:30 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Tue, 9 Jul 2024 05:31:29 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Tue, 9 Jul 2024 05:31:25 -0700 From: Itamar Gozlan To: , , , , , , , , Dariusz Sosnowski , Bing Zhao , Ori Kam , Matan Azrad CC: , Subject: [PATCH 4/8] net/mlx5/hws: fix deletion of action vport Date: Tue, 9 Jul 2024 15:30:59 +0300 Message-ID: <20240709123103.2101902-5-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240709123103.2101902-1-igozlan@nvidia.com> References: <20240707102532.2045942-10-igozlan@nvidia.com> <20240709123103.2101902-1-igozlan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055DE:EE_|IA1PR12MB6090:EE_ X-MS-Office365-Filtering-Correlation-Id: 55b1dc88-423e-47c1-d637-08dca01322ce X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|921020; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?yoZO3iBZ4bJmZc1Qx3Rfqq3LAAEYK1zF+xuNhHJbPllyVQEzB53aftRM3dgY?= =?us-ascii?Q?MDlzeBQvg07v2XT24cuE3GLeAY2SWJ3xfRRNThp+DVJXlEaviD4iW1t+GoqO?= =?us-ascii?Q?utotul+wXsQ4va7rTUGwhS9tNC6YeeV2+0OPqtVFvpLUR802ycyFis1KApEU?= =?us-ascii?Q?TYB/9EwKvC0Y//ENTtkx/zFEon9ZnTpmCoukPuXbpGTZyvATqMIN802d92IL?= =?us-ascii?Q?I5WzNWPbnAcmT+w5O+idVTgUFSWy58wzykBrJ44Ib0m5hK1Eq1MXwBmgVx2w?= =?us-ascii?Q?iut+9j7VHqZlHs2rp6SN1ve/jsV0o1whm7WIIEbKFt5cadVZjVM8s0xiJGgL?= =?us-ascii?Q?MaGZOIqIxBo/CGOrMaRiSDcFJHCaVI/H5o4GwbNtbCfK4WJB+bzcnsT1EjLt?= =?us-ascii?Q?fdt6VEVmlVZZHqXJC6TaxuX/9x2luLDoMuRp5dm61F0cUt7jdhOJdU7Ljyvf?= =?us-ascii?Q?w3iu4LyqCUsZ8OGpwvwyWBMjoztu7qYEv6Po7AEEKELisBQHnVmcx1ui3e5Q?= =?us-ascii?Q?LV83FzdihJ/vyrmV2qRomZO/xyq9aQNxEwTE8SEJOc4K3MmxBVAyD4dMpzKL?= =?us-ascii?Q?J7UfNY0Cusbi0+QPfv/s7rXaS+bjLR8keuyi/1D3BBEzCWIGoChW023aq0E3?= =?us-ascii?Q?WsOvsXjxv25UkSJO2CRqBMrIqkEcqC4MTwQxXsfADqolCIe3LqT9Jn85kCpo?= =?us-ascii?Q?Je3o373QZv0bc3zsRNf3yBp63dOyvLE/YpjeEMDePPerxFnlo4z1ZC2b4uHE?= =?us-ascii?Q?RFrIG5GWdNRXCUMF3sYVjPqd6hwftNSesRkiAGexw/dMBgzEE71CjWyLmfJR?= =?us-ascii?Q?rZvmtUTyvpGfoqrKV6g6Tv00yHlGSxrYObSCJIn7oOBiKRdmgzqQtP/G+nfJ?= =?us-ascii?Q?zxtBLLVjZ/nlsvhq1vR5ykVl0E0zdr1VYuOaaGDtZfG0OmHuv/iyd3cJRxUH?= =?us-ascii?Q?fPReDqjNlMCyawI7BnEo92kGRyvIXOi3Vm9Qm/UFTXJEpSqtXuS6fuQe2NX4?= =?us-ascii?Q?ihn0mFWL5ZjJdSKuY+bItIl2fuvtP07PMZvPkjOkYrMsbUVlz49RJwwC3ovV?= =?us-ascii?Q?liTHr11O47eiX2CtAJQJhTp/uFB25aBIFImF2khg4kX5CoX70IkVLhyODYH0?= =?us-ascii?Q?oTflDMypKmqrrIo/AIOTRBmMxWJ1HwAhDtghyJIJ3zVFZuD/K/igPTTJHtoS?= =?us-ascii?Q?X0Y7TNwqyjBhehZ/NqpEBKhRN6MyqlBzkLfPzhXhp2+DHSW8wqVfRpa3QAnt?= =?us-ascii?Q?EELtpYLrAl7Y1suLMMTCaU8iQ8DqvrTTQjCM8DkMvxiGLJIslcS884uHKEEL?= =?us-ascii?Q?pF9LB2Kn5BOYB/APcPgPN58Si26+88cjeeob2ZhkL3TjriiiQlkQnJU025Zi?= =?us-ascii?Q?RkUcB+ovtV7YzDvevvFhDXOHYXkWGaFGnbcXOuKn0/jGENqDO2txt8o3lj82?= =?us-ascii?Q?fVu5Z0QBpA6TAppE9n/S4erz5K0/24Gn3knW5zBOSlkuh4tFC0TJbQ=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(921020); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jul 2024 12:32:02.6539 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55b1dc88-423e-47c1-d637-08dca01322ce X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055DE.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6090 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Erez Shitrit No more ignoring this action while destroying it. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") Cc: erezsh@nvidia.com Cc: stable@dpdk.org Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.c | 4 ++++ drivers/net/mlx5/hws/mlx5dr_cmd.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index b90f18df8a..0d90280a7d 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -2968,6 +2968,7 @@ static void mlx5dr_action_destroy_hws(struct mlx5dr_action *action) case MLX5DR_ACTION_TYP_ASO_CT: case MLX5DR_ACTION_TYP_PUSH_VLAN: case MLX5DR_ACTION_TYP_REMOVE_HEADER: + case MLX5DR_ACTION_TYP_VPORT: mlx5dr_action_destroy_stcs(action); break; case MLX5DR_ACTION_TYP_DEST_ROOT: @@ -3027,6 +3028,9 @@ static void mlx5dr_action_destroy_hws(struct mlx5dr_action *action) break; case MLX5DR_ACTION_TYP_LAST: break; + default: + DR_LOG(ERR, "Not supported action type: %d", action->type); + assert(false); } } diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index 72fc9e3d91..a4f778a8a4 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -1033,7 +1033,8 @@ int mlx5dr_cmd_generate_wqe(struct ibv_context *ctx, ret = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out)); if (ret) { - DR_LOG(ERR, "Failed to write GTA WQE using FW"); + DR_LOG(ERR, "Failed to write GTA WQE using FW (syndrome: %#x)", + mlx5dr_cmd_get_syndrome(out)); rte_errno = errno; return rte_errno; } -- 2.39.3