From: Robin Jarry <rjarry@redhat.com>
To: dev@dpdk.org, Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Cc: David Marchand <david.marchand@redhat.com>
Subject: [PATCH v2] ci: run more checks in private repositories
Date: Tue, 9 Jul 2024 15:17:24 +0200 [thread overview]
Message-ID: <20240709131722.1039777-3-rjarry@redhat.com> (raw)
In-Reply-To: <20220324145343.24485-1-david.marchand@redhat.com>
From: David Marchand <david.marchand@redhat.com>
Though devtools/checkpatches.sh is run as part of our CI, some other
(not well known) checks could help when run in private repositories
before submitting to the mailing list and even when run from the
ovsrobot.
Most of them require a git history or checked sources to run.
And I can't guarantee there won't be false positives.
Add a new job just for those checks so that it won't block compilation
tests in other jobs.
Signed-off-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Robin Jarry <rjarry@redhat.com>
Acked-by: Aaron Conole <aconole@redhat.com>
---
Notes:
v2:
* rebased on HEAD
* removed check-git-log.sh from checks to avoid too many false positives
.ci/linux-build.sh | 2 --
.github/workflows/build.yml | 24 +++++++++++++++++++++++-
2 files changed, 23 insertions(+), 3 deletions(-)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 15ed51e4c18c..fdb578762116 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -148,8 +148,6 @@ if [ "$ABI_CHECKS" = "true" ]; then
export PATH=$(pwd)/libabigail/bin:$PATH
- REF_GIT_REPO=${REF_GIT_REPO:-https://dpdk.org/git/dpdk}
-
if [ "$(cat reference/VERSION 2>/dev/null)" != "$REF_GIT_TAG" ]; then
rm -rf reference
fi
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index dbf25626d4c4..7efc0b935e17 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -9,7 +9,30 @@ defaults:
run:
shell: bash --noprofile --norc -exo pipefail {0}
+env:
+ REF_GIT_BRANCH: main
+ REF_GIT_REPO: https://dpdk.org/git/dpdk
+ REF_GIT_TAG: v24.03
+
jobs:
+ checkpatch:
+ if: github.repository != 'DPDK/dpdk'
+ name: Check patches
+ runs-on: ubuntu-24.04
+ steps:
+ - name: Checkout sources
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ - name: Check patches
+ run: |
+ git remote add upstream ${{ env.REF_GIT_REPO }}
+ git fetch upstream ${{ env.REF_GIT_BRANCH }}
+ failed=
+ devtools/check-doc-vs-code.sh upstream/${{ env.REF_GIT_BRANCH }} || failed=true
+ devtools/check-meson.py || failed=true
+ devtools/check-symbol-maps.sh || failed=true
+ [ -z "$failed" ]
ubuntu-vm-builds:
name: ${{ join(matrix.config.*, '-') }}
runs-on: ${{ matrix.config.os }}
@@ -27,7 +50,6 @@ jobs:
MINGW: ${{ matrix.config.cross == 'mingw' }}
MINI: ${{ matrix.config.mini != '' }}
PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
- REF_GIT_TAG: v24.03
RISCV64: ${{ matrix.config.cross == 'riscv64' }}
RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}
STDATOMIC: ${{ contains(matrix.config.checks, 'stdatomic') }}
--
2.45.2
prev parent reply other threads:[~2024-07-09 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:53 [PATCH] " David Marchand
2022-03-25 14:32 ` Aaron Conole
2022-04-28 12:12 ` David Marchand
2024-07-09 13:17 ` Robin Jarry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240709131722.1039777-3-rjarry@redhat.com \
--to=rjarry@redhat.com \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).