From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E87AB455E3; Tue, 9 Jul 2024 15:17:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B69704060F; Tue, 9 Jul 2024 15:17:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E4C0F402E8 for ; Tue, 9 Jul 2024 15:17:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720531072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l/bCbUcVQj3ShWfLAEt6gLQM8oFNpbNXm0NzGM2mDvU=; b=evquoKcCgKYRqwXn3sXLDO6RP1iMIH6KIHy9VRwztMch7eWfcv0+sh/d3XKB+hKIgDPeEq iF2GL6A9pHgj/qtB3TuvrQt8fyee0hwXsSurSa0wLZ5drInbudV72auamXWjCIsKg5wDOi 6A9geDkV3mOin5VsiE8cQprHgFds78Y= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-Ba9OQ4OaORSfktxPhBbEQA-1; Tue, 09 Jul 2024 09:17:51 -0400 X-MC-Unique: Ba9OQ4OaORSfktxPhBbEQA-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0D5A3196CDF5; Tue, 9 Jul 2024 13:17:50 +0000 (UTC) Received: from ringo.home (unknown [10.39.208.27]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 327B619560AE; Tue, 9 Jul 2024 13:17:47 +0000 (UTC) From: Robin Jarry To: dev@dpdk.org, Aaron Conole , Michael Santana Cc: David Marchand Subject: [PATCH v2] ci: run more checks in private repositories Date: Tue, 9 Jul 2024 15:17:24 +0200 Message-ID: <20240709131722.1039777-3-rjarry@redhat.com> In-Reply-To: <20220324145343.24485-1-david.marchand@redhat.com> References: <20220324145343.24485-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: David Marchand Though devtools/checkpatches.sh is run as part of our CI, some other (not well known) checks could help when run in private repositories before submitting to the mailing list and even when run from the ovsrobot. Most of them require a git history or checked sources to run. And I can't guarantee there won't be false positives. Add a new job just for those checks so that it won't block compilation tests in other jobs. Signed-off-by: David Marchand Signed-off-by: Robin Jarry Acked-by: Aaron Conole --- Notes: v2: * rebased on HEAD * removed check-git-log.sh from checks to avoid too many false positives .ci/linux-build.sh | 2 -- .github/workflows/build.yml | 24 +++++++++++++++++++++++- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index 15ed51e4c18c..fdb578762116 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -148,8 +148,6 @@ if [ "$ABI_CHECKS" = "true" ]; then export PATH=$(pwd)/libabigail/bin:$PATH - REF_GIT_REPO=${REF_GIT_REPO:-https://dpdk.org/git/dpdk} - if [ "$(cat reference/VERSION 2>/dev/null)" != "$REF_GIT_TAG" ]; then rm -rf reference fi diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index dbf25626d4c4..7efc0b935e17 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,7 +9,30 @@ defaults: run: shell: bash --noprofile --norc -exo pipefail {0} +env: + REF_GIT_BRANCH: main + REF_GIT_REPO: https://dpdk.org/git/dpdk + REF_GIT_TAG: v24.03 + jobs: + checkpatch: + if: github.repository != 'DPDK/dpdk' + name: Check patches + runs-on: ubuntu-24.04 + steps: + - name: Checkout sources + uses: actions/checkout@v4 + with: + fetch-depth: 0 + - name: Check patches + run: | + git remote add upstream ${{ env.REF_GIT_REPO }} + git fetch upstream ${{ env.REF_GIT_BRANCH }} + failed= + devtools/check-doc-vs-code.sh upstream/${{ env.REF_GIT_BRANCH }} || failed=true + devtools/check-meson.py || failed=true + devtools/check-symbol-maps.sh || failed=true + [ -z "$failed" ] ubuntu-vm-builds: name: ${{ join(matrix.config.*, '-') }} runs-on: ${{ matrix.config.os }} @@ -27,7 +50,6 @@ jobs: MINGW: ${{ matrix.config.cross == 'mingw' }} MINI: ${{ matrix.config.mini != '' }} PPC64LE: ${{ matrix.config.cross == 'ppc64le' }} - REF_GIT_TAG: v24.03 RISCV64: ${{ matrix.config.cross == 'riscv64' }} RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }} STDATOMIC: ${{ contains(matrix.config.checks, 'stdatomic') }} -- 2.45.2