From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB06E455D4; Wed, 10 Jul 2024 16:54:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDC5341101; Wed, 10 Jul 2024 16:54:05 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mails.dpdk.org (Postfix) with ESMTP id C35C540FDE; Wed, 10 Jul 2024 16:54:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720623245; x=1752159245; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=C1yYIy8PESQNxJGPsAcujAjPFTx2UXeye1fbCY+rkC4=; b=N3GNrgHFd6OuMNfQPi4pskRTKoYQceWySoZXM8R2FfqS0wT5a6DhGs8P 4PYolYf+sFOciZfQJqzZ3bzMgVZiO4LiUUO9CtwcCmqFXEXf/qV+srYQR j4yq0q227rOw8nrCC8ode+gUr+z9mSgIvBRp83FtLDAIOWiytqZQKg6Cl tggSA1gNSCVO5bnGr9/zVomJ0Ii/VwQdVdSJTwYyxyFBpuR66yrlt0DpJ 0RgCe+b1oh7h3TBrDBlE1/eVSedTfM1s3xaNzTU319iJ8Y56R1pk4CeRs fhwHH+K7A4qf5RlsVJJOWh6+jYr1Kee+9BUPL8D4KtUaB93P+MZazsAE/ g==; X-CSE-ConnectionGUID: DoFPHtzeSMai4tOWJvgCLg== X-CSE-MsgGUID: 2LwKAXbNR16HPKGBVB3zEA== X-IronPort-AV: E=McAfee;i="6700,10204,11129"; a="35484819" X-IronPort-AV: E=Sophos;i="6.09,198,1716274800"; d="scan'208";a="35484819" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2024 07:54:02 -0700 X-CSE-ConnectionGUID: HJrmbE0TRgGDX3UfiTXfkw== X-CSE-MsgGUID: zD48c+7FShKqhV4m5Oxc4A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,198,1716274800"; d="scan'208";a="47990001" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.17]) by fmviesa006.fm.intel.com with ESMTP; 10 Jul 2024 07:53:57 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Subject: [PATCH] net/cpfl: fix build error for debian 32-bit Date: Wed, 10 Jul 2024 15:53:51 +0100 Message-ID: <20240710145351.599031-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When building for debian 11 32-bit, errors were reported with cpfl driver[1]. The error is due to comparing signed and unsigned values: ../drivers/net/cpfl/cpfl_flow_parser.c:1699:29: error: comparison of integer expressions of different signedness: 'long int' and 'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare] Fix the issue by using an explicitly cast for the return value from atol. Fixes: c10881d3ee74 ("net/cpfl: support flow prog action") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson [1] https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_11/i586 --- drivers/net/cpfl/cpfl_flow_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_flow_parser.c b/drivers/net/cpfl/cpfl_flow_parser.c index a8f0488f21..40569ddc6f 100644 --- a/drivers/net/cpfl/cpfl_flow_parser.c +++ b/drivers/net/cpfl/cpfl_flow_parser.c @@ -1696,7 +1696,7 @@ cpfl_parse_check_prog_action(struct cpfl_flow_js_mr_key_action *key_act, bool check_name; check_name = key_act->prog.has_name ? strcmp(prog->name, key_act->prog.name) == 0 - : atol(prog->name) == key_act->prog.id; + : (uint32_t)atol(prog->name) == key_act->prog.id; if (!check_name) { PMD_DRV_LOG(ERR, "Not support this prog type: %s.", prog->name); return -EINVAL; -- 2.43.0