From: Stephen Hemminger <stephen@networkplumber.org>
To: Jun Wang <junwang01@cestc.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process
Date: Fri, 12 Jul 2024 10:17:04 -0700 [thread overview]
Message-ID: <20240712101704.20e3f8a3@hermes.local> (raw)
In-Reply-To: <1720783847-12292-1-git-send-email-junwang01@cestc.cn>
On Fri, 12 Jul 2024 19:30:47 +0800
Jun Wang <junwang01@cestc.cn> wrote:
> The code to update link status is not safe in secondary process.
> If called from secondary it will crash, example from dumpcap:
> eth_em_link_update
>
> Signed-off-by: Jun Wang <junwang01@cestc.cn>
Wouldn't it be better to fix the code in e1000_check_link to work in
secondary process. There are network virtual appliances that use
secondary process for all processing.
next prev parent reply other threads:[~2024-07-12 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:30 Jun Wang
2024-07-12 17:17 ` Stephen Hemminger [this message]
2024-07-14 8:26 ` Jun Wang
2024-07-22 17:08 ` Bruce Richardson
2024-07-23 2:07 ` Jun Wang
2024-08-22 15:58 ` Bruce Richardson
2024-08-22 16:02 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712101704.20e3f8a3@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=junwang01@cestc.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).