From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CAC445619; Fri, 12 Jul 2024 19:17:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44C08410E8; Fri, 12 Jul 2024 19:17:09 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id E7703402F2 for ; Fri, 12 Jul 2024 19:17:07 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-75ee39f1ffbso1537522a12.2 for ; Fri, 12 Jul 2024 10:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1720804627; x=1721409427; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TJGov529gOZ/NRPnXSkSKg/CaMOYnHUR4+XKp8phnhU=; b=qw68CeQaBXmseEQ/VlxdbFCkJI8gj7XyCxYm7g0Gif25meoEvjXHUYzd5/S3rwi+Au OcLmtKo+vd8MZauZcMgAJV5OkEufuvhqMEtUztoyPNbFVmMhgiGGvXItyROZfztHeZcO 4k+Ecip3zt/P1L8UjWOFdcPR2SUC5tPyDocQhdXMmYCfiqjfNhd2pAMAPMDwY7WXpQIz 2DmAUORFtA9Abl8Kf/HFXsN6PbtzShVJ6vv/w+obFfmJe7LUrz5R3GaURyCn1iW6qFJe ARYJ6jyR0bgI+LbfaVyQpCOCljCe4xEanJtSMGcjHvAsPfhlIby3nTn35zWBoXQg6VBQ GGvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720804627; x=1721409427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TJGov529gOZ/NRPnXSkSKg/CaMOYnHUR4+XKp8phnhU=; b=GSaKK2isubOuakjJPKD1EVkfxIugSV182Ao/+vMifUx10QdGl/o0eBQ+1w6XlG+Y9P HHThCARgVmwp+XeRbxp3+rWnXk9ySEendzXfSiEBkjD23xA7eZICD90qtsZqIoBRYmp4 YvqpPS5S2R+rqmWbxQCxuKYv6930YRmu6IAXvjDSiLQ8YAfU/1Uidx1bmgRuXuYDLeoz xbBuPlOri5gLpHZhfqq5eIj6XMsefoDqsKoAIwyIXqpDP7qoU15Ulyt/E+PWKsIGFp0+ ePR+BLu9LxIm/geFsF0IneZj405lX/TkuIiQeq7QC2nf7jwvGFjxqUrLarwWJ+9WqmXc pMYQ== X-Gm-Message-State: AOJu0YzdXmIOmOVA0+C3H3NZqBsBF8e2hE8N4H+al7GLcff6qaw9Tgvs KOVFteVbeatVfyryp1Tlzs4IhpP6cFLDXp8dAaeoKRShCK7ke8DPns7Ol5CQ+12PHWV0HkWJ73O bxcc= X-Google-Smtp-Source: AGHT+IEwARvFCSYo+HsJVM+8zy+8Va0jdtOKcp1wBW2rA7XDRyDOK2/+wln8OoDPQ9gc8megKwXeSg== X-Received: by 2002:a05:6a21:2d04:b0:1c3:b47d:d53f with SMTP id adf61e73a8af0-1c3b47dd820mr6620557637.25.1720804626849; Fri, 12 Jul 2024 10:17:06 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70b439b9a90sm7738143b3a.199.2024.07.12.10.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jul 2024 10:17:06 -0700 (PDT) Date: Fri, 12 Jul 2024 10:17:04 -0700 From: Stephen Hemminger To: Jun Wang Cc: dev@dpdk.org Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process Message-ID: <20240712101704.20e3f8a3@hermes.local> In-Reply-To: <1720783847-12292-1-git-send-email-junwang01@cestc.cn> References: <1720783847-12292-1-git-send-email-junwang01@cestc.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 12 Jul 2024 19:30:47 +0800 Jun Wang wrote: > The code to update link status is not safe in secondary process. > If called from secondary it will crash, example from dumpcap: > eth_em_link_update > > Signed-off-by: Jun Wang Wouldn't it be better to fix the code in e1000_check_link to work in secondary process. There are network virtual appliances that use secondary process for all processing.