From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B9A64561A; Sun, 14 Jul 2024 10:26:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED4BD40269; Sun, 14 Jul 2024 10:26:43 +0200 (CEST) Received: from smtp.cecloud.com (unknown [1.203.97.240]) by mails.dpdk.org (Postfix) with ESMTP id 122F240263 for ; Sun, 14 Jul 2024 10:26:41 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by smtp.cecloud.com (Postfix) with ESMTP id A0B43900116 for ; Sun, 14 Jul 2024 16:26:39 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from wangjun (unknown [183.209.142.110]) by smtp.cecloud.com (postfix) whith ESMTP id P1340310T281473214968176S1720945586725520_; Sun, 14 Jul 2024 16:26:27 +0800 (CST) X-RL-SENDER: junwang01@cestc.cn X-SENDER: junwang01@cestc.cn X-LOGIN-NAME: junwang01@cestc.cn X-FST-TO: stephen@networkplumber.org X-RCPT-COUNT: 2 X-LOCAL-RCPT-COUNT: 0 X-MUTI-DOMAIN-COUNT: 0 X-SENDER-IP: 183.209.142.110 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: X-System-Flag: 0 Date: Sun, 14 Jul 2024 16:26:26 +0800 From: "Jun Wang" To: stephen Cc: dev Subject: Re: [PATCH v1] net/e1000: do not update link status in secondary process References: <1720783847-12292-1-git-send-email-junwang01@cestc.cn>, <20240712101704.20e3f8a3@hermes.local> X-Priority: 3 X-GUID: F0B5AEC5-E5ED-42FB-809E-832CD4C55BEB X-Has-Attach: no X-Mailer: Foxmail 7.2.25.259[cn] Mime-Version: 1.0 Message-ID: <202407141626262115324@cestc.cn> Content-Type: multipart/alternative; boundary="----=_001_NextPart758415417046_=----" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a multi-part message in MIME format. ------=_001_NextPart758415417046_=---- Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: base64 Pj4gVGhlIGNvZGUgdG8gdXBkYXRlIGxpbmsgc3RhdHVzIGlzIG5vdCBzYWZlIGluIHNlY29uZGFy eSBwcm9jZXNzLg0KPj4gSWYgY2FsbGVkIGZyb20gc2Vjb25kYXJ5IGl0IHdpbGwgY3Jhc2gsIGV4 YW1wbGUgZnJvbSBkdW1wY2FwOg0KPj4gICAgIGV0aF9lbV9saW5rX3VwZGF0ZQ0KPj4NCj4+IFNp Z25lZC1vZmYtYnk6IEp1biBXYW5nIDxqdW53YW5nMDFAY2VzdGMuY24+DQo+IA0KPiBXb3VsZG4n dCBpdCBiZSBiZXR0ZXIgdG8gZml4IHRoZSBjb2RlIGluIGUxMDAwX2NoZWNrX2xpbmsgdG8gd29y ayBpbg0KPiBzZWNvbmRhcnkgcHJvY2Vzcy4gVGhlcmUgYXJlIG5ldHdvcmsgdmlydHVhbCBhcHBs aWFuY2VzIHRoYXQgdXNlDQo+IHNlY29uZGFyeSBwcm9jZXNzIGZvciBhbGwgcHJvY2Vzc2luZy4N Cg0KWWVzLCB0aGUgZTEwMDAgdmlydHVhbCBuZXR3b3JrIGNhcmQgY3VycmVudGx5IGRvZXMgbm90 IHdvcmsgcHJvcGVybHkgDQppbiB0aGUgc2Vjb25kYXJ5IHByb2Nlc3MuIEFmdGVyIHNraXBwaW5n IGV0aF9lbV9saW5rX3VwZGF0ZSwgSSB0ZXN0ZWQNCnRoZSBlMTAwMCBjYXJkIGFuZCBpdCB3YXMg YWJsZSB0byBjYXB0dXJlIHBhY2tldHMgbm9ybWFsbHkuIEZvciB0aGUgDQpzZWNvbmRhcnkgcHJv Y2VzcywgSSB0aGluayBldGhfZW1fbGlua191cGRhdGUgaXMgbm90IG5lY2Vzc2FyeS4NCg0KDQoN Ckp1biBXYW5nDQo= ------=_001_NextPart758415417046_=---- Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable =0A
>> The code to update link status is not = safe in secondary process.
>> If called from secondary it will crash, example = from dumpcap:
>= ;>     eth_em_link_update
>>
>> Signed-off-by: Jun W= ang <junwang01@cestc.cn>
> 
> Wouldn't it be better to fix the code in e= 1000_check_link to work in
> secondary process. There are network virtual ap= pliances that use
> secondary process for all processing.
=0A
Yes, the e1000 virtual network card currently does not wor= k properly 
in the secondary process. After skipping eth_em= _link_update, I tested
the e1000 card and it was able to capture= packets normally. For the 
secondary process, I think eth_= em_link_update is not necessary.

=0A
Jun= Wang
=0A ------=_001_NextPart758415417046_=------