DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v1] test/crypto: remove unused stats in test setup
@ 2024-07-15 13:36 Gowrishankar Muthukrishnan
  2024-07-16  5:24 ` Anoob Joseph
  2024-07-18 15:48 ` Akhil Goyal
  0 siblings, 2 replies; 3+ messages in thread
From: Gowrishankar Muthukrishnan @ 2024-07-15 13:36 UTC (permalink / raw)
  To: dev, Akhil Goyal, Fan Zhang, Ashish Gupta, Sunila Sahu,
	Pablo de Lara, Umesh  Kartha, Shally Verma
  Cc: Anoob Joseph, Gowrishankar Muthukrishnan, stable

Remove unused stats in test setup.

Coverity issue: 373869
Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests")
Cc: stable@dpdk.org

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
 app/test/test_cryptodev_asym.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index ef926c6229..3802cf8022 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -547,8 +547,6 @@ ut_setup_asym(void)
 			qp_id, ts_params->valid_devs[0]);
 	}
 
-	rte_cryptodev_stats_reset(ts_params->valid_devs[0]);
-
 	/* Start the device */
 	TEST_ASSERT_SUCCESS(rte_cryptodev_start(ts_params->valid_devs[0]),
 						"Failed to start cryptodev %u",
@@ -561,7 +559,6 @@ static void
 ut_teardown_asym(void)
 {
 	struct crypto_testsuite_params_asym *ts_params = &testsuite_params;
-	struct rte_cryptodev_stats stats;
 	uint8_t dev_id = ts_params->valid_devs[0];
 
 	if (self->sess != NULL)
@@ -571,8 +568,6 @@ ut_teardown_asym(void)
 	self->op = NULL;
 	self->result_op = NULL;
 
-	rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats);
-
 	/* Stop the device */
 	rte_cryptodev_stop(ts_params->valid_devs[0]);
 }
-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH v1] test/crypto: remove unused stats in test setup
  2024-07-15 13:36 [PATCH v1] test/crypto: remove unused stats in test setup Gowrishankar Muthukrishnan
@ 2024-07-16  5:24 ` Anoob Joseph
  2024-07-18 15:48 ` Akhil Goyal
  1 sibling, 0 replies; 3+ messages in thread
From: Anoob Joseph @ 2024-07-16  5:24 UTC (permalink / raw)
  To: Gowrishankar Muthukrishnan, dev, Akhil Goyal, Fan Zhang,
	Ashish Gupta, Sunila Sahu, Pablo de Lara, Umesh Kartha,
	Shally Verma
  Cc: Gowrishankar Muthukrishnan, stable

> Subject: [PATCH v1] test/crypto: remove unused stats in test setup
> 
> Remove unused stats in test setup.
> 
> Coverity issue: 373869
> Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>

Acked-by: Anoob Joseph <anoobj@marvell.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH v1] test/crypto: remove unused stats in test setup
  2024-07-15 13:36 [PATCH v1] test/crypto: remove unused stats in test setup Gowrishankar Muthukrishnan
  2024-07-16  5:24 ` Anoob Joseph
@ 2024-07-18 15:48 ` Akhil Goyal
  1 sibling, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2024-07-18 15:48 UTC (permalink / raw)
  To: Gowrishankar Muthukrishnan, dev, Fan Zhang, Ashish Gupta,
	Sunila Sahu, Pablo de Lara, Umesh Kartha, Shally Verma
  Cc: Anoob Joseph, Gowrishankar Muthukrishnan, stable

> Subject: [PATCH v1] test/crypto: remove unused stats in test setup
> 
> Remove unused stats in test setup.
> 
> Coverity issue: 373869
> Fixes: 2c6dab9cd93 ("test/crypto: add RSA and Mod tests")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Applied to dpdk-next-crypto
Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-18 15:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-15 13:36 [PATCH v1] test/crypto: remove unused stats in test setup Gowrishankar Muthukrishnan
2024-07-16  5:24 ` Anoob Joseph
2024-07-18 15:48 ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).