DPDK patches and discussions
 help / color / mirror / Atom feed
From: jspewock@iol.unh.edu
To: probb@iol.unh.edu, juraj.linkes@pantheon.tech,
	thomas@monjalon.net, wathsala.vithanage@arm.com,
	paul.szczepanek@arm.com, npratte@iol.unh.edu,
	yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com,
	Luca.Vizzarro@arm.com
Cc: dev@dpdk.org, Jeremy Spewock <jspewock@iol.unh.edu>, dmarx@iol.unh.edu
Subject: [PATCH v1 1/3] dts: fix Testpmd function for resetting VLAN insertion
Date: Mon, 15 Jul 2024 15:58:50 -0400	[thread overview]
Message-ID: <20240715195852.254033-2-jspewock@iol.unh.edu> (raw)
In-Reply-To: <20240715195852.254033-1-jspewock@iol.unh.edu>

From: Jeremy Spewock <jspewock@iol.unh.edu>

The previous method would send the command `tx_vlan set <port_id>` when
the correct command is `tx_vlan reset <port_id>`.

Fixes: a49d9da1e9a5 ("dts: add VLAN methods to testpmd shell")
Cc: dmarx@iol.unh.edu

depends-on: patch-142103 ("dts: add VLAN methods to testpmd shell")

Signed-off-by: Jeremy Spewock <jspewock@iol.unh.edu>
---
 dts/framework/remote_session/testpmd_shell.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
index 09d3bda5d6..a8b6a054b5 100644
--- a/dts/framework/remote_session/testpmd_shell.py
+++ b/dts/framework/remote_session/testpmd_shell.py
@@ -994,7 +994,7 @@ def tx_vlan_reset(self, port: int, verify: bool = True):
             InteractiveCommandExecutionError: If `verify` is :data:`True` and the insertion
                 tag is not reset.
         """
-        vlan_insert_output = self.send_command(f"tx_vlan set {port}")
+        vlan_insert_output = self.send_command(f"tx_vlan reset {port}")
         if verify:
             if "Please stop port" in vlan_insert_output or "Invalid port" in vlan_insert_output:
                 self._logger.debug(
-- 
2.45.2


  reply	other threads:[~2024-07-15 19:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-15 19:58 [PATCH v1 0/3] dts: add test suite for dual VLANs jspewock
2024-07-15 19:58 ` jspewock [this message]
2024-07-15 19:58 ` [PATCH v1 2/3] dts: add dual_vlan testing suite jspewock
2024-07-22 17:38   ` Dean Marx
2024-07-25 13:56     ` Jeremy Spewock
2024-07-31 13:54       ` Jeremy Spewock
2024-07-15 19:58 ` [PATCH v1 3/3] dts: add dual_vlan test suite to the yaml schema jspewock
2024-07-16 21:24 ` [PATCH v2 0/2] dts: add test suite for dual VLANs jspewock
2024-07-16 21:24   ` [PATCH v2 1/2] dts: add dual_vlan testing suite jspewock
2024-08-07 19:07     ` Dean Marx
2024-07-16 21:24   ` [PATCH v2 2/2] dts: add dual_vlan test suite to the yaml schema jspewock
2024-07-24 17:13 ` [PATCH v3 0/2] dts: add test suite for dual VLANs jspewock
2024-07-24 17:13   ` [PATCH v3 1/2] dts: add dual_vlan testing suite jspewock
2024-08-13 19:47     ` Dean Marx
2024-09-12  3:46     ` Patrick Robb
2024-07-24 17:13   ` [PATCH v3 2/2] dts: add dual_vlan test suite to the yaml schema jspewock
2024-08-13 19:48     ` Dean Marx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240715195852.254033-2-jspewock@iol.unh.edu \
    --to=jspewock@iol.unh.edu \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Luca.Vizzarro@arm.com \
    --cc=dev@dpdk.org \
    --cc=dmarx@iol.unh.edu \
    --cc=juraj.linkes@pantheon.tech \
    --cc=npratte@iol.unh.edu \
    --cc=paul.szczepanek@arm.com \
    --cc=probb@iol.unh.edu \
    --cc=thomas@monjalon.net \
    --cc=wathsala.vithanage@arm.com \
    --cc=yoan.picchi@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).