[PATCH] app/testpmd: add postpone option to async flow destroy

[PATCH] app/testpmd: add postpone option to async flow destroy

[Alexander Kozyrev]

The potpone option is not available in the async flow destroy CLI.
Only flow creation can be postponed in the testpmd application.
Insert this option into the async flow destroy CLI before the rule ID.

Fixes: ecdc927b99 ("app/testpmd: add async flow create/destroy operations")

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index a76b44bf39..fb6a552863 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -3703,7 +3703,7 @@ static const struct token token_list[] = {
 	[QUEUE_DESTROY] = {
 		.name = "destroy",
 		.help = "destroy a flow rule",
-		.next = NEXT(NEXT_ENTRY(QUEUE_DESTROY_ID),
+		.next = NEXT(NEXT_ENTRY(QUEUE_DESTROY_POSTPONE),
 			     NEXT_ENTRY(COMMON_QUEUE_ID)),
 		.args = ARGS(ARGS_ENTRY(struct buffer, queue)),
 		.call = parse_qo_destroy,
-- 
2.18.2

RE: [PATCH] app/testpmd: add postpone option to async flow destroy

[Dariusz Sosnowski]

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Wednesday, July 17, 2024 16:20
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Dariusz
> Sosnowski <dsosnowski@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>
> Subject: [PATCH] app/testpmd: add postpone option to async flow destroy
> 
> The potpone option is not available in the async flow destroy CLI.

Typo: s/potpone/postpone/

> Only flow creation can be postponed in the testpmd application.
> Insert this option into the async flow destroy CLI before the rule ID.
> 
> Fixes: ecdc927b99 ("app/testpmd: add async flow create/destroy operations")

Could you please add Cc: stable@dpdk.org?
It's better that we keep this tag in git log. It helps LTS maintainers with backports.

> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
>  app/test-pmd/cmdline_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index
> a76b44bf39..fb6a552863 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -3703,7 +3703,7 @@ static const struct token token_list[] = {
>  	[QUEUE_DESTROY] = {
>  		.name = "destroy",
>  		.help = "destroy a flow rule",
> -		.next = NEXT(NEXT_ENTRY(QUEUE_DESTROY_ID),
> +		.next = NEXT(NEXT_ENTRY(QUEUE_DESTROY_POSTPONE),
>  			     NEXT_ENTRY(COMMON_QUEUE_ID)),
>  		.args = ARGS(ARGS_ENTRY(struct buffer, queue)),
>  		.call = parse_qo_destroy,
> --
> 2.18.2

Best regards,
Dariusz Sosnowski

Re: [PATCH] app/testpmd: add postpone option to async flow destroy

[Ferruh Yigit]

On 7/18/2024 1:05 PM, Dariusz Sosnowski wrote:
>> -----Original Message-----
>> From: Alexander Kozyrev <akozyrev@nvidia.com>
>> Sent: Wednesday, July 17, 2024 16:20
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
>> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Dariusz
>> Sosnowski <dsosnowski@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam
>> <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>
>> Subject: [PATCH] app/testpmd: add postpone option to async flow destroy
>>
>> The potpone option is not available in the async flow destroy CLI.
> 
> Typo: s/potpone/postpone/
> 

Fixed while merging

>> Only flow creation can be postponed in the testpmd application.
>> Insert this option into the async flow destroy CLI before the rule ID.
>>
>> Fixes: ecdc927b99 ("app/testpmd: add async flow create/destroy operations")
> 
> Could you please add Cc: stable@dpdk.org?
> It's better that we keep this tag in git log. It helps LTS maintainers with backports.
> 

Tag added while merging

>>
>> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
>> ---
>>  app/test-pmd/cmdline_flow.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index
>> a76b44bf39..fb6a552863 100644
>> --- a/app/test-pmd/cmdline_flow.c
>> +++ b/app/test-pmd/cmdline_flow.c
>> @@ -3703,7 +3703,7 @@ static const struct token token_list[] = {
>>  	[QUEUE_DESTROY] = {
>>  		.name = "destroy",
>>  		.help = "destroy a flow rule",
>> -		.next = NEXT(NEXT_ENTRY(QUEUE_DESTROY_ID),
>> +		.next = NEXT(NEXT_ENTRY(QUEUE_DESTROY_POSTPONE),
>>  			     NEXT_ENTRY(COMMON_QUEUE_ID)),
>>  		.args = ARGS(ARGS_ENTRY(struct buffer, queue)),
>>  		.call = parse_qo_destroy,
>> --
>> 2.18.2
> 

Adding explicit review tag:
Reviewed-by: Dariusz Sosnowski <dsosnowski@nvidia.com>


Applied to dpdk-next-net/main, thanks.