From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37C8445637; Wed, 17 Jul 2024 18:36:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 190DE40299; Wed, 17 Jul 2024 18:36:19 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2053.outbound.protection.outlook.com [40.107.95.53]) by mails.dpdk.org (Postfix) with ESMTP id 0619140280 for ; Wed, 17 Jul 2024 18:36:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cSChf5l8K1dU/TXcE9QzHLHmC+PFSrkb1us2tIN2/KsesA4gFLVQG9Wl16dAt067iKI9on5X521noxhQVmtTbzfDrROLqSrvp4nYwSW/ZcT1nwHMhXixgFgFJDPpNufpW5llaSBdxqvgSqbF+Qz0PMUPYp/vE3P/y6jnvqg9mYSiDkwwW/kvYzBmZ87M7XIsogv7REExFijFgQvqq5rfxB7vPkgO+4ssswXRfFe3as/RX+Wve4ugTH4UbjqLECDsi1IVLq8aTYY7DBbGwbl4H9Zim3kYwvItqeGMBGBbdleDcqSm366FRUzelJEwRAOfc3px/RIUqi/QpOGfdTeqwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2caOTia5iBE+ILaq6U/D0cX11oblZNaEXHmRhcfMTIY=; b=LXJrmkIuRQLdCEr/JFGU/p7vRq0KXZNq9tDowBun6/5XCi+ASbw51uvIIfEAGnSdfaPS2ZO4hJrbrGvAGtw31WZVDVKz4uKxrwQcqykmN+NKbVRlPAYAQeP1QPcXNa8nVbFqd6vFj5/o2SVPRmPHYvqrqqNj88PgPjlqArkYWeHtqKFisbbWqUdGoqxtHqPEk5/MPZDu3CPe/n734lMzzlfM7zIAwMChY8Lfs3ZQSFVTDempnGUJJYgRxheCWtGeVgbytEdH62uv9ZImtQZoA2gkeSaq0GDrur7dMO101xb6Sf+P4NzXF2mpZPlneD9ksoL5D109+5XJ2O6M+eolyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2caOTia5iBE+ILaq6U/D0cX11oblZNaEXHmRhcfMTIY=; b=J6DEL5nvIHFaKgrVJNMPnKaqduj3B0PTjxtAYuYDf5CV87TeLJqbQj+ZvH/FsuBdGkBnlPsp21rSZSa5LI1KVEXnIDQOGA6+rm4MARRaq5nWROBAnFMWL1VZtbZhkDv4P+qOvi+G0vp9AjEg0n4+REY4irjD1hw3g5r4TNVrorndgOlTC8BMJVG6D5JbrXGl0AnfdGAeKNMIpWvor6nXnZmEXOM48eFCR7kGer8larrHR/o2jDw7vFxqby5KAernNseoqPMa6mS6GZ0wyJrVkBMKYP9oFdvVE6ZWOL+PMs6mONYVzKA7O6mq8a98BA+tqVki9MjgzvZqPMxb7KaVOQ== Received: from BN9P223CA0029.NAMP223.PROD.OUTLOOK.COM (2603:10b6:408:10b::34) by IA0PR12MB7775.namprd12.prod.outlook.com (2603:10b6:208:431::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7762.29; Wed, 17 Jul 2024 16:36:13 +0000 Received: from BN3PEPF0000B372.namprd21.prod.outlook.com (2603:10b6:408:10b:cafe::9a) by BN9P223CA0029.outlook.office365.com (2603:10b6:408:10b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.17 via Frontend Transport; Wed, 17 Jul 2024 16:36:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN3PEPF0000B372.mail.protection.outlook.com (10.167.243.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Wed, 17 Jul 2024 16:36:13 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 17 Jul 2024 09:35:58 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 17 Jul 2024 09:35:55 -0700 From: Bing Zhao To: , , CC: , , , Subject: [PATCH] net/mlx5: fix the uplink port probing in bond mode Date: Wed, 17 Jul 2024 19:35:41 +0300 Message-ID: <20240717163541.324772-1-bingz@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B372:EE_|IA0PR12MB7775:EE_ X-MS-Office365-Filtering-Correlation-Id: 1c71a6fe-29ba-477d-4338-08dca67e9293 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?pVWWgWKTU130UW+j1EeRkv3le3ggOQKepAdMj8PSLsPUy3mdtra+Iuy3/pxe?= =?us-ascii?Q?Pw8bJLUoHWu2IDgfYHaxqTZHheyLkPNg3Cy8NyputbXaaafUhbZedxbblBB5?= =?us-ascii?Q?8l+8sbM2ld8WcZ/Vx3S7stfN12wj/4BZe8yN2/tqalnbqF2smmwIcWksuZ9b?= =?us-ascii?Q?Rx/ATNDmP/wtv2/G2YTDhlASya2NAGf/ADVerkNwkK4YjQxb+4/d1RkKTG2N?= =?us-ascii?Q?qrBl8KZytYwv3Zqpz/NDeYrvmV7vwBjGVJ2VMI+Co/TsoRmCd0SvZRmVs9GL?= =?us-ascii?Q?8YFk9noOTvnvHv/N3Oy86m/IPHXcGL33/MhbLOTTraMVFRRVmGPz1JdaqFbc?= =?us-ascii?Q?9VpaHE7WIGhSK0JpOjre1VwKvmfgM7rPyvSboN0p2+y4iuzv0v3gS9jUD9vc?= =?us-ascii?Q?K51ddX1bzody1g6Ga6GYIi/JtVWBKCF+kTuCm6o3tnUBnNLil51UZHtG4lAe?= =?us-ascii?Q?WBe1qbdMKwvWlM05cWxyPdhaPQvOZVGz88EkKXq55d3e7wt/50IbYnLPwS28?= =?us-ascii?Q?nbUFNfXSV5cygcJ7rMAY130fwsRTMx6GBueTZ6Hl23RSp1J0JbnNJBFm3fTC?= =?us-ascii?Q?yVoFZzgXsjjUzBstRDfG01a5hcvveWP2Pis2v+hBKsJeD4FwrLPkj1Pcw5xy?= =?us-ascii?Q?+ucdBUmfG+ebilpgqulY8zppjU2oOSoqdjbXnGEVYUIoyMg6aHm+/f3fWu9n?= =?us-ascii?Q?C1zmIBC5XYiIfCLVHhdBGygq2GvvDIK4QI+zzYKsG7TJKE5sT+ehHUft0VaD?= =?us-ascii?Q?wW4TZbw/U5HskkguegWovpmwI2qF0fn2cA3vUdkYWyz1ZQpgRVcavTRtOe4u?= =?us-ascii?Q?lg5SGX1ATVJTyJ5z2f25VCZah1jrguu7+ao+5hlrZsn1q9FKWtER0npDWz3d?= =?us-ascii?Q?vqdFQq6VRU9O7mcZjYMwJGlBsH9CC+a/6QnAoAmoA0Obw9RkwVQKYZQ/S530?= =?us-ascii?Q?5qtgeWUrdFveshVOgRjnltlDA6lGE8dSEZqi6HVduV2GpBGgyMtEq5tnnHck?= =?us-ascii?Q?pQ9Wv1xqw/m9dElD7et5pNAVcW53rECvMWxzlBfT501CaF1Fn+mOFMsDHVnS?= =?us-ascii?Q?AycbqWYHIV1EJ7UPhpMuKfBxkcT/nH8kpMND/q1YthIeEiVtAJd5LX+omYjr?= =?us-ascii?Q?j5tD1uTebaYPCMOmFqnnWrnHBB9MQTCCS+8fjA09vzLLLDpdUXVH2+j5sBtN?= =?us-ascii?Q?/iZ86CQYwuYWV7ZDBkllJkYerdjkmqzwTxazPIgVDlmdW5dC+ozqFMJP0sfP?= =?us-ascii?Q?l1jRGy88vSqCdDi3nqBXQWg2VbHNkIGjVHsE5B03Lmb8zkFTzBKPvAMErl45?= =?us-ascii?Q?asOA2UN546t3ZeTQHeEJxw5X7ebFgXJpyUWye+/gk1BedmqNnjdBd2os24R+?= =?us-ascii?Q?Qeb0UGUujqynBZkpL/r9HiM/uuuWrZaqciH6UXfkt0u4YHVNqWVWX6TpTrDe?= =?us-ascii?Q?yr+lyAOPMxPXjqBM3nKrUdvggZAWqbpC?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2024 16:36:13.2169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1c71a6fe-29ba-477d-4338-08dca67e9293 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B372.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7775 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In the HW-LAG bonding mode, the representor port can be from both slave PFs. When probing a representor (REP), the UPLINK (proxy) port always needs to be probed firstly before any REP port. In the current implementation, when probing a device with the following format: -a 0000:XX:00.0,dv_flow_en=N,representor=pf1vfy Since the REP belongs to the 2nd PF in the bonding, the UPLINK would not be added into the probing ports list. 1. In dv_flow_en=1 mode, the REP itself can be probed. But it didn't obey the rules and the behaviors were inconsistent. a. When probing the REP from 1st PFs, the UPLINK was also probed. b. When detaching the UPLINK, all REPs were detached. 2. In dv_flow_en=2 mode, since some resources can only be allocated / created on the proxy port, the probing would get a failure. By removing the unneeded check of the bonding PF device index, the UPLINK will always try to be probed with any format. Fixes: 2e569a370395 ("net/mlx5: add VF LAG mode bonding device recognition") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/linux/mlx5_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 5e950e9be1..11336c430b 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -2473,8 +2473,7 @@ mlx5_os_pci_probe_pf(struct mlx5_common_device *cdev, list[ns].info.master = 0; list[ns].info.representor = 0; } - if (list[ns].info.port_name == bd) - ns++; + ns++; break; case MLX5_PHYS_PORT_NAME_TYPE_PFHPF: /* Fallthrough */ -- 2.34.1