From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1593145637; Wed, 17 Jul 2024 18:38:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07AF940299; Wed, 17 Jul 2024 18:38:02 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2087.outbound.protection.outlook.com [40.107.102.87]) by mails.dpdk.org (Postfix) with ESMTP id AF2DD40280 for ; Wed, 17 Jul 2024 18:38:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YgGE/YNQ4szQhkQmvslA/W9zQM/hA+Rj6ofBoARMuAheOY2mpwtgslvPkgPzE7rZAdRq7Aw7zUNDSGH+TyS45wRFgQqNGet1GqDbDwLuYKWEe5LQ8fvn4aBFwzvPaV5i7bFy4cEwydlc1xooBuPULXfHqdntTbM4zCsvAnSM+o17IpIbLvrqVsZFxXnv1BQu541aYKituwfkRyz3w2KBilQfyIO2blYwdmgjEnjolWGO8FXJ0yGOiRUK0WA/GiSYLM7XCc97X1AAPfwR0voAE8hj07ibok4E4cCK0DQjGIhHHp8gU1WWRzkak4z8XkSkso+YTxcRagKmRmUKS+oCCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lhvMe11DVluLP3L62TXsvyh2BdYnqaS9rGHz6KuBwn4=; b=feZ58lZYsM4QOhLiJab9rf6RlS45/ojyvllB5hY/pmlmPGkqxOowqsKwI2hnmgNu2iH7OhG8KyvIKGEC2VQtqVIm5iP9zcYRF9l4a+8I+Ymn2yBaDtrZtdmn3IZwzIYrB0XikqIyY49J+VcS3uJpDDmsHGbTrLM2ujo8ZZZs+/kzF2OWxeOjdUJ5foJuxoW5S1/E8RkHoTxdxe63Tivrw3ycWodGUvf8LS5HBs6KUnRU14ApuXj0L4EmKg1y8fbabCBM87ybEt1tn05Mj73p7cha1x64Pk0Kz89I51PC3t/McrEY/4k2KgtsTsXnBEXywcgUex+9ZMl4Nviwc9zCEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lhvMe11DVluLP3L62TXsvyh2BdYnqaS9rGHz6KuBwn4=; b=QYVXsPWJJDYZdwM03natZkUsk9liWTfWXEU7FtclJXqX00yfJh0GRIMEP+kKZmSgu7GTKwo6/0YJL2HU0nHvmXsfdvPiGl9QkWx+YVQc/E6OXOX8pzkFAC3F+5ujxJpqKm0WAo61rGTp109XOJJQX7Myd2zfPCoFb4Adc8FOjPUbL51848DWet4Vogotj8X4pLkbQjnTgfgJdmcssDh9F4MndAz2tvbPeRrALNHqkeOjHepdqaPJfR2b0JRC3tgHS0zUe1DjEe11TpH9byl21dKIhjrv8WfBnDqKfJvB0MrFBPAPI4K8juYRs4nkBYDH4cSm1IZi/949ten5t4KlOw== Received: from BN0PR04CA0124.namprd04.prod.outlook.com (2603:10b6:408:ed::9) by PH7PR12MB9068.namprd12.prod.outlook.com (2603:10b6:510:1f4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Wed, 17 Jul 2024 16:37:57 +0000 Received: from BN3PEPF0000B374.namprd21.prod.outlook.com (2603:10b6:408:ed:cafe::84) by BN0PR04CA0124.outlook.office365.com (2603:10b6:408:ed::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16 via Frontend Transport; Wed, 17 Jul 2024 16:37:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN3PEPF0000B374.mail.protection.outlook.com (10.167.243.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.5 via Frontend Transport; Wed, 17 Jul 2024 16:37:57 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 17 Jul 2024 09:37:35 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 17 Jul 2024 09:37:33 -0700 From: Bing Zhao To: , , CC: , , , Subject: [PATCH] common/mlx5: remove unneeded field when modify RQ table Date: Wed, 17 Jul 2024 19:37:19 +0300 Message-ID: <20240717163719.324798-1-bingz@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B374:EE_|PH7PR12MB9068:EE_ X-MS-Office365-Filtering-Correlation-Id: d32e901d-9e94-4879-2c55-08dca67ed06f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dR4fNkUHvTT3ClnEL2F0Y0Zzhf8FdKMc2PanzZ/L+YdBIESecQR2lUM9QFvc?= =?us-ascii?Q?cYs81ZQgZ1hp2Meij8pZk0i/xMuH9fwfmkCGEZeKFVgUSlpmu0/tMgtmdzjT?= =?us-ascii?Q?J33p5rLcz1jqL4i5Ay/J72gDGiAFp6hsfERpp+JiV46WHj2cLpjZNsQCNxTp?= =?us-ascii?Q?dx1Y6PIbM96uV/7+POGGj9kUx/clWKWkbftvNMZCVD5E1epbt9N1hcW2SkTN?= =?us-ascii?Q?YT1/AfA4szDBggCjNFZs490DD0R3z+3KQGzw4MiefBFX+B+yUP05ubUbh293?= =?us-ascii?Q?pDbkmIN3f3uUdG9NeuaXWR4fsfMKL2EuoEfDr51ilXYba9DY6Qwg4T+b4iC7?= =?us-ascii?Q?utdCuMOVs8ToVPMehj3ekeZZf5oiq4v/+8Rkpc6Q005XJM71lhjwZQfRViQA?= =?us-ascii?Q?f5bMC8lE0qvCxo3YsYLm4oRoplDFToWYQ+iiyskUTW+b3g+MDItjACrVv51J?= =?us-ascii?Q?HwLdwrhdKzuQ8YjUoun9JyOfiM7wJz2NCxRHfFYK6cNllo56L9tqWbyaImVt?= =?us-ascii?Q?1Hkq2AxvgldIfdk+8v6sk0BtP6lkxz+fai9Sp7bU2jVmPrGPENJnekn2T0Bq?= =?us-ascii?Q?Bft/zkee5hh4GYo0yOQSpHcQCT9BvyuEeRz9toK6M8wtpwHXqkn7SCfYAo3n?= =?us-ascii?Q?0jDFYL/F3gcrhWbtj/IUy7iJXPCaXueW89QL+Hy2h/zuP0TFGUN3MtpkmGUP?= =?us-ascii?Q?iW1JUsebOvnSJjxgKjXLHTldE/OD6YEUeafRFzHj3jbuG2VHMfMQX3scB8RB?= =?us-ascii?Q?5DcZf+Z+UpK4IM+KRZIfrl1pEqxRs0a7vnYuOXJfPRMQ/BpzL/cEhqxtmb38?= =?us-ascii?Q?LGoZ49taiNKQr3aR4x3oJSub8cKNmIgGb6OOGoNhI27SIv/HR63AI1ooxQqf?= =?us-ascii?Q?+j81HePd3Ba7xJcEu3kr70dukfjjRd5oX8pzExozhV2j6l2ORVqEC75l9igE?= =?us-ascii?Q?+QFIVTz5HEfFmIO6NoPWlNxUGA6CLqVl0i15ykuenZQ+ax8U4/Rv1y+3936+?= =?us-ascii?Q?OhmrW8VT3/5tzB31uJ71Zq0t+Kn+/6MtQyPl2O9lJ3MystipM8b8OnPc7izl?= =?us-ascii?Q?izyDf68H1z+pV+TNRHYTl4Xq4uoXf105Mx2VHMAXloVMMOkwQoaq+GNky0kN?= =?us-ascii?Q?7zDBSltXFAy+yavA5ZjqHdAmA+388YCrRXvTdPwBLLB5gWCo9HHzewlM2woG?= =?us-ascii?Q?8mK/JrsH621+G4Jrq4NgO8IBsRUUrPpMdiEBKLNRwXe7gTHZUkF71yyhieCb?= =?us-ascii?Q?zjJN4D33kt7EdQ4w2oLLktRa90YlPGcNMfWbhjF7qDU+hNbLDJGm5KtYHSNy?= =?us-ascii?Q?VDyuiqfSR/DrHrOf0djx2DRVXirsSNv2ERouTOj6xjTSS1XGN4pu0Fg1LMk7?= =?us-ascii?Q?gfr/PHDXOtbHeBU2cLL6jpcshWplihdyjuBRci92pOtEIW+jR3RlvZU4LBiL?= =?us-ascii?Q?FqoZjJb1ds9bCCrCdDsVgn8RSwS1HV8m?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2024 16:37:57.0929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d32e901d-9e94-4879-2c55-08dca67ed06f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B374.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9068 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The attribute "rqt_max_size" of the RQT(RQ table) context is only needed by when creating a new one. When modifying an old one, there is no need to set this attribute. The firmware usually ignored this unneeded field. When enabling some extra check, an error will be returned to prevent the code from continuing to run. In the meanwhile, this field will always be set to the maximal one fetched from the capability without any change. Removing the value set and leave it to 0 will help to solve the potential failure. Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT") Cc: matan@nvidia.com Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index 8e12ac50de..9710dcedd3 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -1914,7 +1914,6 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, MLX5_SET64(modify_rqt_in, in, modify_bitmask, 0x1); rqt_ctx = MLX5_ADDR_OF(modify_rqt_in, in, rqt_context); MLX5_SET(rqtc, rqt_ctx, list_q_type, rqt_attr->rq_type); - MLX5_SET(rqtc, rqt_ctx, rqt_max_size, rqt_attr->rqt_max_size); MLX5_SET(rqtc, rqt_ctx, rqt_actual_size, rqt_attr->rqt_actual_size); for (i = 0; i < rqt_attr->rqt_actual_size; i++) MLX5_SET(rqtc, rqt_ctx, rq_num[i], rqt_attr->rq_list[i]); -- 2.34.1