From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B02B645643; Thu, 18 Jul 2024 11:58:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A968742E6D; Thu, 18 Jul 2024 11:58:03 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by mails.dpdk.org (Postfix) with ESMTP id E1DBA42E77 for ; Thu, 18 Jul 2024 11:58:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SpADYJ1EkqO/awfZdusEagoAbTLhK0EFfcBh6/2tzgkCi6M+U0j8YmgWq7J+HWW5heKn+SgF0oCV9l35vVNszNHQ6sgv8y/+efo6hJFIF3EUXrINtrho5PL+eEX5DIvmi0LsEoBks7TCqaEhSeVmOYkG0nSjy4a5gfKpipUImLZLcpj0FJVywPIoDiHKb4GC7CtaKEnd9PW8lUmMh3Vu0/t7SKEniM2BYAjDyaZZkqu+QmIXl/KozB3Hx5/nlaBCacsQN+U6B3vaffRXl8U+bbOEaKxQ0vnKKsH0MVqCMwCl7pchYDXyzhdEA9aAzvzj7YM0EAXn7sPeinX+zJ7wiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nK+LvHr7OM9rRzGVTLqXXzMvGyqWsttgXMOPXy1gwPs=; b=aQc+nOJRd7CYu1OFo4Jr+4rsxQppzMKHsRSg0z4QG1IYoCzTUdp4Lq7S6ybgWcGg7WHvlCfapb4NsNioo9obt5WknYklkww/XmvNvQNO1v8rzLVehiiLxbp5p7N5iwskfbba3QYYtKRRe7upTZemYoOxYNAc0DpUwkSNpRfJohZ3/1yx+E9UiUsUoPnURjgL74qX089FpgabdA2ACWlRerMLW/6yCTaw9hOrAehzUuJa89EppUTNZb/X2ghlpQsTBe/QvVh+FjokveazxZzJ07iVetVvF1SzV3EGGojdmTEB5ueCjOAmSf0lWWPdwxXcgPyHzcXId+GhuZOxwIL4Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nK+LvHr7OM9rRzGVTLqXXzMvGyqWsttgXMOPXy1gwPs=; b=VQLyoER1++Krm0lj5Ii0gXm14tKGwlTKbDbZx4eQOcqjYplbayVP/TIr3QbY+onJiHIluw9E7r+Qxvpe0bvIBBbgJA63bl3nGGiQT1xq6GED1U/FnefiAFlRbmsugFIcSTt0vMJJakAlY84GpMt3wAL0bUu49GpwNix2mip3pu2nAO3j5Jomx3vcWQ3PXGafAEKU2jDeaRgglP6xsPwYmQkrpJzHCl14gwdMwXn2miSK0ukYDutUYnQjJESt/irIr1rLsj2TgKKOZh9DrI6/zd/yO2RTQtGd00hCY53oOgoAokaOaLH/dRaR6eLS7Af7M5XeoMAZBq9C57/7/1TQPg== Received: from SJ0PR13CA0024.namprd13.prod.outlook.com (2603:10b6:a03:2c0::29) by PH7PR12MB7939.namprd12.prod.outlook.com (2603:10b6:510:278::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Thu, 18 Jul 2024 09:57:57 +0000 Received: from CO1PEPF000075ED.namprd03.prod.outlook.com (2603:10b6:a03:2c0:cafe::69) by SJ0PR13CA0024.outlook.office365.com (2603:10b6:a03:2c0::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.17 via Frontend Transport; Thu, 18 Jul 2024 09:57:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000075ED.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.11 via Frontend Transport; Thu, 18 Jul 2024 09:57:57 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 18 Jul 2024 02:57:39 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 18 Jul 2024 02:57:37 -0700 From: Dariusz Sosnowski To: Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad CC: , Raslan Darawsheh Subject: [PATCH 2/3] net/mlx5: fix action configuration validation Date: Thu, 18 Jul 2024 11:57:16 +0200 Message-ID: <20240718095717.290960-3-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240718095717.290960-1-dsosnowski@nvidia.com> References: <20240718095717.290960-1-dsosnowski@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000075ED:EE_|PH7PR12MB7939:EE_ X-MS-Office365-Filtering-Correlation-Id: 45206222-4c29-4c45-4ead-08dca71019ba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?UC9wpGaAR6k3zLpglHXzgeO/e9awMypdPHU9pVgfzgkrY/RueskpDW4vLc2B?= =?us-ascii?Q?54FNHiA4EBcmA6jenENOfhNcjxPtngY2UCNHhdsKtr7hXOq86fwa9QRxTE0U?= =?us-ascii?Q?iNCKzcQ+KvhuV0MvxzGGmJiMIrBMhd1aaZe3cXOzO6+OQXSmGyzZ4wpRFOiP?= =?us-ascii?Q?/m2kyhYbTiiugmm39FdX7jAlizSw2OgdJ2EryW96CCZ8K2pnWpPw+mEyfsqW?= =?us-ascii?Q?jjB3AwLeufMkO+OZbZbajlBRnCL9TRF7Q/1zclwgnPkuA/KBuP5VrdIHGPEt?= =?us-ascii?Q?+GV/HnXBAaU4DT4DkLBF+lE95gZHq/6D21roPPI3Eu7V2FA5r4AF75YxGeMU?= =?us-ascii?Q?ROSGyAHWvJ+iXy6GeklQLRh+Eiu4Um764nm8VLXes+mtekAAM+O7P0MHs7zu?= =?us-ascii?Q?3a8LO0MTid9QYOfZVjI3JvvAriK+MYcY06oKBcmfA7Pjb/Us2gOdFkNRBS8w?= =?us-ascii?Q?eAuZs8m4ISzNYnaeokxZBJiT0skH17+SKAE1MTIwokk7Uq1e1jSuD1kZVTMp?= =?us-ascii?Q?acTjIO+mwTEcUiFW5h2AEmxesIMaRc0bou+XcY49h4C3LiZACd+ALRsrVbk0?= =?us-ascii?Q?+E1z0XhIn/PuXcQkf/dsGkP1CV6F502QM5tOJVW5wIqQqeA2cRiQ1d2lz/Xi?= =?us-ascii?Q?XIHeCJd6Yxl/MiF9Kx2qDJ9N26NIwxc4I+eb7XDESjcng0UdiriU4gDIXQcO?= =?us-ascii?Q?PW/xxl74FAWe8ypbYy24iEGv9Jv59YK6uJg1pKEhtQ8BUE5TogLv4HaQFjmy?= =?us-ascii?Q?rwhUsmnryRrtailbNOR71G7KJ/06tHXgoLt+3SP2W3kNwav/OR8yrat2zYbO?= =?us-ascii?Q?XuaEpqnDTGODQo1AG2i9xQJZaiIZMWYFFAfyyXWWe45FTNDZs9ppJb5ao3bU?= =?us-ascii?Q?7olKdLqCKRUnZ7pV4zRoHs5jXoqFYhrMa8wzXuoSubnN6feEEctw5NuZp8hH?= =?us-ascii?Q?qqFyfyrzS/FQOOXhkScD/+sLTQKVugsYypY7lWYLsTA+A0Y9pu4r9hZbJBWM?= =?us-ascii?Q?OuciVWmDcocZXAKbxCspjIgtPW79fVPv3OY8XCrJ8sMd+Onf9RGQDmAYSad4?= =?us-ascii?Q?Q+u/ygQDexWuSgoric+/tlhecKkqVmk4RiuydMYjcqdVaAOkQANE4gM7JxpW?= =?us-ascii?Q?IyJf4aW+/O6BA4WMn01Wby5KGVQ3OZkDnJYh07c+hVZxrCy8TwolqfK9E7NM?= =?us-ascii?Q?J0T8NMcuo3L0Rah0bkYViN/8ecGNHvd7WXBaaRvOzuws94F1jJb1RH9M35ip?= =?us-ascii?Q?BR19GSwVRxCNtK9kKSmg6wsMyDox8MbwE/ttWadl7UHJAGN1Nk6DdCiWj75N?= =?us-ascii?Q?5pnxIqvQljAG8mHXUlXiMshfJhcai8YUw8HeGowEYFXyk5L2aK3KtFM8FXBV?= =?us-ascii?Q?gkeWyZXaJ7fV+v6WJh2916Td0i/nEKrhx9TKFAq/qBxABPeckefQtfrGBL7E?= =?us-ascii?Q?2ZoUUSYqipIxxyc/GR5KuWIJwOLB1yhi?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2024 09:57:57.1317 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45206222-4c29-4c45-4ead-08dca71019ba X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000075ED.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7939 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Checking if action configuration is required should be checked based on action type recorded in the actions template, not on user action. Also, adds a missing internal RSS action type to configuration check skip list. Fixes: 57c7b94301ee ("net/mlx5: add async flow operation validation") Signed-off-by: Dariusz Sosnowski Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index fe7df7305f..39d1cd96d4 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -16388,10 +16388,11 @@ flow_hw_validate_rule_actions(struct rte_eth_dev *dev, user_action = &actions[act_data->action_src]; /* Skip actions which do not require conf. */ - switch ((int)user_action->type) { + switch ((int)act_data->type) { case RTE_FLOW_ACTION_TYPE_COUNT: case MLX5_RTE_FLOW_ACTION_TYPE_COUNT: case MLX5_RTE_FLOW_ACTION_TYPE_METER_MARK: + case MLX5_RTE_FLOW_ACTION_TYPE_RSS: continue; default: break; -- 2.39.2