DPDK patches and discussions
 help / color / mirror / Atom feed
From: Alex Chapman <alex.chapman@arm.com>
To: dev@dpdk.org
Cc: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
	"Alex Chapman" <alex.chapman@arm.com>,
	"Jack Bond-Preston" <jack.bond-preston@arm.com>,
	"Luca Vizzarro" <luca.vizzarro@arm.com>,
	"Paul Szczepanek" <paul.szczepanek@arm.com>
Subject: [PATCH] dts: fix DPDK git tarball cast bug
Date: Fri, 19 Jul 2024 16:34:45 +0100	[thread overview]
Message-ID: <20240719153445.277851-1-alex.chapman@arm.com> (raw)

When running DTS with a git revision specified the following error occurs:
$ ./main.py --revision HEAD
[...]
FileNotFoundError: [Errno 2] No such file or directory:
     'dts/<framework.utils.DPDKGitTarball object at 0x78f69e73a5c0>'

Fix by casting DPDKGitTarball to Path, in order to stringify it correctly.

Bugzilla ID: 1496
Fixes: a23f22457dbd ("dts: constrain DPDK source argument")

Signed-off-by: Alex Chapman <alex.chapman@arm.com>
Reviewed-by: Jack Bond-Preston <jack.bond-preston@arm.com>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
---
Hello,
Sending this fix to a bug that i discovered.

Best Regards,
Alex
---
 .mailmap                  | 1 +
 dts/framework/settings.py | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 3f3f0442e5..a326e8e553 100644
--- a/.mailmap
+++ b/.mailmap
@@ -46,6 +46,7 @@ Aleksey Baulin <aleksey.baulin@gmail.com>
 Aleksey Katargin <gureedo@gmail.com>
 Ales Musil <amusil@redhat.com>
 Alessio Igor Bogani <alessio.bogani@elettra.eu>
+Alex Chapman <alex.chapman@arm.com>
 Alexander Bechikov <asb.tyum@gmail.com>
 Alexander Belyakov <abelyako@gmail.com>
 Alexander Chernavin <achernavin@netgate.com>
diff --git a/dts/framework/settings.py b/dts/framework/settings.py
index f95876113f..f6303066d4 100644
--- a/dts/framework/settings.py
+++ b/dts/framework/settings.py
@@ -415,7 +415,7 @@ def get_settings() -> Settings:
     args = parser.parse_args()
 
     if args.dpdk_revision_id:
-        args.dpdk_tarball_path = DPDKGitTarball(args.dpdk_revision_id, args.output_dir)
+        args.dpdk_tarball_path = Path(DPDKGitTarball(args.dpdk_revision_id, args.output_dir))
 
     args.test_suites = _process_test_suites(parser, args.test_suites)
 
-- 
2.34.1


             reply	other threads:[~2024-07-19 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 15:34 Alex Chapman [this message]
2024-07-22 13:06 ` Juraj Linkeš
2024-07-23 21:43   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240719153445.277851-1-alex.chapman@arm.com \
    --to=alex.chapman@arm.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jack.bond-preston@arm.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=luca.vizzarro@arm.com \
    --cc=paul.szczepanek@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).