From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6627845656;
	Fri, 19 Jul 2024 17:35:27 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 46E1640EA5;
	Fri, 19 Jul 2024 17:35:27 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id E2BDD40E5A
 for <dev@dpdk.org>; Fri, 19 Jul 2024 17:35:25 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7CC39169E;
 Fri, 19 Jul 2024 08:35:50 -0700 (PDT)
Received: from e132423.cambridge.arm.com (e132423.arm.com [10.1.36.31])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2610C3F762;
 Fri, 19 Jul 2024 08:35:24 -0700 (PDT)
From: Alex Chapman <alex.chapman@arm.com>
To: dev@dpdk.org
Cc: =?UTF-8?q?Juraj=20Linke=C5=A1?= <juraj.linkes@pantheon.tech>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Alex Chapman <alex.chapman@arm.com>,
 Jack Bond-Preston <jack.bond-preston@arm.com>,
 Luca Vizzarro <luca.vizzarro@arm.com>,
 Paul Szczepanek <paul.szczepanek@arm.com>
Subject: [PATCH] dts: fix DPDK git tarball cast bug
Date: Fri, 19 Jul 2024 16:34:45 +0100
Message-Id: <20240719153445.277851-1-alex.chapman@arm.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

When running DTS with a git revision specified the following error occurs:
$ ./main.py --revision HEAD
[...]
FileNotFoundError: [Errno 2] No such file or directory:
     'dts/<framework.utils.DPDKGitTarball object at 0x78f69e73a5c0>'

Fix by casting DPDKGitTarball to Path, in order to stringify it correctly.

Bugzilla ID: 1496
Fixes: a23f22457dbd ("dts: constrain DPDK source argument")

Signed-off-by: Alex Chapman <alex.chapman@arm.com>
Reviewed-by: Jack Bond-Preston <jack.bond-preston@arm.com>
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
---
Hello,
Sending this fix to a bug that i discovered.

Best Regards,
Alex
---
 .mailmap                  | 1 +
 dts/framework/settings.py | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 3f3f0442e5..a326e8e553 100644
--- a/.mailmap
+++ b/.mailmap
@@ -46,6 +46,7 @@ Aleksey Baulin <aleksey.baulin@gmail.com>
 Aleksey Katargin <gureedo@gmail.com>
 Ales Musil <amusil@redhat.com>
 Alessio Igor Bogani <alessio.bogani@elettra.eu>
+Alex Chapman <alex.chapman@arm.com>
 Alexander Bechikov <asb.tyum@gmail.com>
 Alexander Belyakov <abelyako@gmail.com>
 Alexander Chernavin <achernavin@netgate.com>
diff --git a/dts/framework/settings.py b/dts/framework/settings.py
index f95876113f..f6303066d4 100644
--- a/dts/framework/settings.py
+++ b/dts/framework/settings.py
@@ -415,7 +415,7 @@ def get_settings() -> Settings:
     args = parser.parse_args()
 
     if args.dpdk_revision_id:
-        args.dpdk_tarball_path = DPDKGitTarball(args.dpdk_revision_id, args.output_dir)
+        args.dpdk_tarball_path = Path(DPDKGitTarball(args.dpdk_revision_id, args.output_dir))
 
     args.test_suites = _process_test_suites(parser, args.test_suites)
 
-- 
2.34.1