From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB7CF45667; Sat, 20 Jul 2024 22:26:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65F6A4027C; Sat, 20 Jul 2024 22:26:25 +0200 (CEST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id B310A40269 for ; Sat, 20 Jul 2024 22:26:24 +0200 (CEST) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1fc4fcbb131so26542145ad.3 for ; Sat, 20 Jul 2024 13:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1721507183; x=1722111983; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wnL7MtsnkK0Tw6u/exQ5uEO/2Iw3CcyC1yPx6BMFa6o=; b=D1dsjLlVsfW0838ajJt5BrJHL6557BGPRsyKwBFeZFnqr0QAIKF7nMaJOmCw7x6BLz QwPRig7NQrJHcI5MRdHCM+I/FQqAGGnY0+tzYJLH/oOXuZ/b5WhIR8BzLaDEBQd4cPRV nzKaO2slEicmfM5PItucbEuhHhi+aywBSnfBq6p/CydMzRNoJUiBRZQpY0Qhj7E1cGOI +uN3i5TdB35UV85lrLvJXre17dwtcoxio6erECSF72PU2t8nkHIBAdoTNU/zyPgV3FCL Pv5nE/RldO3HHcqm0LyUIch6ZyBmKLeq8wkTrRwzQTbZea7hjJKDpBnLmfnVqFstgQk6 uwzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721507183; x=1722111983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wnL7MtsnkK0Tw6u/exQ5uEO/2Iw3CcyC1yPx6BMFa6o=; b=BE7fRUNcEZ4Zysfl03khkg7na9/LGzNEDLXsFpeRBNVk0svmEPSZC1f+E/podRN60u bM2wiIBSZOPJhLXn1qU2t8Ti8n+RXYz29ktf1ejLiNNjBCwxmkKQl+GefvdFE+I3D+pN SyAC39cwkr3E1ztr9tUGOOe+nPObPkHnU5cHUgIqd5T9/w7kSPxZsBDIynsv24mCWVaO utz/M5aQ07RrNpCepT7On5ljD3h11Bp4SimkKqe8SPOO8W7smNoSfDDAOVJYPHUUOZQQ sEr+NR3hmYL4a9veD2N0lTlrH178W5m57TUBU4UMP8IP64DCe+zsOAUSt6U6+Wxg88P5 9X0A== X-Forwarded-Encrypted: i=1; AJvYcCXnuiEtt5eO3Io1b+IQUlBJafRFRCG6XHmd8AsKzaZL99p1e7UviNx7Ii3AKdZnis35dJYxug9FjehwCHA= X-Gm-Message-State: AOJu0Yx5J64M92LVrZAaUQIYV33dPyuGzwkW9t8OVwotbzRjES59212z fwMpxoPJyBC/VPgRmZsAd3S2aakqvn1OaCY71wl+0sYtvXVRyTv2Wz6Xg0XDgL4= X-Google-Smtp-Source: AGHT+IFuEj7z6ziFHZAJjzivV2egAvZWycZAH0xSQn/ARWKmdd2AsTV1txP30cX5lLIDvGBFsFX2MQ== X-Received: by 2002:a17:902:e812:b0:1fc:6740:3ce6 with SMTP id d9443c01a7336-1fd74559442mr33984605ad.20.1721507183462; Sat, 20 Jul 2024 13:26:23 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fd6f486648sm25809405ad.282.2024.07.20.13.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jul 2024 13:26:23 -0700 (PDT) Date: Sat, 20 Jul 2024 13:26:19 -0700 From: Stephen Hemminger To: "Robin Jarry" Cc: Morten =?UTF-8?B?QnLDuHJ1cA==?= , "Vladimir Medvedkin" , , "Konstantin Ananyev" , , "Sunil Kumar Kori" , "Rakesh Kudurumalla" , "Wisam Jaddo" , "Cristian Dumitrescu" , "Konstantin Ananyev" , "Akhil Goyal" , "Fan Zhang" , "Yipeng Wang" , "Sameh Gobriel" , "Nithin Dabilpuram" , "Kiran Kumar K" , "Satha Rao" , "Harman Kalra" , "Ankur Dwivedi" , "Anoob Joseph" , "Tejasree Kondoj" , "Gagandeep Singh" , "Hemant Agrawal" , "Ajit Khaparde" , "Somnath Kotur" , "Chas Williams" , "Min Hu (Connor)" , "Potnuri Bharat Teja" , "Sachin Saxena" , "Xiaoyun Wang" , "Jie Hai" , "Yisen Zhuang" , "Jingjing Wu" , "Dariusz Sosnowski" , "Viacheslav Ovsiienko" , "Bing Zhao" , "Ori Kam" , "Suanming Mou" , "Matan Azrad" , "Chaoyong He" , "Devendra Singh Rawat" , "Alok Prasad" , "Andrew Rybchenko" , "Jiawen Wu" , "Jian Wang" , "Thomas Monjalon" , "Ferruh Yigit" , "Jiayu Hu" , "Pavan Nikhilesh" , "Maxime Coquelin" , "Chenbo Xia" Subject: Re: IPv6 APIs rework Message-ID: <20240720132619.4ed7a53a@hermes.local> In-Reply-To: References: <98CBD80474FA8B44BF855DF32C47DC35E9F5AB@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AC@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AE@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35E9F5AF@smartserver.smartshare.dk> <20240719100701.7e7dfc7f@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 20 Jul 2024 19:43:45 +0200 "Robin Jarry" wrote: > Cutting down the quoting a bit. > > I understand the arguments against having an unaligned packed struct. > But it is precisely what we have in the current code base. All IPv6 > addresses are uint8_t[16] arrays. And nobody ever complained about it. > > Since this rework is already massive, could we proceed in steps? > > First, I can replace all uint8_t[16] arrays by an unaligned packed > struct which is 99% of the work. > > Second, *if there is a real and measurable performance gain*, change > that structure to remove explicit alignment. > > Does this sound like a good plan to everyone? > There is no need for packing or alignment in in6_addr or current DPDK, what would be the benefit? Compilers generate worse code if a structure is marked packed.