From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D49B345683; Mon, 22 Jul 2024 18:42:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E1D040E21; Mon, 22 Jul 2024 18:40:20 +0200 (CEST) Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011013.outbound.protection.outlook.com [52.101.70.13]) by mails.dpdk.org (Postfix) with ESMTP id DBD3740ED6 for ; Mon, 22 Jul 2024 18:40:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NC2NDN9bY/CaQ7JaZsWOEUDQTDmgpoh/YRHKKUwKpSMSKHYnEnx/1VWU/pNyBhhP3KpeHfaYFFlQtlUZ8kUv5RTLSmt/M+2Qe3AJGNt7ob/Ww8hKzAWtmzlxkRlX50LNDcoxWcrIdQcHkQQU8pLzw5pajbdVNAJao3hm1sZgpns9NrFLIsMIMdNZFDbmSU+Ws2+pXEtI55J1qmus4FdLXI/WFSeiCzR3QHkrke02D4skZkIdTn7QfZOEhx6dFkkOu3JLdW7/wexW2/V0N3fd7i2tiC9ngev6HNqlm52f0IwzIpxium+JfRO0oSXpq8z+6jiuC7iADsbMjwhTj0BmHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DmwtVUZsJM/4Qi+nuyggRCNbFMQIB0bKuYJeEQVY58A=; b=HFimanadTodW+WasbV2T7MAEIiZmDCROXg0u+7QFgjlHQiakxZX2RdOafodFoJoSuTO+5STOvSnGnUBtlgo5kcaB8/adOgEelGEtj0BxUlqeGLAzJPoT+EBDOKdgYKK9KAPv5TnVvmwyDeCY9vUfJ7V78GhbU8RuWQvGPrmoLumfFaqiU+tuOeL+Oztws2IgkHdjY0Z2v91OreBuShznDlycO9HiF6vA9GDVj98ajdVWM7ERwWtr6qITh2L2FAHADNO+R86fSW7yWrplVkt7dKcfYRlkXltaoZPZL8T7HvAORbCdl00gIsguM7h5vDH44DGAU6/mQ9ba08i5pn/04g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DmwtVUZsJM/4Qi+nuyggRCNbFMQIB0bKuYJeEQVY58A=; b=KOd8Rrkr4wrz/BGe14/aEiHZ6qrk0HqKfZBzhWuBNyaJgBf74/12PgAbsRJI72kMBmwq4ieyldjU9Zm+7FG3jjXKuxnV4oLDTMg0lV+crpBOKLTvqGaN/kqpeX9CVMH4EJW2oUY416vhW4tXhh47thp/BqRw33bef81Gn2DGvTw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8SPR01MB0024.eurprd04.prod.outlook.com (2603:10a6:20b:3d0::24) by PA1PR04MB10652.eurprd04.prod.outlook.com (2603:10a6:102:491::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Mon, 22 Jul 2024 16:40:16 +0000 Received: from AS8SPR01MB0024.eurprd04.prod.outlook.com ([fe80::c634:479e:8f8a:a325]) by AS8SPR01MB0024.eurprd04.prod.outlook.com ([fe80::c634:479e:8f8a:a325%7]) with mapi id 15.20.7784.017; Mon, 22 Jul 2024 16:40:16 +0000 From: Gagandeep Singh To: dev@dpdk.org, Wathsala Vithanage , Bruce Richardson , Sachin Saxena Subject: [v3 17/30] dma/dpaa: qdma stall workaround for ERR050265 Date: Mon, 22 Jul 2024 22:09:17 +0530 Message-Id: <20240722163930.2171568-18-g.singh@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240722163930.2171568-1-g.singh@nxp.com> References: <20240722115843.1830105-1-g.singh@nxp.com> <20240722163930.2171568-1-g.singh@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SG3P274CA0014.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::26) To AS8SPR01MB0024.eurprd04.prod.outlook.com (2603:10a6:20b:3d0::24) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8SPR01MB0024:EE_|PA1PR04MB10652:EE_ X-MS-Office365-Filtering-Correlation-Id: 57d932cd-6a10-48aa-3465-08dcaa6cf793 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lcMYZ+bL93jE51VduGLTrriYchRe6ohPSjWlMokr+Mt74uTYyVxofNVeU2Jh?= =?us-ascii?Q?NMUfVYYfzNEYGCfa9sQMEY7kBiopmz4rvX/9gx6Ux+ALwyVuKqQIijJW/N/z?= =?us-ascii?Q?9OJ7sZOiJl/bb+LZ52Qf55EjOViyjmVLQvuCHzIDQWMd5aYRoy9kges0lpA4?= =?us-ascii?Q?Cnr8u5HbVbhH0LrCppYLZ45BFcgpwQuQg2WnPxIhkYP1oyut1BKCzWcrXy6s?= =?us-ascii?Q?caYmhctkWuToDAxV3V5WSTRUKOxUvXD8gy9uVIU1dFqQzYHIgAZSGg4uioQ8?= =?us-ascii?Q?oQ2Zf7b8/WpXM5BHh6NWBnTcPJskI6t9kwuCdDk8CN5MMTe2O0+9gZUiHI3p?= =?us-ascii?Q?/ynr52UVvaeUA19khTjA0ndoxHhTk/oPjAtTpKHVjR0ldnmFv4qFof9Z2wYv?= =?us-ascii?Q?acPbV2KOilGmsWw0ZkRfs+8sRFOJDnq6p+tsByzZN25EoVP+M0uhz6ruJtSp?= =?us-ascii?Q?7JMr0DPQ3UEHs4U10AKF1+OmnMJ3IdVv0cw+VHLc7ueQ1RVucXd/pytTAJ4B?= =?us-ascii?Q?TfwpdM09G+aCkgoCJ3jf+Kgm6arlKaZEiCWPj2wjO6n27TDgG/1avr9OoLff?= =?us-ascii?Q?DJ0oWsbQhUXt1+cO+EZj9OCwe3G7WfwACwYintxy7WVMQTM6/dq2LRYsRSAt?= =?us-ascii?Q?9aQrhpnRMvYuAWzkXf5KNe1kQHA0UQJBZ0mPChfJ+GPtKma7h4X0ZUfg+qh0?= =?us-ascii?Q?xVxt0eN8hBHX7X3dbWY0xUzy3FPMiQqSinCw1jOzyquSaf2FWA8D5EM3qDjM?= =?us-ascii?Q?4pPvQaVXfhAOXFJKbQbW2NWUE9SV173R+LGGRt75IZjdi+XklpHozU+geiAx?= =?us-ascii?Q?09aGGItsIjTnPt1tHxQKlmr4lVZsGPnYgPNlsCLkFw2/t3KFqGfL+S2HuZ+1?= =?us-ascii?Q?RE8uqOZ5K7U208gOi6+dEF1JpYJ9bOyuBvjlSqxg/HMIWagQEveOhpFUAf2I?= =?us-ascii?Q?JpcRnbw3UnyiAg2DK16UwIUKvBFk3XMD0gb8WpsbM212LcvqvK0IwrY6cb9Q?= =?us-ascii?Q?RkYTOJ0pLPRvlqwiTjVc/8HH5kgZh8TcmI7gBuxJgzn4Knf4Vq2qvzYYCy+3?= =?us-ascii?Q?M2vkYW96PfmOfYAP6U2nYE8lA8nctf8YJjlSIk6ySyIyxjdaUQ7xKiXtdk4Q?= =?us-ascii?Q?IAuGBa22/NPM84Vi43SXew1VYfWZdp0dxO6Njr6HaXeatHUQIEqhHLX8/w1j?= =?us-ascii?Q?vw9JvOhV9/kYAffsrutfMMK3hs9YNt7hqL2NEvtLgtkNfNotdn/ok52Tw+DG?= =?us-ascii?Q?8ruJkHUy/Ii6r7+IXbkyN4Gd1bzswAgoBbkKRJFGYplcsqdB8ESw/TygpjOR?= =?us-ascii?Q?FQoglpofgMnAI1m/1pglrdQDZdTVb1RJAB15O8nqYY/70e4PX3qx3qkd9Zmb?= =?us-ascii?Q?VnGmlzdDDs+hrM45ZPr89bPXWhhKB8n8acjUlXDEN+QK5VrksQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8SPR01MB0024.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HmXu46LiMNG4IiZZ3k5DT1IVfqcXy8ImfanjEY9XD0uxXe7M8SG8BDjbUbqC?= =?us-ascii?Q?hGUTif+MCETDS9XnrJN1spglvnVMqoTbJPkjOe8c+3zNj3kFt8udAOCdpS/r?= =?us-ascii?Q?2z31ptNgVZMn303QzjFrTfs/ppjn8tpkvR3tZlkPGwJlXRxQpQQFBvFIH92P?= =?us-ascii?Q?WDpKwN60LO8mpvTDIwx784NvW/4ucXSMg6Ghm/4E0/6GTzA9AMEbnmKHigKy?= =?us-ascii?Q?m+Y510wxj74QTgRHb07P0uWUbbaevcVLRsUb/MnOmXabzZVpRfBp+IocS81Z?= =?us-ascii?Q?SGSYamOHTGusv1mMedVRuSvncThrUxdqzF1CbJ1mxkrbT1HaMlsBNvTLAlWr?= =?us-ascii?Q?uUH2uMbtl95+uGL2yoSzrybzNYN/4MBpZ5NSj1pXG9B8OjoAXzsol7bAkxo5?= =?us-ascii?Q?vHqvH7izwNxdLgBhYS553aHRWY8KReg3CP776uCAh+ILvprjXYlJtxnvMsNp?= =?us-ascii?Q?Cc4RFRODGn7LpaWof/iaJxKzuLcpKXvicqCDESmEPiBUpEER/h0VNCGTsogo?= =?us-ascii?Q?n4kBOBT9+wgUeqVi6RkgCUMWO7hbuJiwWo+e+5ucR31CtQiTK5/GsABg8Ls0?= =?us-ascii?Q?3id/2sqM560w+I8aimTav1izC2nIUVoG5JeKtcv97UwyoB0lJmDWIpJ2bKOs?= =?us-ascii?Q?8N1zJDYWalJ4PYdo8jkCO2lXcVQYQXFwcrbByo4HdT8QeE3i0/vSC8hIOPP9?= =?us-ascii?Q?J2kN8SQFYDK5/G7Z9GfqEYWH2O+SZDVmi9zO4jGs0nLNCjqaF8IGgUrH1usI?= =?us-ascii?Q?lgN8Kn2nnroABVluHgnyjQTauvUowkQgRxtuw3vDB2p8vOULDXyWWQJv/+tp?= =?us-ascii?Q?TTnw/ewB/iksLUJykIsP/zO+yFpX09RvYJgyznYrJp3A9t8FkczoVbyfvmZh?= =?us-ascii?Q?Tg+FB+RckioepEoTPfb3QOzWGlCfKfrLLZlFHusQlOhTXCLU8OLZtNc2vy+O?= =?us-ascii?Q?tDN+FQ6gnOsp05I8yk42p5RIiVFqdBtQwFTlj7ChsunAnSW67xaeXafT4LSP?= =?us-ascii?Q?X7Ug4i+09Evw1DR+pXMPXXAXpaWJzpLYk8VZsaD2oHjyQ2WYpu+YFtnWBwHQ?= =?us-ascii?Q?tsRpyp5KPy2EjEVmLcD6E/2Ty3s4GYKWmVyIvgsS7N17hUebRyERhgPWdD8k?= =?us-ascii?Q?eJe+ZtMNnZOn7pApVcQV7bi4lw+wZ+WUteiUt5B795GYI54LE8TwTjXBNlKn?= =?us-ascii?Q?tSRE21Ng7FqE3E5sR6HvjkXiVOHFl8pwaAmqrX8guHLIUU4ydOZfG9t09M12?= =?us-ascii?Q?C07LtXCknInHB0VX6y5P5gaJ5Lrw392poo2HWipfEyZYemptItATANvxvT53?= =?us-ascii?Q?JBODpZfmb8KtsN9215iK3v8nmzYrozlXylgbZyqiXm+7l22xPNnAG5ZtLP1x?= =?us-ascii?Q?zLtk8ekhRE8mS0nfBHm8WY2WiSU6lbpc4wTm25BzG7JWlNxQqnqXkRbEaDj5?= =?us-ascii?Q?L0tLfADT+lbCkZ6Kn+jBqPO262Sr6i6019AwO6/Jf7BqFaoJosFh513OPgKy?= =?us-ascii?Q?9TBaJgWboeciTuo1NMnWZRg5QbeLRhb88I2JSnFVwdfQTOf9jnm271wvp79E?= =?us-ascii?Q?SLAVgT+azg0VLpCpsVSIK07NChI/uiO3c2jpeUSt?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57d932cd-6a10-48aa-3465-08dcaa6cf793 X-MS-Exchange-CrossTenant-AuthSource: AS8SPR01MB0024.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2024 16:40:16.8355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v2xdO8WV85yzXiuq9yDRxmpopq10vPhFgJk/qo5f1WYgSjpj1b4m60HU/pHJ27FP X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10652 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Non-prefetchable read setting in the source descriptor may be required for targets other than local memory. Prefetchable read setting will offer better performance for misaligned transfers in the form of fewer transactions and should be set if possible. This patch also fixes QDMA stall issue due to unaligned transactions. Signed-off-by: Gagandeep Singh --- config/arm/meson.build | 3 ++- doc/guides/dmadevs/dpaa.rst | 1 + drivers/dma/dpaa/dpaa_qdma.c | 6 ++++++ drivers/dma/dpaa/dpaa_qdma.h | 1 + 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index f81e466318..f63ef41130 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -469,7 +469,8 @@ soc_dpaa = { ['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false], ['RTE_MAX_LCORE', 16], ['RTE_MAX_NUMA_NODES', 1], - ['RTE_DMA_DPAA_ERRATA_ERR050757', true] + ['RTE_DMA_DPAA_ERRATA_ERR050757', true], + ['RTE_DMA_DPAA_ERRATA_ERR050265', true] ], 'numa': false } diff --git a/doc/guides/dmadevs/dpaa.rst b/doc/guides/dmadevs/dpaa.rst index 746919ec6b..8a7c0befc3 100644 --- a/doc/guides/dmadevs/dpaa.rst +++ b/doc/guides/dmadevs/dpaa.rst @@ -43,6 +43,7 @@ For builds using ``meson`` and ``ninja``, the driver will be built when the target platform is dpaa-based. No additional compilation steps are necessary. - ``RTE_DMA_DPAA_ERRATA_ERR050757`` - enable software workaround for Errata-A050757 +- ``RTE_DMA_DPAA_ERRATA_ERR050265`` - enable software workaround for Errata-A050265 Initialization -------------- diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c index a21279293c..f1878879af 100644 --- a/drivers/dma/dpaa/dpaa_qdma.c +++ b/drivers/dma/dpaa/dpaa_qdma.c @@ -179,6 +179,9 @@ fsl_qdma_comp_fill_memcpy(struct fsl_qdma_comp *fsl_comp, sdf = (struct fsl_qdma_sdf *)fsl_comp->desc_virt_addr; sdf->cmd = rte_cpu_to_le_32(FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET); +#ifdef RTE_DMA_DPAA_ERRATA_ERR050265 + sdf->cmd |= rte_cpu_to_le_32(FSL_QDMA_CMD_PF); +#endif if (len > FSL_QDMA_CMD_SSS_DISTANCE) { sdf->cmd |= rte_cpu_to_le_32(FSL_QDMA_CMD_SSEN); cfg |= rte_cpu_to_le_32(FSL_QDMA_CMD_SSS_STRIDE << @@ -247,6 +250,9 @@ fsl_qdma_pre_request_enqueue_comp_sd_desc( /* Descriptor Buffer */ sdf->cmd = rte_cpu_to_le_32(FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET); +#ifdef RTE_DMA_DPAA_ERRATA_ERR050265 + sdf->cmd |= rte_cpu_to_le_32(FSL_QDMA_CMD_PF); +#endif ddf->cmd = rte_cpu_to_le_32(FSL_QDMA_CMD_RWTTYPE << FSL_QDMA_CMD_RWTTYPE_OFFSET); ddf->cmd |= rte_cpu_to_le_32(FSL_QDMA_CMD_LWC << diff --git a/drivers/dma/dpaa/dpaa_qdma.h b/drivers/dma/dpaa/dpaa_qdma.h index 361f88856b..8cb4042bd0 100644 --- a/drivers/dma/dpaa/dpaa_qdma.h +++ b/drivers/dma/dpaa/dpaa_qdma.h @@ -80,6 +80,7 @@ #define FSL_QDMA_CMD_RWTTYPE_OFFSET 28 #define FSL_QDMA_CMD_LWC_OFFSET 16 +#define FSL_QDMA_CMD_PF BIT(17) #define FSL_QDMA_CMD_SSEN BIT(19) #define FSL_QDMA_CFG_SSS_OFFSET 12 -- 2.25.1